Re: [coreboot] [PATCH] 440BX registered SDRAM support

2011-04-06 Thread Idwer Vollering
2011/4/1 Keith Hui buu...@gmail.com: ping? Adds support for initializing registered SDRAM modules on Intel 440BX northbridge. Drops unneeded romcc-inspired programming tricks. Only set nbxecc flags (see 440BX datasheet, page 3-16) when a non-ECC module has been detected in a row via SPD;

Re: [coreboot] [PATCH] 440BX registered SDRAM support

2011-04-06 Thread Keith Hui
On Wed, Apr 6, 2011 at 6:19 PM, Idwer Vollering vid...@gmail.com wrote: Can you add a #define for SPD_MEMORY_TYPE_REGISTERED_SDRAM to src/include/spd.h as well ? If that is relevant to do, ofcourse. There isn't a separate registered SDRAM type under SPD_MEMORY_TYPE. The SDRAM module being

Re: [coreboot] [PATCH] 440BX registered SDRAM support

2011-04-01 Thread Keith Hui
ping? On Wed, Mar 30, 2011 at 11:38 PM, Keith Hui buu...@gmail.com wrote: On Tue, Mar 29, 2011 at 5:34 PM, Stefan Reinauer stefan.reina...@coreboot.org wrote: * Keith Hui buu...@gmail.com [110329 06:11]: +    if ((edosd 0x84) == 0x84) { +        edosd = 0x10; // Registered SDRAM +    }

Re: [coreboot] [PATCH] 440BX registered SDRAM support

2011-03-31 Thread Keith Hui
On Tue, Mar 29, 2011 at 5:34 PM, Stefan Reinauer stefan.reina...@coreboot.org wrote: * Keith Hui buu...@gmail.com [110329 06:11]: +    if ((edosd 0x84) == 0x84) { +        edosd = 0x10; // Registered SDRAM +    } else { +        // Clear [4:3] in case it's EDO. +        edosd = 0x07;

Re: [coreboot] [PATCH] 440BX registered SDRAM support

2011-03-29 Thread Stefan Reinauer
* Keith Hui buu...@gmail.com [110329 06:11]: +    if ((edosd 0x84) == 0x84) { +        edosd = 0x10; // Registered SDRAM +    } else { +        // Clear [4:3] in case it's EDO. +        edosd = 0x07; +//    } else if (edosd 0x02) { Besides being commented out, this piece of code

Re: [coreboot] [PATCH] 440BX registered SDRAM support

2011-03-28 Thread Keith Hui
+    if ((edosd 0x84) == 0x84) { +        edosd = 0x10; // Registered SDRAM +    } else { +        // Clear [4:3] in case it's EDO. +        edosd = 0x07; +//    } else if (edosd 0x02) { Besides being commented out, this piece of code would never be executed, as there already is an else

[coreboot] [PATCH] 440BX registered SDRAM support

2011-03-27 Thread Keith Hui
See attached for patch with sign-off inside. Boot tested on ASUS P2B-LS with both regular and registered ECC modules. Now that I got some registered ECC modules in, I am able to code up this patch to allow registered SDRAM to initialize. This is needed in advance of ECC support because most ECC

Re: [coreboot] [PATCH] 440BX registered SDRAM support

2011-03-27 Thread Stefan Reinauer
On 3/27/11 5:36 AM, Keith Hui wrote: Adds support for initializing registered SDRAM modules on Intel 440BX northbridge. Signed-off-by: Keith Hui buu...@gmail.com Index: src/northbridge/intel/i440bx/raminit.c === ---