Re: [coreboot] [PATCH] CONFIG_DEBUG_RAM_SETUP breaks build on i82810, i440bx and maybe more

2010-12-23 Thread Uwe Hermann
On Tue, Dec 21, 2010 at 11:01:23PM -0500, Keith Hui wrote: Signed-off-by: Keith Hui buu...@gmail.com Thanks, r6206. We should convert all CAR-using chipsets/boards to use printk() always, indeed. I might post further patches for that at some point. Uwe. -- http://hermann-uwe.de |

Re: [coreboot] [PATCH] CONFIG_DEBUG_RAM_SETUP breaks build on i82810, i440bx and maybe more

2010-12-21 Thread Idwer Vollering
2010/12/21 Keith Hui buu...@gmail.com: As promised. Attached is my fix: Copy/paste: Index: src/northbridge/intel/i440bx/raminit.c === --- src/northbridge/intel/i440bx/raminit.c (revision 6205) +++

Re: [coreboot] [PATCH] CONFIG_DEBUG_RAM_SETUP breaks build on i82810, i440bx and maybe more

2010-12-21 Thread Keith Hui
On Tue, Dec 21, 2010 at 8:53 AM, Idwer Vollering vid...@gmail.com wrote: 2010/12/21 Keith Hui buu...@gmail.com: As promised. Attached is my fix: Copy/paste: *snip* Index: src/northbridge/intel/i440bx/debug.c === ---

[coreboot] [PATCH] CONFIG_DEBUG_RAM_SETUP breaks build on i82810, i440bx and maybe more

2010-12-20 Thread Keith Hui
As promised. Attached is my fix: Fully convert 440BX RAM init debugging to use printk(). Fixes build breakage with CONFIG_DEBUG_RAM_SETUP enabled. A number of debugging messages have been tweaked to take advantage of the new found ability to output decimal numbers. :-D I also need to make a