Re: [coreboot] [PATCH] Fix infinite loop in pnp_get_ioresource()

Alex G. wrote: Fix an infinite loop in pnp_get_ioresource(), which freezes coreboot if a rare condition arises. Signed-off-by: Alexandru Gagniuc mr.nuke...@gmail.com Unfortunately the patch was lost. Please send it, want to fix all bugs like this! :) //Peter -- coreboot mailing list:

Re: [coreboot] [PATCH] Fix infinite loop in pnp_get_ioresource()

Unfortunately the patch was lost. Please send it, want to fix all bugs like this! :) You're a bit late :) . I resent the patch last night, and Stefan wrote a better one based on it. Alex -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot

[coreboot] [PATCH] Fix infinite loop in pnp_get_ioresource()

Fix an infinite loop in pnp_get_ioresource(), which freezes coreboot if a rare condition arises. Signed-off-by: Alexandru Gagniuc mr.nuke...@gmail.com --- -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot

[coreboot] [PATCH] Fix infinite loop in pnp_get_ioresource()

Fix an infinite loop in pnp_get_ioresource(), which freezes coreboot if a rare condition arises. Signed-off-by: Alexandru Gagniuc mr.nuke...@gmail.com --- Index: src/devices/pnp_device.c === --- src/devices/pnp_device.c (revision

Re: [coreboot] [PATCH] Fix infinite loop in pnp_get_ioresource()

Hi Alexandru, thanks for finding this issue. I think I ran into this before. We should not silently continue in this case, and not create a resource either. The problem is most likely caused by a faulty devicetree.cb or superio driver. Hence, I suggest to print an error instead. See patch. Can

Re: [coreboot] [PATCH] Fix infinite loop in pnp_get_ioresource()

Hi Stefan, Thanks for the heads-up. In my case it's the MIDI device from the W83627EHG that has the broken mask. I see no difference when not creating the resource, so I doubt this breaks anything. Alex Acked-by: Alexandru Gagniuc mr.nuke...@gmail.com On 01/29/2011 01:03 AM, Stefan Reinauer