Mart Raudsepp wrote:
+ { 0, 1, IG8_STS_PRIM, Primary Input 8, PRESENT_BIN, {
+ { MSR1(0), No interrupt. },
+ { MSR1(1), Interrupt status. },
Like Myles said, Interrupt set or maybe Interrupt requested
for value '1'
I like set over
Mart Raudsepp wrote:
I was surprised to see this patch not included yet in some form.
Do you need more review to an updated patch or just this poke? :)
Poke is good. Thanks.
//Peter
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
Ühel kenal päeval, N, 2009-02-05 kell 04:05, kirjutas Peter Stuge:
Tom Sylla wrote:
+ { 0x5148, MSRTYPE_RDWR, MSR2(0, 0), DIVIL_LBAR_IRQ, Local BAR
- IRQ Mapper, {
+ { 63, 15, RESERVED },
+ { 48, 1, RESERVED },
I'm sure there is some reason, but why isn't
Tom Sylla wrote:
+ { 0x5148, MSRTYPE_RDWR, MSR2(0, 0), DIVIL_LBAR_IRQ, Local BAR
- IRQ Mapper, {
+ { 63, 15, RESERVED },
+ { 48, 1, RESERVED },
I'm sure there is some reason, but why isn't this just
{ 63, 16, RESERVED }, ?
It does not matter to msrtool at
2009/1/30 Peter Stuge pe...@stuge.se:
Peter Stuge wrote:
Can someone please review these register definitions? Thank you!
Attaching latest version also available at
http://stuge.se/mt.cs5536_pic_divil3.patch
const struct msrdef cs5536_msrs[] = {
+ /* 0x5148-0x514f per 33238G
Peter Stuge wrote:
Can someone please review these register definitions? Thank you!
Attaching latest version also available at
http://stuge.se/mt.cs5536_pic_divil3.patch
//Peter
msrtool: CS5536: The most important interrupt MSRs and some DIVIL MSRs.
Signed-off-by: Peter Stuge pe...@stuge.se
-Original Message-
From: coreboot-boun...@coreboot.org [mailto:coreboot-boun...@coreboot.org]
On Behalf Of Peter Stuge
Sent: Friday, January 30, 2009 9:17 AM
To: coreboot@coreboot.org
Subject: Re: [coreboot] msrtool CS5536 interrupt and DIVIL LBAR MSRs
Peter Stuge wrote:
Can
Can someone please review these register definitions? Thank you!
//Peter
msrtool: CS5536 definitions for the most important interrupt MSRs and DIVIL
LBARs.
Signed-off-by: Peter Stuge pe...@stuge.se
Index: cs5536.c
===
---
Peter Stuge wrote:
Can someone please review these register definitions? Thank you!
I know it is mind numbing, but I would really like someone else to
have a look before committing this. Thanks again!
//Peter
--
coreboot mailing list: coreboot@coreboot.org
9 matches
Mail list logo