[coreboot] t420 CPU Upgrade

https://www.coreboot.org/Board:lenovo/t420 How stable is the i7-3720qm CPU Upgrade in the t420?  You guys have it listed under the tested portion.  I want to grab myself one, but would want to see if it's worth my time to upgrade the CPU, or just go with something more powerful. -- coreboot

Re: [coreboot] [RFC] Deciding on style for multi-line comments

>> But I'm really with Linus when it comes to the leading, single asterisk. >> It looks totally weird, IMHO >> >> /* A small, concise comment >> that doesn't fit a single line */ >> >> is easier for the eye than >> >> /* A small, concise comment >>* that doesn't fit a single line */

Re: [coreboot] [RFC] Deciding on style for multi-line comments

So it looks like we're pretty much all in agreement with 1-line and >=3 line comments. My only real concern is if "--ignore BLOCK_COMMENT_STYLE" in the patch removes the check for the long comments, though I confess to being ignorant of how checkpatch works. To chip in my own $0.02 on the 2-line

Re: [coreboot] [RFC] Deciding on style for multi-line comments

On 26.08.2016 17:56, Vadim Bendebury wrote: > I actually tend to agree with Julius that it does not make sense to waste 4 > lines for a two line comment. So, ideally the tool should be enforcing the > verbose style for comments longer than say 2 lines. Well, I too prefer the concise style for

Re: [coreboot] [RFC] Deciding on style for multi-line comments

agree w/Julius as well. > 2 lines use verbose seems like a reasonable rule. On Fri, Aug 26, 2016 at 10:56 AM, Vadim Bendebury wrote: > I actually tend to agree with Julius that it does not make sense to waste > 4 lines for a two line comment. So, ideally the tool should

Re: [coreboot] [RFC] Deciding on style for multi-line comments

And I don't really care either way. Let's either update the documentation or follow it though. If we have coding standards, let's follow them. If we feel like the individual programmer knows best for everything, let's SAY that so I can stop trying to fix whitespace in the reviews. On Fri,

Re: [coreboot] [RFC] Deciding on style for multi-line comments

I actually tend to agree with Julius that it does not make sense to waste 4 lines for a two line comment. So, ideally the tool should be enforcing the verbose style for comments longer than say 2 lines. --vb On Fri, Aug 26, 2016 at 8:48 AM, Martin Roth wrote: > Can we

Re: [coreboot] [RFC] Deciding on style for multi-line comments

Can we please just decide on some tool and setting that we can run all the changes through that will "correctly" format it so we can stop arguing about the format? Martin On Thu, Aug 25, 2016 at 12:59 PM, Julius Werner wrote: > First of all, let's dispel the notion that

[coreboot] New on blogs.coreboot.org: [GSoC] Multiple status registers, block protection and OTP support, wrap-up (1/2)

A new post titled "[GSoC] Multiple status registers, block protection and OTP support, wrap-up (1/2)" has been published on the coreboot blog. Find the full post at http://blogs.coreboot.org/blog/2016/08/26/gsoc-sr-wp-otp-wrap-up-12/ Hello! GSoC 2016 coding period has come to an end and mentor’s

[coreboot] New Defects reported by Coverity Scan for coreboot

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 2 new defect(s) introduced to coreboot found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1361947: Code maintainability issues