[coreboot] Re: Master currently broken on Thinkpad X230 when using option table

2020-12-06 Thread Iru Cai
By using gdb, I can debug on QEMU. I can see in bootblock, romstage and postcar, when USE_OPTION_TABLE is set, the debug_level option is always read, so there is a cbfs_map_ro() in each stage. The buggy thing is in postcar stage, the cbfs mcache cannot be found, so its size becomes zero, then all

[coreboot] Re: Master currently broken on Thinkpad X230 when using option table

2020-12-06 Thread Iru Cai
Confirmed on qemu-i440fx. It's strange that it already has different behavior in romstage between setting and not setting USE_OPTION_TABLE. I still don't know what is broken in this commit. On Sun, Dec 06, 2020 at 11:24:11PM +0100, Merlin Büge wrote: > > 9d0cc2aea9 cbfs: Introduce cbfs_ro_map()

[coreboot] Master currently broken on Thinkpad X230 when using option table

2020-12-06 Thread Merlin Büge
Hi, on my Thinkpad X230 coreboot master does not boot when using the option CONFIG_USE_OPTION_TABLE=y. The screen just stays black. I have no log. This may also affect other platforms(?). I git-bisected the issue and it seems the following commit has introduced it: 9d0cc2aea9 cbfs: Introduce