Re: [coreboot] [RFC] Deciding on style for multi-line comments

>> But I'm really with Linus when it comes to the leading, single asterisk. >> It looks totally weird, IMHO >> >> /* A small, concise comment >> that doesn't fit a single line */ >> >> is easier for the eye than >> >> /* A small, concise comment >>* that doesn't fit a single line */

Re: [coreboot] [RFC] Deciding on style for multi-line comments

So it looks like we're pretty much all in agreement with 1-line and >=3 line comments. My only real concern is if "--ignore BLOCK_COMMENT_STYLE" in the patch removes the check for the long comments, though I confess to being ignorant of how checkpatch works. To chip in my own $0.02 on the 2-line

Re: [coreboot] [RFC] Deciding on style for multi-line comments

On 26.08.2016 17:56, Vadim Bendebury wrote: > I actually tend to agree with Julius that it does not make sense to waste 4 > lines for a two line comment. So, ideally the tool should be enforcing the > verbose style for comments longer than say 2 lines. Well, I too prefer the concise style for

Re: [coreboot] [RFC] Deciding on style for multi-line comments

agree w/Julius as well. > 2 lines use verbose seems like a reasonable rule. On Fri, Aug 26, 2016 at 10:56 AM, Vadim Bendebury wrote: > I actually tend to agree with Julius that it does not make sense to waste > 4 lines for a two line comment. So, ideally the tool should

Re: [coreboot] [RFC] Deciding on style for multi-line comments

And I don't really care either way. Let's either update the documentation or follow it though. If we have coding standards, let's follow them. If we feel like the individual programmer knows best for everything, let's SAY that so I can stop trying to fix whitespace in the reviews. On Fri,

Re: [coreboot] [RFC] Deciding on style for multi-line comments

I actually tend to agree with Julius that it does not make sense to waste 4 lines for a two line comment. So, ideally the tool should be enforcing the verbose style for comments longer than say 2 lines. --vb On Fri, Aug 26, 2016 at 8:48 AM, Martin Roth wrote: > Can we

Re: [coreboot] [RFC] Deciding on style for multi-line comments

Can we please just decide on some tool and setting that we can run all the changes through that will "correctly" format it so we can stop arguing about the format? Martin On Thu, Aug 25, 2016 at 12:59 PM, Julius Werner wrote: > First of all, let's dispel the notion that

Re: [coreboot] [RFC] Deciding on style for multi-line comments

First of all, let's dispel the notion that there was one "correct" and one "wrong" comment style in coreboot right now. If we count the amount of multi-line comments in the concise style > coreboot $ egrep '^\s*/\* [^/]+$' src/ | wc > 5230 50584 491997 against the amount of multi-line comments

Re: [coreboot] [RFC] Deciding on style for multi-line comments

I say let's stick with the Linux kernel style, this makes it easier to use the tools. And being a much bigger and much more mature codebase, kernel is not a bad example to follow in general. --vb On Wed, Aug 24, 2016 at 12:08 AM, Paul Menzel via coreboot < coreboot@coreboot.org> wrote: > Dear

[coreboot] [RFC] Deciding on style for multi-line comments

Dear coreboot folks, The coding style currently demands the following style of multi-line comments [1]. > The preferred style for long (multi-line) comments is: /* * This is the preferred style for multi-line * comments in the Linux kernel source code. *