Re: [coreboot] commit messages and their suitability for coreboot.org

2015-12-23 Thread Aaron Durbin via coreboot
On Tue, Dec 22, 2015 at 7:12 PM, Alex G. wrote: > There's a trend I've been noticing about commit messages which is to > follow google's format for everything coreboot. Please stop this. > > Here's why google's format is not suitable in many respects. For the > sake of

Re: [coreboot] commit messages and their suitability for coreboot.org

2015-12-23 Thread Carl-Daniel Hailfinger
Hi, given that testing is something I value a lot, I'd like to chip in. On 23.12.2015 17:06, Aaron Durbin via coreboot wrote: > On Tue, Dec 22, 2015 at 7:12 PM, Alex G. wrote: >> [...]For the >> sake of example, I will pick on a RABDOM commit message which follows >> the

[coreboot] commit messages and their suitability for coreboot.org

2015-12-22 Thread Alex G.
There's a trend I've been noticing about commit messages which is to follow google's format for everything coreboot. Please stop this. Here's why google's format is not suitable in many respects. For the sake of example, I will pick on a RABDOM commit message which follows the format: commonlib: