Re: [coreboot] Dell Dimension 8300 reboots when grub2 cbfs module is loaded

04.11.2015 00:41, Nico Huber пишет: Hi Andrei, your patch looks good generally, but the check is off by one. It's Yes, but it should not matter in real life. Last 4 bytes are pointer, so header cannot start after 0xffdc anyway. I'll change it. obvious, we want to have sane checking

Re: [coreboot] Dell Dimension 8300 reboots when grub2 cbfs module is loaded

03.11.2015 19:28, Vladimir 'phcoder' Serbinenko пишет: The code itself looks good but I'd like more details. Reading 0x shouldn't cause reboot. Why does it? That I do not know nor do I have access to system in question myself. I sent user patch that modified validate_header to do each

Re: [coreboot] Dell Dimension 8300 reboots when grub2 cbfs module is loaded

On Tue, Nov 3, 2015 at 10:28 AM, Vladimir 'phcoder' Serbinenko wrote: > The code itself looks good but I'd like more details. Reading 0x > shouldn't cause reboot. Why does it? It's probably implementation defined reading a multi-byte object from 4GiB-1. Does it wrap?

Re: [coreboot] Dell Dimension 8300 reboots when grub2 cbfs module is loaded

Le 3 nov. 2015 6:46 PM, "Aaron Durbin" a écrit : > > On Tue, Nov 3, 2015 at 10:28 AM, Vladimir 'phcoder' Serbinenko > wrote: > > The code itself looks good but I'd like more details. Reading 0x > > shouldn't cause reboot. Why does it? > > It's

Re: [coreboot] Dell Dimension 8300 reboots when grub2 cbfs module is loaded

Hi Andrei, your patch looks good generally, but the check is off by one. It's obvious, we want to have sane checking there. Reading from a random address can cause trouble and 0x is not the only offending address. On x86, the cbfs is mapped right below the 4GiB line. Current machines

Re: [coreboot] Dell Dimension 8300 reboots when grub2 cbfs module is loaded

Thanks Andrei, Vladimir, what do you think? Martin On Sun, Nov 1, 2015 at 7:53 AM, Andrei Borzenkov wrote: > I was debugging problem reported by user on Dell Dimension 8300 - it > rebooted when doing "ls -l". It turned out, the problem was triggered by > loading cbfs which

Re: [coreboot] Dell Dimension 8300 reboots when grub2 cbfs module is loaded

The code itself looks good but I'd like more details. Reading 0x shouldn't cause reboot. Why does it? Le 1 nov. 2015 3:53 PM, "Andrei Borzenkov" a écrit : > I was debugging problem reported by user on Dell Dimension 8300 - it > rebooted when doing "ls -l". It turned

[coreboot] Dell Dimension 8300 reboots when grub2 cbfs module is loaded

I was debugging problem reported by user on Dell Dimension 8300 - it rebooted when doing "ls -l". It turned out, the problem was triggered by loading cbfs which probed for header. System has 2GB memory, and attempt to read from address 0x caused instant reboot. 0x was returned