[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2022-01-03 Thread Sameeruddin Shaik
Hi David, When this feature will be available in the gerrit? --sameer. On Tue, Dec 28, 2021, 9:49 PM David Hendricks wrote: > Hi Sameer, > > > hi Patrick, > > I will use this Private feature very badly in my daily job, for some > > critical code. I will create a private CL in gerrit and will

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-12-28 Thread David Hendricks
Hi Sameer, > hi Patrick, > I will use this Private feature very badly in my daily job, for some > critical code. I will create a private CL in gerrit and will build a > Coreboot by using jenkins based on other builds by cherry picking > this private CL. I am not from a developer background, i

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-12-27 Thread Sameeruddin Shaik
hi Patrick, I will use this Private feature very badly in my daily job, for some critical code. I will create a private CL in gerrit and will build a Coreboot by using jenkins based on other builds by cherry picking this private CL. I am not from a developer background, i just want to know, if

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-11-12 Thread Patrick Georgi via coreboot
12. November 2021 20:35, "Felix Singer" schrieb: > Is it possible to rename the label to something else, so that it > doesn't sound so strong anymore? Like "hidden", for example. Or does > this need changes in its code? I was thinking about renaming the feature "hide from UI" or something like

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-11-12 Thread Felix Singer
In my experience, marking patches as WIP doesn't really help. I still get reviews and comments for these patches. While I appreciate that, it's also kind of annoying. The private feature allows me to draft my patches and to get them in a reviewable state without getting interrupted. Same if you

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-11-12 Thread Patrick Georgi via coreboot
Since this appears to be blowing up (because we didn't have enough crap this week already, right?), let me respond a bit longer to the list for completeness sake: 12. November 2021 11:05, "Keith Emery" schrieb: > But would anyone else like to explain why this isn't a GPL violation? Because >

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-11-12 Thread Lance Zhao
Yes, private is a state in between but not a result. I may want to have a "private" commit first before set it to public visible. Christian Walter 于 2021年11月12日周五 下午6:18写道: > Yeah - no. > > The GPL allows you do keep your modifications private as long as you do > not release them in any way. So

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-11-12 Thread Christian Walter
Yeah - no. The GPL allows you do keep your modifications private as long as you do not release them in any way. So if these private changes are not released somewhere they do not need to be public. Chris > > Am 12.11.2021 um 11:06 schrieb Keith Emery : > > Your well within your rights not

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-11-12 Thread Keith Emery
Your well within your rights not to. I don't believe anyone should be compelled to expend effort for which they are not compensated. But would anyone else like to explain why this isn't a GPL violation? Because it really seems like it is. On 12/11/21 8:44 pm, Patrick Georgi wrote: 12.

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-11-12 Thread Keith Emery
I don't recall any section of the GPL that mentions 'private' repositories. I'm fairly sure it say's 'you must publish the source code AND any changes'. Did that change at some point? As it stands the commit that is known to be working with my hardware has just 'disappeared'. Thus making life

[coreboot] Re: "Private" changes on Gerrit are now disabled and removed

2021-11-11 Thread David Hendricks
Nice catch, Patrick. I used this feature long ago [1], but as the Gerrit guidelines note we can now mark patches as WIP in the UI or just put [DONOTSUBMIT] in the summary line if a patch isn't ready for review. Furthermore, these days it's very easy to set up one's own git repo and access controls