[coreboot] Re: commit 0eab62b makes menuconfig more strict regarding the old configs

2023-11-29 Thread Mike Banon
Thank you, the patch at https://review.coreboot.org/c/coreboot/+/79298 really helps, I +1 it now On Wed, Nov 29, 2023 at 8:39 PM Mike Banon wrote: > > At the moment none of the suggestions work (tried make oldconfig, make > olddefconfig, make menuconfig KCONFIG_WERROR=0 >

[coreboot] Re: commit 0eab62b makes menuconfig more strict regarding the old configs

2023-11-29 Thread Mike Banon
At the moment none of the suggestions work (tried make oldconfig, make olddefconfig, make menuconfig KCONFIG_WERROR=0 KCONFIG_WARN_UNKNOWN_SYMBOLS=0 "). Any workaround alternative to git revert of this commit would be nice On Wed, Nov 29, 2023 at 1:41 PM Patrick Georgi via coreboot wrote: > > On

[coreboot] Re: commit 0eab62b makes menuconfig more strict regarding the old configs

2023-11-29 Thread Patrick Georgi via coreboot
On 29.11.23 00:20, Martin Roth via coreboot wrote: Hey Mike, I think you should be able to just append change the kconfig values when you run make to override the current settings. something like `make menuconfig KCONFIG_WERROR=0 KCONFIG_WARN_UNKNOWN_SYMBOLS=0` if we update where they're set

[coreboot] Re: commit 0eab62b makes menuconfig more strict regarding the old configs

2023-11-28 Thread Martin Roth via coreboot
Hey Mike, I think you should be able to just append change the kconfig values when you run make to override the current settings. something like `make menuconfig KCONFIG_WERROR=0 KCONFIG_WARN_UNKNOWN_SYMBOLS=0`  if we update where they're set in the makefile from := to ?=, you could even just

[coreboot] Re: commit 0eab62b makes menuconfig more strict regarding the old configs

2023-11-28 Thread Patrick Georgi via coreboot
On 28.11.23 19:04, Mike Banon wrote: Are there any advantages of KCONFIG_STRICT / KCONFIG_WERROR that outweigh these potential issues? It ensures that we don't silently build with unknown symbols (typo in manual editing, changes to the config, ...), and wonder why CONFIG_UART_DEBUG=y doesn't