Re: [coreboot] Unable to build futility on 32-bit userspace

2017-09-14 Thread Paul Kocialkowski 
Hi,

Le jeudi 31 août 2017 à 16:32 -0700, Julius Werner a écrit :
> FWIW, there should be no reason to build crossystem as part of
> coreboot's compile-time utilities at all. crossystem is a helper meant
> to run on the target device (the one that uses vboot-enabled
> firmware), it doesn't make any sense to have it on the build machine.
> We should fix the Makefiles so that they don't even pull this in, so
> that coreboot can also be built on architectures that crossystem
> doesn't support at all (e.g. SPARC or whatever). futility itself just
> does some crypto stuff and should have no architecture-specific
> components.

I totally agree with this, so I've submitted a patch to vboot in that
direction. It fixes the Makefile to make futility independent from the
crossystem parts:

https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/25

Happy code review!

-- 
Paul Kocialkowski,

developer of free digital technology and hardware support.

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

signature.asc
Description: This is a digitally signed message part
-- 
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] Unable to build futility on 32-bit userspace

2017-08-31 Thread Julius Werner 
FWIW, there should be no reason to build crossystem as part of
coreboot's compile-time utilities at all. crossystem is a helper meant
to run on the target device (the one that uses vboot-enabled
firmware), it doesn't make any sense to have it on the build machine.
We should fix the Makefiles so that they don't even pull this in, so
that coreboot can also be built on architectures that crossystem
doesn't support at all (e.g. SPARC or whatever). futility itself just
does some crypto stuff and should have no architecture-specific
components.

-- 
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] Unable to build futility on 32-bit userspace

2017-08-31 Thread Paul Menzel 
Dear Paul,


Am Donnerstag, den 31.08.2017, 09:36 +0300 schrieb Paul Kocialkowski:

> Le jeudi 31 août 2017 à 09:30 +0300, Paul Kocialkowski a écrit :
> > Le jeudi 31 août 2017 à 08:13 +0200, Paul Menzel a écrit :
> > > I haven’t tested this yet with a 64-bit userspace, but assume that
> > > works. Does somebody have a fix?
> > 
> > Yeah sure, I'll craft one and submit it to upstream vboot soon.
> 
> It's up at: https://chromium-review.googlesource.com/#/c/645086/
> 
> Googlers, feel free to review :)

Thank you for the quick reaction.


Tested-by: Paul Menzel 


Thanks,

Paul

signature.asc
Description: This is a digitally signed message part
-- 
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] Unable to build futility on 32-bit userspace

2017-08-31 Thread Paul Kocialkowski 
Hi again,

Le jeudi 31 août 2017 à 09:30 +0300, Paul Kocialkowski a écrit :
> Le jeudi 31 août 2017 à 08:13 +0200, Paul Menzel a écrit :
> > I haven’t tested this yet with a 64-bit userspace, but assume that
> > works. Does somebody have a fix?
> 
> Yeah sure, I'll craft one and submit it to upstream vboot soon.

It's up at: https://chromium-review.googlesource.com/#/c/645086/

Googlers, feel free to review :)

Cheers,

-- 
Paul Kocialkowski,

developer of free digital technology and hardware support.

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

signature.asc
Description: This is a digitally signed message part
-- 
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] Unable to build futility on 32-bit userspace

2017-08-31 Thread Paul Kocialkowski 
Hi,

Le jeudi 31 août 2017 à 08:13 +0200, Paul Menzel a écrit :
> Dear coreboot folks,
> 
> 
> Trying to run `make test-abuild` on my system with a 32-bit userspace,
> it looks like quite some boards require the program futility from
> `util/futility`, but that fails to build with the error below.
> 
> ```
> /dev/shm/coreboot/util/futility(master) $ git describe
> 4.6-1292-g5bf3457bc4
> /dev/shm/coreboot/util/futility(master) $ LANG= make
> MAKE   futility/build/futility/futility
> unset CFLAGS LDFLAGS; make -C /dev/shm/coreboot/3rdparty/vboot \
>   BUILD=/dev/shm/coreboot/util/futility/build \
>   CC="cc" \
>   V= \
>   /dev/shm/coreboot/util/futility/build/futility/futility
> make[1]: Entering directory '/dev/shm/coreboot/3rdparty/vboot'
> CCfutility/futility.o
> CCfutility/cmd_dump_fmap.o
> CCfutility/cmd_gbb_utility.o
> CCfutility/misc.o
> CCfutility/ryu_root_header.o
> CCfutility/cmd_bdb.o
> CCfutility/cmd_create.o
> CCfutility/cmd_dump_kernel_config.o
> CCfutility/cmd_load_fmap.o
> CCfutility/cmd_pcr.o
> CCfutility/cmd_show.o
> CCfutility/cmd_sign.o
> CCfutility/cmd_validate_rec_mrc.o
> CCfutility/cmd_vbutil_firmware.o
> CCfutility/cmd_vbutil_kernel.o
> CCfutility/cmd_vbutil_key.o
> CCfutility/cmd_vbutil_keyblock.o
> CCfutility/file_type.o
> CCfutility/file_type_bios.o
> CCfutility/file_type_rwsig.o
> CCfutility/file_type_usbpd1.o
> CCfutility/vb1_helper.o
> CCfutility/vb2_helper.o
> CCfutility/bdb_helper.o
> GEN   gen/futility_cmds.c
> CCgen/futility_cmds.o
> CCcgpt/cgpt_create.o
> CCcgpt/cgpt_add.o
> CCcgpt/cgpt_boot.o
> CCcgpt/cgpt_show.o
> CCcgpt/cgpt_repair.o
> CCcgpt/cgpt_prioritize.o
> CCcgpt/cgpt_common.o
> CCfutility/dump_kernel_config_lib.o
> make[1]: *** No rule to make target
> '/dev/shm/coreboot/util/futility/build/host/arch/i686/lib/crossystem_a
> rch.o', needed by
> '/dev/shm/coreboot/util/futility/build/libvboot_util.a'.  Stop.
> make[1]: Leaving directory '/dev/shm/coreboot/3rdparty/vboot'
> Makefile.inc:4: recipe for target
> '/dev/shm/coreboot/util/futility/build/futility/futility' failed
> make: *** [/dev/shm/coreboot/util/futility/build/futility/futility]
> Error 2
> ```
> 
> I haven’t tested this yet with a 64-bit userspace, but assume that
> works. Does somebody have a fix?

Yeah sure, I'll craft one and submit it to upstream vboot soon.

-- 
Paul Kocialkowski,

developer of free digital technology and hardware support.

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

signature.asc
Description: This is a digitally signed message part
-- 
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot