Re: [coreutils] [PATCH] Cater for extra strace output when building 32-on-64.

2010-12-03 Thread Dmitry V. Levin
On Wed, Dec 01, 2010 at 09:49:14AM +, Pádraig Brady wrote: On 30/11/10 18:09, Dmitry V. Levin wrote: On Mon, Nov 01, 2010 at 02:53:29PM +, Pádraig Brady wrote: [...] --- syscall.c.orig 2010-11-01 14:46:41.292576453 + +++ syscall.c 2010-11-01 14:47:10.164576378 +

Re: [coreutils] [PATCH] Cater for extra strace output when building 32-on-64.

2010-12-01 Thread Pádraig Brady
On 30/11/10 18:09, Dmitry V. Levin wrote: On Mon, Nov 01, 2010 at 02:53:29PM +, Pádraig Brady wrote: [...] --- syscall.c.orig 2010-11-01 14:46:41.292576453 + +++ syscall.c 2010-11-01 14:47:10.164576378 + @@ -953,7 +953,7 @@ call = ptrace(PTRACE_PEEKTEXT,

Re: [coreutils] [PATCH] Cater for extra strace output when building 32-on-64.

2010-11-01 Thread Pádraig Brady
On 30/10/10 14:20, Nix wrote: When building 32-bit coreutils on a 64-bit Linux platform, the stat-free-symlinks test fails because the strace output it diffs against contains an extra informative line emitted by strace of the general form [ Process PID=28429 runs in 32 bit mode. ] So

Re: [coreutils] [PATCH] Cater for extra strace output when building 32-on-64.

2010-11-01 Thread Pádraig Brady
On 01/11/10 23:05, Nix wrote: On 1 Nov 2010, Pádraig Brady told this: That looks like a buglet in strace, patch below. There doesn't look to be any more cases of incorrectly outputting to stdout: Ah, yeah, oops, it probably was meant to go to stderr, wasn't it. I didn't think of that.

Re: [coreutils] [PATCH] Cater for extra strace output when building 32-on-64.

2010-11-01 Thread Nix
On 1 Nov 2010, Pádraig Brady stated: On 01/11/10 23:05, Nix wrote: That's much better (though I'd use the fuller regex I provided simply because 'Process PID' seems a bit short and possible to occur in legitimate output to me). For general ls output yes. For the test which just does ls on

[coreutils] [PATCH] Cater for extra strace output when building 32-on-64.

2010-10-30 Thread Nix
When building 32-bit coreutils on a 64-bit Linux platform, the stat-free-symlinks test fails because the strace output it diffs against contains an extra informative line emitted by strace of the general form [ Process PID=28429 runs in 32 bit mode. ] So dike that line out, if it exists, before

Re: [coreutils] [PATCH] Cater for extra strace output when building 32-on-64.

2010-10-30 Thread Nix
On 30 Oct 2010, Sami Kerola spake thusly: On Sat, Oct 30, 2010 at 15:20, Nix n...@esperi.org.uk wrote: +grep -v 'Process PID=[1-9][0-9]* runs in 32 bit mode.' out out-destrace Even thou it's rare PID can be single digit number. Also I don't see Hence the *. The PID cannot be zero, so this

Re: [coreutils] [PATCH] Cater for extra strace output when building 32-on-64.

2010-10-30 Thread Sami Kerola
On Sat, Oct 30, 2010 at 15:20, Nix n...@esperi.org.uk wrote: +grep -v 'Process PID=[1-9][0-9]* runs in 32 bit mode.' out out-destrace Even thou it's rare PID can be single digit number. Also I don't see grep -v in use for other tests. I think following is better. sed '/Process PID=[0-9]* runs