Re: [coreutils] [PATCH] uniq: don't continue field processing after end of line

2011-01-18 Thread Jim Meyering
Jim Meyering wrote: Pádraig Brady wrote: On 16/01/11 23:53, Sami Kerola wrote: Hi, I notice uniq -f 'insane_large_number' will make process to be busy long time without good reason. Attached patch should fix this symptom. I'd slightly amend that to the following, to match the other limit

Re: [coreutils] [PATCH] uniq: don't continue field processing after end of line

2011-01-17 Thread Pádraig Brady
On 16/01/11 23:53, Sami Kerola wrote: Hi, I notice uniq -f 'insane_large_number' will make process to be busy long time without good reason. Attached patch should fix this symptom. I'd slightly amend that to the following, to match the other limit checks in the function. diff --git

Re: [coreutils] [PATCH] uniq: don't continue field processing after end of line

2011-01-17 Thread Jim Meyering
Pádraig Brady wrote: On 16/01/11 23:53, Sami Kerola wrote: Hi, I notice uniq -f 'insane_large_number' will make process to be busy long time without good reason. Attached patch should fix this symptom. I'd slightly amend that to the following, to match the other limit checks in the

[coreutils] [PATCH] uniq: don't continue field processing after end of line

2011-01-16 Thread Sami Kerola
Hi, I notice uniq -f 'insane_large_number' will make process to be busy long time without good reason. Attached patch should fix this symptom. I found the bug after friend of mine asked why uniq does not allow specifying field separator, similar way sort -t. I could not answer anything rational,