Re: [coreutils] [PATCHv2] stat: print SELinux context when available

2010-10-05 Thread Pádraig Brady
The attached fixes a logic inversion issue, and doesn't print context in file system mode which is confusing to me at least. There is also the argument not to print context in terse mode at all, as we'll have issues with outputting other extended attributes like capabilities and ACLs etc?

Re: [coreutils] [PATCHv2] stat: print SELinux context when available

2010-10-05 Thread Pádraig Brady
On 05/10/10 10:03, Jim Meyering wrote: - if (0 is_selinux_enabled ()) + if (is_selinux_enabled ()) ... - if (0 is_selinux_enabled ()) + if (is_selinux_enabled ()) However, the changes to the use of is_selinux_enabled look wrong, since that function

Re: [coreutils] [PATCHv2] stat: print SELinux context when available

2010-10-05 Thread Eric Blake
On 10/05/2010 03:03 AM, Jim Meyering wrote: * src/stat.c (default_format): Don't print SELinux context when in file system (-f) mode, as the context is associated with the file, not the file system. Fix logic inversion, so that in terse mode, %C is included only when is_selinux_enabled and not

Re: [coreutils] [PATCHv2] stat: print SELinux context when available

2010-10-05 Thread Jim Meyering
Eric Blake wrote: On 10/05/2010 03:03 AM, Jim Meyering wrote: * src/stat.c (default_format): Don't print SELinux context when in file system (-f) mode, as the context is associated with the file, not the file system. Fix logic inversion, so that in terse mode, %C is included only when

Re: [coreutils] [PATCHv2] stat: print SELinux context when available

2010-10-04 Thread Jim Meyering
Pádraig Brady wrote: On 01/10/10 21:41, Jim Meyering wrote: Eric Blake wrote: * src/stat.c (default_format): Include context when present. This is a close call, but I think it is justified. stat's default format should show as much information as possible, and no one should be parsing it.

Re: [coreutils] [PATCHv2] stat: print SELinux context when available

2010-10-01 Thread Jim Meyering
Eric Blake wrote: * src/stat.c (default_format): Include context when present. * NEWS: Update blurb explaining the replacement for -Z. --- Definitely nicer than the first attempt, but still controversial on whether we want to do this at all. I'm 70:30 for (I use Fedora's stat -Z regularly,