Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-02-06 Thread Glenn Golden
Pádraig Brady [2023-02-05 19:13:15 +]: > > On 05/02/2023 16:56, Glenn Golden wrote: > > Your two patches (the one mentioned above and the earlier one avoiding the > > xlseek() on a non-regular file) do almost fix the problem, but not quite. > > I added one additional mod, and with that, it

Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-02-05 Thread Pádraig Brady
On 05/02/2023 16:56, Glenn Golden wrote: Glenn Golden [2023-02-02 15:55:51 -0700]: Pádraig Brady [2023-02-01 20:37:47 +]: That was informative thanks. What I think is happening is that to support --follow=name tail(1) operates in non blocking mode so that it doesn't block when reading

Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-02-05 Thread Glenn Golden
Glenn Golden [2023-02-02 15:55:51 -0700]: > Pádraig Brady [2023-02-01 20:37:47 +]: > > > > That was informative thanks. > > > > What I think is happening is that to support --follow=name tail(1) operates > > in non blocking mode so that it doesn't block when reading a file, and has > > the

Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-02-02 Thread Glenn Golden
Pádraig Brady [2023-02-01 20:37:47 +]: > > That was informative thanks. > > What I think is happening is that to support --follow=name tail(1) operates > in non blocking mode so that it doesn't block when reading a file, and has > the opportunity to recheck. > > Now it determines when a

Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-02-01 Thread Pádraig Brady
On 01/02/2023 20:37, Pádraig Brady wrote: diff --git a/src/tail.c b/src/tail.c index 2244509dd..309d93072 100644 --- a/src/tail.c +++ b/src/tail.c @@ -1243,7 +1243,8 @@ tail_forever (struct File_spec *f, size_t n_files, double sleep_interval) recheck ([i],

Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-02-01 Thread Pádraig Brady
On 01/02/2023 14:46, Glenn Golden wrote: Pádraig Brady [2023-01-31 21:47:43 +]: On 31/01/2023 19:48, Glenn Golden wrote: Thanks, Pádraig. With the above patch (applied manually to coreutils 9.1 sources) the 'illegal seek' no longer occurs, but it also doesn't follow the new file: There

Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-02-01 Thread Glenn Golden
Pádraig Brady [2023-01-31 21:47:43 +]: > On 31/01/2023 19:48, Glenn Golden wrote: > > Thanks, Pádraig. > > > > With the above patch (applied manually to coreutils 9.1 sources) the > > 'illegal seek' no longer occurs, but it also doesn't follow the new file: > > There is no output at all

Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-01-31 Thread Pádraig Brady
On 31/01/2023 19:48, Glenn Golden wrote: Thanks, Pádraig. With the above patch (applied manually to coreutils 9.1 sources) the 'illegal seek' no longer occurs, but it also doesn't follow the new file: There is no output at all after tail announces that it is "following new file." I did verify

Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-01-31 Thread Glenn Golden
Pádraig Brady [2023-01-30 21:27:50 +]: > On 30/01/2023 20:04, Glenn Golden wrote: > > Not sure if this is a bug report, a feature request, or just a case of wrong > > expectation on my part regarding the behavior of "tail --follow=name" when > > the target is a special file (via a symlink).

Re: Unexpected behavior of 'tail --follow=name' on special file via symlink

2023-01-30 Thread Pádraig Brady
On 30/01/2023 20:04, Glenn Golden wrote: Not sure if this is a bug report, a feature request, or just a case of wrong expectation on my part regarding the behavior of "tail --follow=name" when the target is a special file (via a symlink). Perhaps what I'm trying to do is unreasonable and