Re: Files full of zeros with coreutils-8.11 and xfs (FIEMAP related?)

2011-04-17 Thread Dave Chinner
On Sat, Apr 16, 2011 at 02:05:51PM +0800, Yongqiang Yang wrote: On Sat, Apr 16, 2011 at 8:50 AM, Dave Chinner da...@fromorbit.com wrote: On Thu, Apr 14, 2011 at 11:01:04PM -0600, Andreas Dilger wrote: On 2011-04-14, at 6:09 PM, Dave Chinner da...@fromorbit.com wrote: No, this was

Re: Files full of zeros with coreutils-8.11 and xfs (FIEMAP related?)

2011-04-17 Thread Dave Chinner
On Sat, Apr 16, 2011 at 08:21:28AM -0400, Theodore Tso wrote: On Apr 16, 2011, at 1:11 AM, Andreas Dilger wrote: In that case, it means cp should just always use FIEMAP_FLAG_SYNC, which is fine. Except that if someone is copying a large delay allocated file, it will cause the file

Re: Files full of zeros with coreutils-8.11 and xfs (FIEMAP related?)

2011-04-17 Thread Andreas Dilger
On 2011-04-17, at 6:40 PM, Dave Chinner da...@fromorbit.com wrote: On Sat, Apr 16, 2011 at 08:21:28AM -0400, Theodore Tso wrote: On Apr 16, 2011, at 1:11 AM, Andreas Dilger wrote: In that case, it means cp should just always use FIEMAP_FLAG_SYNC, which is fine. Except that if someone is

bug#8513: stat list file name

2011-04-17 Thread Bob Proulx
- - wrote: here a small bug in stat: stat -c %n * stat : option invalide -- 's' Saisissez « stat --help » pour plus d'informations. ls -sdjfè`@$.txt stat is not able to list a direstory if a file start with a - Thank you for your bug report but this is not a bug in stat but a

bug#8513: stat list file name

2011-04-17 Thread Jim Meyering
tags 8513 notabug close 8513 thanks Bob Proulx wrote: Thank you for your bug report but this is not a bug in stat but a misunderstanding of how file globs operate with your command shell. And thank you for replying, Bob.

bug#8511: Sort error in makefile

2011-04-17 Thread Jim Meyering
tags 8511 notabug close 8511 thanks Alan Curry wrote: ... Your makefile is running the DOS/Windows sort command instead of the GNU/cygwin sort. Use a full path like /whatever/cygwin/bin/sort to make it use the right one. cygwin's bug, if a bug at all... Hi Alan, Thanks for replying. I'm

bug#8295: coreutils 8.10 portability fixes

2011-04-17 Thread Jim Meyering
tags 8295 moreinfo tags 8295 notabug thanks Andreas Stolcke wrote: In message 4d855f74.3070...@cs.ucla.eduyou wrote: On 03/19/2011 12:04 PM, Andreas Stolcke wrote: - Several places where iterator variables are declared inside for(), failing compiles on systems that support c99. I

bug#8320: df -BT: rounding error?

2011-04-17 Thread Jim Meyering
tags 8320 notabug close 8320 thanks Voelker, Bernhard wrote: Paul Eggert wrote: On 03/22/2011 08:47 AM, Voelker, Bernhard wrote: BTW: why are `Z' and `Y' too large? They don't fit in 64 bits. wow, I wasn't aware that there are already 128-bit systems! Hi Voelker, It looks like this is

bug#8294: Minor nit with dd

2011-04-17 Thread Jim Meyering
tags 8294 moreinfo close 8294 thanks Paul Eggert wrote: On 03/19/2011 11:26 AM, John Morris wrote: On a 64bit platform shouldn't the following command have done the expected thing instead of quietly clipping to 231? It depends on what your platform's 64-bit 'read' system call does. My

bug#8423: Questions about checking out 6.7 using git

2011-04-17 Thread Alan Curry
Jim Meyering writes: tags 8423 notabug close 8423 thanks That's disappointing. I was looking forward to seeing a response to this question. I also recently tried to find the origin of a bug with git bisect and quickly ended up with an uncompilable mess. If you want to see a complete

bug#6281: Fwd: Possible bug in coreutils-8.5 or associated gnulib version

2011-04-17 Thread Jim Meyering
Closing. This was resolved. see http://debbugs.gnu.org/6281

bug#8423: Questions about checking out 6.7 using git

2011-04-17 Thread Jim Meyering
Alan Curry wrote: Jim Meyering writes: tags 8423 notabug close 8423 thanks That's disappointing. I was looking forward to seeing a response to this question. I also recently tried to find the origin of a bug with git bisect and quickly ended up with an uncompilable mess. If you want to

bug#7257: [PATCH] Correct typos in date

2011-04-17 Thread Jim Meyering
tags 7257 moreinfo thanks Tobias Quathamer wrote: I think I've found three typos in the date program. I've attached a patch correcting those. There was some discussion at http://debbugs.gnu.org/7257 and one change was pushed. I'm marking this moreinfo in case someone wants to pursue the

bug#7201: unportable integer expression in src/install.c

2011-04-17 Thread Jim Meyering
Jim Meyering wrote: Paul Eggert wrote: Solaris 10 cc issues this warning: install.c, line 189: warning: initializer does not fit or is out of range: -61952 and indeed the code in question relies on undefined behavior, as it shoehorns what may be a large negative number into a small int

bug#7200: [PATCH] mbsalign: avoid warning with Solaris 10 cc

2011-04-17 Thread Jim Meyering
Jim Meyering wrote: Paul Eggert wrote: For the Oct. 10 snapshot Solaris 10 cc issues this warning: mbsalign.c, line 135: warning: initializer does not fit or is out of range: -1 This is just a warning and doesn't break anything, but it's trivial to fix: This too looks safe enough. Feel

bug#6906: [PATCH] cp: copy entirely-sparse files oodles faster

2011-04-17 Thread Jim Meyering
Paul Eggert wrote: (By oodles faster I mean as much faster as you like. The benchmark below shows a 2800x speedup.) In response to an idea by Kit Westneat for GNU tar reported in http://lists.gnu.org/archive/html/bug-tar/2010-08/msg00038.html, Eric Blake wrote: Meanwhile, if you are indeed

bug#7370: [PATCH] csplit: diagnose file counter wraparound

2011-04-17 Thread Jim Meyering
Paul Eggert wrote: (Ordinarily I guess I'd just install something like this, but since we're near a release I held off. The bug is unlikely in practice.) * src/csplit.c (create_output_file): Detect overflow when the file counter wraps around, and exit with a diagnostic. Formerly the code

bug#6402: [PATCH] rm: remove no-op -d option

2011-04-17 Thread Jim Meyering
Eric Blake wrote: On 09/17/2010 03:13 AM, Jim Meyering wrote: Jim, what do you think of this alternative patch, which avoids the issue of a new translation string by instead letting getopt parsing reject -d like any other unknown option? I like it. Thank you. ... --- a/NEWS ... + rm

bug#6524: [PATCH] hash: extend module to deal with non-pointer keys

2011-04-17 Thread Jim Meyering
Jim Meyering wrote: Pádraig Brady wrote: On 02/07/10 20:17, Jim Meyering wrote: Thanks again for the report. However, while I was able to reproduce it (on Paul's system) and debug it, it appears to be due to a miscompilation of di-set.o when using a private copy of gcc-4.5.0. When I

bug#6586: [PATCH] du: tune, and fix some -L bugs with dangling or cyclic symlinks

2011-04-17 Thread Jim Meyering
Paul Eggert wrote: That probably deserves a NEWS entry Thanks, I pushed this: Thanks. Closing.

bug#6673: [PATCH] only build libstdbuf.so when stdbuf is enabled

2011-04-17 Thread Jim Meyering
Pádraig Brady wrote: On 20/07/10 01:51, Mike Frysinger wrote: Currently, only main programs (like stdbuf) can be disabled at configure time. Helper programs (like libstdbuf.so) do not have a configure option. Even if you disable stdbuf with the configure option, libstdbuf.so will still be

bug#7960: [PATCH] fmt: fix formatting multibyte text (bug #7372)

2011-04-17 Thread Jim Meyering
tags 7960 + moreinfo thanks Eric Blake wrote: [readding the list] On 02/02/2011 02:11 PM, Kostya Stopani wrote: On Wed, Feb 02, 2011 at 10:15:53AM -0700, Eric Blake wrote: Thanks for the patch. However, it's not trivial, so it would need copyright assignment. Oh boy... Anyway I don't

bug#6692: [PATCH] dircolors: Add .ear, .war, .sar , for Java jar-like archives

2011-04-17 Thread Jim Meyering
Ondrej Vasik wrote: Attached patch adds colorizing *.war, *.sar and *.ear (Java EE archives, similar on surface as *.jar) with the archive color. This was suggested/requested by Ville Skyttä in rhbz #616497 . Thank you. I've made minor adjustments (it's now THANKS.in) tweaked the long and

bug#6643: [PATCH] sort: fix a bug with sort -u and xmemcoll0, and tune keycompare

2011-04-17 Thread Jim Meyering
Paul Eggert wrote: On 07/15/10 17:46, Pádraig Brady wrote: I'll add a few basic tests I think to run under $mb_locale Thanks. Jim also reminded me that I should add at least one test for this bug, so I just pushed the one enclosed below. The test is locale-dependent and is not guaranteed

bug#6793: [PATCH] dircolors: add screen.rxvt terminator to TERM list

2011-04-17 Thread Jim Meyering
Eric Blake wrote: On 08/03/2010 08:15 PM, Mike Frysinger wrote: * src/dircolors.hin: Add screen.rxvt terminator. Thanks; pushed. And now closed.

bug#6986: [PATCH] test: add check to determine whether files are on the same device

2011-04-17 Thread Jim Meyering
tags 6986 wishlist notabug thanks Dieter Plaetinck wrote: ... I know some shells provide the 'test' features as a built-in, that's fine. But they should mimic the features test has. It makes the shell implementation dependent on test, not the other way around. If this feature is considered

bug#6906: [PATCH] cp: copy entirely-sparse files oodles faster

2011-04-17 Thread Paul Eggert
On 04/17/11 01:55, Jim Meyering wrote: Now that we have FIEMAP support, (by the looks of things we will soon have SEEK_HOLE support in cp and in the linux kernel) do you think adding support for this special case is worthwhile? I could go either way. If so, would you care to rebase it for

bug#8513: stat list file name

2011-04-17 Thread Jesse Gordon
On 04/16/2011 07:47 PM, - - wrote: here a small bug in stat: stat -c %n * stat : option invalide -- 's' Saisissez « stat --help » pour plus d'informations. ls -sdjfè`@$.txt stat is not able to list a direstory if a file start with a - That's not a bug with stat. It's due to the fact