Re: [musl] Re: date-debug test failure with musl

2019-05-13 Thread Assaf Gordon
Hello, On 2019-05-13 12:23 p.m., Rich Felker wrote: On Mon, May 13, 2019 at 05:02:48AM +0200, Niklas Hambüchen wrote: Dear coreutils maintainers, when compiling coreutils commit 6e97d36 against musl v1.1.22 on Ubuntu, I get a test failure and differing output than when using glibc. Thank yo

Re: date-debug test failure with musl

2019-05-13 Thread Rich Felker
On Mon, May 13, 2019 at 05:02:48AM +0200, Niklas Hambüchen wrote: > Dear coreutils maintainers, > > when compiling coreutils commit 6e97d36 against musl v1.1.22 on Ubuntu, I get > a test failure and differing output than when using glibc. > > Running `src/date --debug -d 'TZ="America/Edmonton" 2

Re: [PATCH v5 4/4] stat: support statx DONT_SYNC and FORCE_SYNC flags

2019-05-13 Thread Jeff Layton
On Mon, 2019-05-13 at 09:18 -0400, Jeff Layton wrote: > Add a new --cache= command-line option that sets the appropriate hint > flags in the statx call. These are primarily used with network > filesystems to indicate what level of cache coherency the application > can tolerate. The new option is on

Re: [PATCH v4 3/4] stat: only set STATX_* mask bits for things we want to print

2019-05-13 Thread Jeff Layton
On Fri, 2019-05-10 at 02:28 -0700, Pádraig Brady wrote: > On 01/05/19 06:57, Jeff Layton wrote: > > Scan the format string to build a STATX_* mask prior to calling statx. > > This allows us to avoid setting bits for attributes that we don't > > intend to display, which can mean a much lighter-weigh

[PATCH v5 2/4] stat: use statx instead of stat if it's available

2019-05-13 Thread Jeff Layton
If HAVE_STATX is available, then use statx instead of stat/lstat/fstat. This necessitates some copying due to the fact that we need a struct stat to pass to some of the gnulib printing routines. * src/stat.c: more comprehensive use of statx when available --- src/stat.c | 566

[PATCH v5 3/4] stat: only set STATX_* mask bits for things we want to print

2019-05-13 Thread Jeff Layton
Scan the format string to build a STATX_* mask prior to calling statx. This allows us to avoid setting bits for attributes that we don't intend to display, which can mean a much lighter-weight operation on some filesystems. * src/stat.c: only set STATX_* mask bits for things we want to print ---

[PATCH v5 1/4] stat: drop statbuf argument from out_epoch_sec()

2019-05-13 Thread Jeff Layton
This argument is unused, and the function itself is not used outside of src/stat.c. * src/stat.c: drop statbuf argument from out_epoch_sec() --- src/stat.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/stat.c b/src/stat.c index bb1ef1a3d9ec..a0f32b32b958 100644

[PATCH v5 4/4] stat: support statx DONT_SYNC and FORCE_SYNC flags

2019-05-13 Thread Jeff Layton
Add a new --cache= command-line option that sets the appropriate hint flags in the statx call. These are primarily used with network filesystems to indicate what level of cache coherency the application can tolerate. The new option is only implemented when built with HAVE_STATX. * NEWS: mention th

[PATCH v5 0/4] stat: better utilization of statx() on the backend

2019-05-13 Thread Jeff Layton
v5: style cleanups fix warnings from make syntax-check switch --cached= option to use XARGMATCH fix --cached=default to set force_sync/dont_sync flags to false v4: switched to single --cached= option instead of separate --force-sync and --dont-sync options v3: fix stat-hyphen and