Re: for the next gnulib update

2019-08-11 Thread Assaf Gordon 
On Sun, Aug 11, 2019 at 09:33:47PM -0600, Assaf Gordon wrote:
> Hello,
> 
> On Sun, Aug 11, 2019 at 10:42:49AM +0200, Bruno Haible wrote:
> > A couple of changes in gnulib on 2019-07-15 [1] need updates on the 
> > coreutils
> > side, the next you update the gnulib used by coreutils.
> 
> Thanks for the heads-up.
> 
> Patch attached - I'll apply it tomorrow if there are no further comments.
>

Updated patch (fixed typo in commit message).

 
>From fc120af40548e63a98644f9f075710259a00 Mon Sep 17 00:00:00 2001
From: Bruno Haible 
Date: Sun, 11 Aug 2019 21:29:00 -0600
Subject: [PATCH] build: adjust for recent gnulib pthread changes

Discussed in https://lists.gnu.org/r/coreutils/2019-08/msg00030.html .

* bootstrap.conf (gnulib_modules): Replace 'pthread' with
pthread-* modules.
* src/sort.c: Remove GNULIB_defined_pthread_functions conditional.
---
 bootstrap.conf | 5 -
 src/sort.c | 5 -
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 49261524a..018bc4eb3 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -196,7 +196,10 @@ gnulib_modules="
   priv-set
   progname
   propername
-  pthread
+  pthread-cond
+  pthread-mutex
+  pthread-thread
+  pthread_sigmask
   putenv
   quote
   quotearg
diff --git a/src/sort.c b/src/sort.c
index d812aa999..360a1f140 100644
--- a/src/sort.c
+++ b/src/sort.c
@@ -82,11 +82,6 @@ struct rlimit { size_t rlim_cur; };
 # endif
 #endif
 
-#if GNULIB_defined_pthread_functions
-# undef pthread_sigmask
-# define pthread_sigmask(how, set, oset) sigprocmask (how, set, oset)
-#endif
-
 #if !defined OPEN_MAX && defined NR_OPEN
 # define OPEN_MAX NR_OPEN
 #endif
-- 
2.20.1

Re: for the next gnulib update

2019-08-11 Thread Assaf Gordon 
Hello,

On Sun, Aug 11, 2019 at 10:42:49AM +0200, Bruno Haible wrote:
> A couple of changes in gnulib on 2019-07-15 [1] need updates on the coreutils
> side, the next you update the gnulib used by coreutils.

Thanks for the heads-up.

Patch attached - I'll apply it tomorrow if there are no further comments.

-assaf
>From fc120af40548e63a98644f9f075710259a00 Mon Sep 17 00:00:00 2001
From: Bruno Haible 
Date: Sun, 11 Aug 2019 21:29:00 -0600
Subject: [PATCH] build: adjust for recent gnulib pthread changes

Discussed in https://lists.gnu.org/r/coreutils/2019-08/msg00030.html .

* bootstrap.conf (gnulib_modules): Replace 'pthread' with pthread-X
moduels.
* src/sort.c: Remove GNULIB_defined_pthread_functions conditional.
---
 bootstrap.conf | 5 -
 src/sort.c | 5 -
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 49261524a..018bc4eb3 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -196,7 +196,10 @@ gnulib_modules="
   priv-set
   progname
   propername
-  pthread
+  pthread-cond
+  pthread-mutex
+  pthread-thread
+  pthread_sigmask
   putenv
   quote
   quotearg
diff --git a/src/sort.c b/src/sort.c
index d812aa999..360a1f140 100644
--- a/src/sort.c
+++ b/src/sort.c
@@ -82,11 +82,6 @@ struct rlimit { size_t rlim_cur; };
 # endif
 #endif
 
-#if GNULIB_defined_pthread_functions
-# undef pthread_sigmask
-# define pthread_sigmask(how, set, oset) sigprocmask (how, set, oset)
-#endif
-
 #if !defined OPEN_MAX && defined NR_OPEN
 # define OPEN_MAX NR_OPEN
 #endif
-- 
2.20.1

Re: parse-datetime.y - Military Timezones are inverted from the correct sense

2019-08-11 Thread Assaf Gordon 

On 2019-08-10 9:17 p.m., Assaf Gordon wrote:

On Sat, Aug 10, 2019 at 01:05:23PM -0700, Paul Eggert wrote:

The attached patch-set includes this fix,
and the updated NEWS wording.
(I'll wait until gnulib is updated with the additional fix,
then create a new coreutil patch with the latest gnulib.)


Thanks here too; it all sounds good.


Attached latest version (with updated gnulib, and Bernhard's
syntax-check fix).

I'll push tomorrow unless other issues pop up.

-assaf



Pushed here:
https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=725c8d6bed902a181da867a5d38efd01f62d8c9a

for the next gnulib update

2019-08-11 Thread Bruno Haible 
Hi,

A couple of changes in gnulib on 2019-07-15 [1] need updates on the coreutils
side, the next you update the gnulib used by coreutils.


1) The 'pthread' module is now a convenience module that includes
functionality that coreutils does not need (such as thread-specific storage).
Suggested patch:

diff --git a/bootstrap.conf b/bootstrap.conf
index 4926152..018bc4e 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -196,7 +196,10 @@ gnulib_modules="
   priv-set
   progname
   propername
-  pthread
+  pthread-cond
+  pthread-mutex
+  pthread-thread
+  pthread_sigmask
   putenv
   quote
   quotearg


2) gnulib no longer defines GNULIB_defined_pthread_functions. This macro was
not documented and has been removed. Suggested patch:

diff --git a/src/sort.c b/src/sort.c
index d812aa9..360a1f1 100644
--- a/src/sort.c
+++ b/src/sort.c
@@ -82,11 +82,6 @@ struct rlimit { size_t rlim_cur; };
 # endif
 #endif
 
-#if GNULIB_defined_pthread_functions
-# undef pthread_sigmask
-# define pthread_sigmask(how, set, oset) sigprocmask (how, set, oset)
-#endif
-
 #if !defined OPEN_MAX && defined NR_OPEN
 # define OPEN_MAX NR_OPEN
 #endif


Rationale: pthread_sigmask is already handled by gnulib's 
override.


[1] https://lists.gnu.org/archive/html/bug-gnulib/2019-07/msg00052.html