bug#39357: tests/cp/proc-short-read.sh fails in modern build environment

2020-02-03 Thread Pádraig Brady
On 30/01/2020 13:53, Kamil Dudka wrote: tests/cp/proc-short-read.sh expects that a pair of subsequent reads from /proc/kallsyms will always return the same content. This does not seem to be a safe assumption any more. The test has started to fail in our build environment. I am not sure how to

Re: [PATCH v4 0/2] ls: use statx() when it's available

2020-02-03 Thread Pádraig Brady
On 31/10/2019 11:04, Jeff Layton wrote: On Thu, 2019-10-24 at 10:16 +0100, Pádraig Brady wrote: On 09/10/2019 22:23, Pádraig Brady wrote: On 09/10/2019 11:14, Jeff Layton wrote: On Wed, 2019-10-09 at 10:19 +0100, Pádraig Brady wrote: On 19/09/19 16:59, Jeff Layton wrote: v4: - set

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-03 Thread Pádraig Brady
On 03/02/2020 13:26, Pádraig Brady wrote: On 31/01/2020 17:51, Pádraig Brady wrote: Actually I think the key issue is not errno handling, but a logic error fixed with: @@ -102,7 +102,7 @@ ignorable_failure (int error_number, char const *dir) return (ignore_fail_on_non_empty &&

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-03 Thread Jim Meyering
On Mon, Feb 3, 2020 at 5:28 AM Pádraig Brady wrote: ... > Actually I think the key issue is not errno handling, > but a logic error fixed with: > > @@ -102,7 +102,7 @@ ignorable_failure (int error_number, char const *dir) > return (ignore_fail_on_non_empty > &&

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-03 Thread Pádraig Brady
On 31/01/2020 17:51, Pádraig Brady wrote: On 31/01/2020 01:46, Matthew Pfeiffer wrote: 'rmdir --ignore-fail-on-non-empty' would not report errors on non-empty directories that fail for a different reason. --- src/rmdir.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)