Re: maint: assume C89 escape sequences

2024-09-04 Thread Pádraig Brady
On 04/09/2024 03:54, Collin Funk wrote: Hi, Gnulib and Coreutils assume C89 escape sequences everywhere else, so I think these #if __STDC__ conditionals can be removed. Applied. thanks, Pádraig

Re: CP enhancement

2024-08-27 Thread Pádraig Brady
On 27/08/2024 08:39, Thomas Kimpton wrote: "cp -n srcFile destFile" returns 0 if it copies the file. It also returns 0 if it fails to copy the file over an existing file. I would like "cp -n" to return 1 (or perhaps EEXIST) when it will refuse to overwrite an existing file. This would facilitate:

Re: Pair-wise file operation (copy, link)

2024-08-25 Thread Pádraig Brady
esearched Stack-Overflow before posting, and could not find any good Linux solution (other than custom scripts). I believe effort is relatively small. Yair On Sun, Aug 25, 2024 at 8:22 AM Pádraig Brady mailto:p...@draigbrady.com>> wrote: On 25/08/2024 12:39, Yair Lenga wr

Re: Pair-wise file operation (copy, link)

2024-08-25 Thread Pádraig Brady
On 25/08/2024 12:39, Yair Lenga wrote: Greetings!, The 'cp' and 'ln' command provides the ability to perform 'bulk' operation, by specifying multiple source files and a target destination. In addition to convenience, this approach provides significant performance benefits, compared with running

Re: maint: adjust to Gnulib acl changes

2024-08-25 Thread Pádraig Brady
On 24/08/2024 19:40, Collin Funk wrote: Hi, These patches get rid of the use of deprecated function declarations due to Bruno's changes today [1]. Collin [1] https://lists.gnu.org/archive/html/bug-gnulib/2024-08/msg00146.html I've a minor query re this naming, which I asked about on the gnul

Re: Enhancement Request - General Personalization of Date/Time specification

2024-08-23 Thread Pádraig Brady
On 22/08/2024 23:40, Eric Marceau wrote: Hello, Please refer to my postings, here (https://github.com/mate-desktop/caja/issues/1712#issuecomment-2305818307), *where I stated:* The issue here is that the *FORMAT* for time and date should be set set from the UbuntuMATE Preferences wind

Re: Feature Request: numfmt input type defaults to 'auto' instead of 'none'

2024-08-22 Thread Pádraig Brady
On 22/08/2024 03:51, Oliver Webb wrote: Hello, first I'd like to say thanks for the GNU coreutils. When trying to parse numbers with `numfmt`, I noticed that the input type was 'none' by default. This makes converting to other formats harder since you have to specify `--from`. Changing it's defa

Re: Feature Requests for find and date

2024-08-19 Thread Pádraig Brady
On 18/08/2024 00:47, Marc Gutt wrote: Dear GNU Team, I like to see the following features / enhancements: find Add %z to help / man page. The numeric time zone sequence is not mentioned by now. Please send above to bug-findut...@gnu.org date Add additional basic ISO 8601 date formats to -d

Re: ls: add option --sort=name

2024-08-11 Thread Pádraig Brady
On 06/08/2024 00:00, Tzvetelin Katchov wrote: It has not way to restore default ls sorting by name, if it was changed. Attached patch adds "name" for long option --sort. ls: add option --sort=name add "name" to sort_args and sort_name to sort_types I've pushed the attached to implement this.

Re: ls: add option --sort=name

2024-08-08 Thread Pádraig Brady
On 06/08/2024 00:00, Tzvetelin Katchov wrote: It has not way to restore default ls sorting by name, if it was changed. Attached patch adds "name" for long option --sort. ls: add option --sort=name add "name" to sort_args and sort_name to sort_types This is similar to the recent --time=modific

[PATCH] tests: limits mem usage on potentially expensive test

2024-08-03 Thread Pádraig Brady
* tests/misc/write-errors.sh: Limit mem usage if possible, as some implementations may use unbounded memory for the tests cases used here. --- tests/misc/write-errors.sh | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/tests/misc/write-errors.sh b/tests/misc/wr

[PATCH] tests: ensure utils support writing to a closed pipe

2024-08-03 Thread Pádraig Brady
* tests/misc/write-errors.sh: A closed pipe is a common scenario, and should not induce an error. The general case is discussed at: https://www.pixelbeat.org/programming/sigpipe_handling.html --- tests/misc/write-errors.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/misc/write-

[PATCH] doc: reference 'dircolors invocation' from ls --color info

2024-08-03 Thread Pádraig Brady
* doc/coreutils.texi: Reference how to configure colors, from the ls --color description. --- doc/coreutils.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/coreutils.texi b/doc/coreutils.texi index a23977910..00e401cbd 100644 --- a/doc/coreutils.texi +++ b/doc/coreutils.texi @@ -8322,

[PATCH] doc: clarify which ls color attributes don't apply to dirs

2024-08-03 Thread Pádraig Brady
* src/dircolors.hin: Clarify that SETUID, SETGID, CAPABILITY, and EXEC coloring, only apply to regular files. --- src/dircolors.hin | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/dircolors.hin b/src/dircolors.hin index 58297e8bb..833609fb2 100644 --- a/src/dircolor

Re: maint: remove unnecessary inttostr usage in printf

2024-07-30 Thread Pádraig Brady
On 30/07/2024 05:39, Collin Funk wrote: Here is a patch simplifying some printf invocations like: printf ("%s", intmaxtostr (value, buf)); to just use C99 conversion specifiers: printf ("%jd", value); I've left ones that modify the return value (e.g. with quote) and ones that use it

Re: [PATCH] tests: add fold(1) test for non-existent files [was: coreutils-9.4: problems with I18N patches]

2024-07-10 Thread Pádraig Brady
On 10/07/2024 08:14, Bernhard Voelker wrote: Hi *, downstream fold(1) - with the I18N patches - exited 0 for 'fold enoent' for 20 years (upstream unaffected). Adding a test here. Looks good. thanks, Pádraig

Re: ls command is broken

2024-07-09 Thread Pádraig Brady
On 09/07/2024 21:35, Charlton Harrison wrote: Your ls command is broken. By default it is putting quotes around filenames with spaces. The fact that I have to research a work-around for this bug since it hasn't been fixed yet gives me a depressed feeling over the state of software development th

Re: Missing file "config.h"

2024-07-05 Thread Pádraig Brady
On 05/07/2024 09:51, Björn Försterling via GNU coreutils General Discussion wrote: Hello, I cloned the repository https://github.com/coreutils/coreutils.git and tried to compile some of the programs it contains. But the files include a file called "config.h". $ gcc -Wall hostname.c hostname.c

Re: Bug#1075768: coreutils: ls doesn't honour COLUMNS if writing to a teletype

2024-07-04 Thread Pádraig Brady
On 04/07/2024 17:29, наб wrote: Package: coreutils Version: 9.1-1 Version: 9.4-3 Severity: normal Dear Maintainer, Quoth POSIX.1-2024: 103406 ENVIRONMENT VARIABLES 103407 The following environment variables shall affect the execution of ls: 103408 COLUMNS Override the system-selected horizo

Re: maint: import tests/init.sh from Gnulib during bootstrap

2024-07-04 Thread Pádraig Brady
On 04/07/2024 02:08, Collin Funk wrote: Hi, Recently there was a bug fix in Gnulib's tests/init.sh. I then noticed many packages copy this manually from Gnulib. Bruno and I discussed the proper way to import the file from Gnulib [1]. What do you think of the attached patch? Basically remove the

[PATCH] doc: remove 'proposed' in regard to $'' descriptions

2024-07-02 Thread Pádraig Brady
$'' is POSIX standard syntax as of POSIX.1-2024, as per: https://www.austingroupbugs.net/view.php?id=249 * doc/coreutils.texi (quotingStyles): Remove 'proposed'. * src/printf.c: Likewwise. Reported at https://bugs.debian.org/1074776 --- doc/coreutils.texi | 4 ++-- src/printf.c | 4 ++-- 2

Re: cksum: improve tests with several files with errors

2024-07-02 Thread Pádraig Brady
On 01/07/2024 22:51, Sylvestre Ledru wrote: Hello As attachment, two tests of cksum covering when several files are passed. One tests when the files are missing The second when the file exists but empty. Currently, this isn't covered. Pushed. I also pushed a follow up to remove uses of `gr

Re: maint: Silence deprecated module warning

2024-07-01 Thread Pádraig Brady
On 01/07/2024 05:00, Collin Funk wrote: I changed the name of the putenv module to putenv-gnu a while ago. The warning is a bit hard to see in all the ./bootstrap output. This patch just silences: Notice from module putenv: This module is deprecated. Use the module 'putenv-gnu' inst

Re: chown, reference files, and symlinks

2024-06-30 Thread Pádraig Brady
On 30/06/2024 04:38, Alexander Necheff wrote: I discovered that when chown is executed as follows: `chown --no-dereference --reference=/some/file /another/file` chown will still dereference /some/file if it is a symlink and source ownership from the referenced file instead of the named symlink. T

Re: maint: Prefer endian.h for byte order conversions

2024-06-29 Thread Pádraig Brady
On 29/06/2024 12:53, Collin Funk wrote: Hi, Now that is a part of POSIX 2024 it should become more portable than . And it simplifies the code a bit. Patches attached. Side note, I feel like gnulib-tool should deal with adding the built versions of the *.in.h headers. That way it doesn't have t

[PATCH] doc: document the c-maybe quoting style

2024-06-26 Thread Pádraig Brady
* doc/coreutils.texi (ls invocation): Document the "c-maybe" --quoting-style, which was added as an option in 2008. Reported at https://bugs.debian.org/1074334 --- doc/coreutils.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/coreutils.texi b/doc/coreutils.texi index 1fa7f79ad..c56

Re: translator comment in src/stat.c lost

2024-06-25 Thread Pádraig Brady
On 25/06/2024 11:23, Bruno Haible wrote: Hi, src/stat.c contains a translator comment that has no effect because it's more than one line away from the beginning of the _() invocation. How to reproduce: Look in po/coreutils.pot, searching for 'Access: %x'. No translator comment is there. This w

Re: sort --head

2024-06-19 Thread Pádraig Brady
On 19/06/2024 19:48, Mark E. Shoulson wrote: Turns out whatever I'm doing doesn't work right when the input is a pipe (though input redirection from a file is okay), so in addition to being incomplete, this patch is actually buggy.  Will work on it, but still hoping to hear opinions. ~mark On 6

Re: Want to contribute a new gping

2024-06-14 Thread Pádraig Brady
On 14/06/2024 01:23, Alfredo Jacobo wrote: Hello, I'd like a certain ping feature but it doesn't exist. So, I'm looking into contributing it. I hear this is the place to seek consensus? I'd submit it to gnu and call it gping. My new feature; wanted ping to never give the statistics at the end

Re: [PATCH] maint: improve ERE in sc_tests_list_consistency

2024-06-01 Thread Pádraig Brady
On 01/06/2024 15:02, Bernhard Voelker wrote: The ERE used lacks the grouping of the extensions and therefore would also match files where the first two patterns are not at the end of the line: grep -E '\.sh|\.pl|\.xpl$' * cfg.mk (sc_tests_list_consistency): Add grouping (...) around the sub-p

[PATCH] stat,tail: sync with latest Linux file systems

2024-05-28 Thread Pádraig Brady
* src/stat.c (human_fstype): Rename "FUSEBLK" to "FUSE" to sync with kernel adjustments. Add "bcachefs", and "pidfs". Both are local, with the latter being similar to "proc" which is also local. * NEWS: Mention the change in behavior, and the improvement. --- NEWS | 7 +++ src/stat.c |

Re: [PATCH] scripts: rewrite dcgen in shellscript

2024-05-27 Thread Pádraig Brady
On 26/05/2024 22:09, Christopher Bayliss wrote: * this makes dcgen work when building corutils on a system without perl * I also added comments to help the next person who looks at this file * there is a minor difference in the output between the original dcgen and this version, lines that s

Re: Ordering bug(?) with cksum/hashsum

2024-05-27 Thread Pádraig Brady
On 26/05/2024 22:08, Sylvestre Ledru wrote: Hello, Playing with the one of the *sum command, i noticed a weird behavior. Depending on the order in the checksum file, we will get completely different results. For example, this code reproduces the issue: touch a touch "*c" echo "First tes

Re: cksum: add tests to verify the output in case of errors

2024-05-22 Thread Pádraig Brady
On 21/05/2024 23:54, Sylvestre Ledru wrote: Here are more tests in this patch :) This time with --status, --ignore-missing and --warn Adjusted to pass `make syntax-check` and pushed. thanks! Pádraig.

Re: cksum: add tests to verify the output in case of errors

2024-05-11 Thread Pádraig Brady
On 10/05/2024 22:15, Sylvestre Ledru wrote: Hello The attached patch improves the coverage with --check & --strict, especially in the context of errors/warnings. Pushed with these changes: - Started the summary line with "tests", as not changing cksum - Changed double quotes to single quotes

Re: [PATCH] wc: speed-up by simplifying avx code

2024-05-09 Thread Pádraig Brady
On 31/03/2024 21:23, Pádraig Brady wrote: On 31/03/2024 18:58, Evgeny Nizhibitsky wrote: Yes, it's true that simplifying and speeding-up by the bufsize increase are two different things although the former allowed the latter. I just landed more tests with hyperfine for various configura

Re: [PATCH] maint: factor out the common show_date functionality

2024-05-05 Thread Pádraig Brady
On 05/05/2024 10:06, Nikolay Nechaev via GNU coreutils General Discussion wrote: Note I adjusted your email to be more standard, rather than the above: + fputs (timetostr(pdui->tmax.tv_sec, buf), stdout); `make syntax-check` indicated the missing space in timetostr(), and also a miss

Re: [PATCH 1/2] maint: factor out common macros of stat and printf

2024-05-05 Thread Pádraig Brady
Pushed both of these. thanks, Pádraig

Re: cksum: add tests to verify the presence of "*" (and question about usability of cksum)

2024-05-04 Thread Pádraig Brady
On 03/05/2024 18:53, Sylvestre Ledru wrote: Hello, The attached patch checks for a code path that wasn't covered before (afaik). Pushed. As a side note, the various combinations of --tag / --untagged and --binary / --text is producing some unexpected results at time :) Maybe that ship sailed

Re: maint: pacify GCC 14 -Wmissing-variable-declarations

2024-05-01 Thread Pádraig Brady
On 28/04/2024 03:45, Collin Funk wrote: Hi, gnulib-tool.py feels pretty quick in Coreutils. :) I noticed some new warnings from Fedora 40's gcc 14. These patches are pretty much copied from Pauls gnulib commit here: https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=4ab87e2642d887b8

[PATCH] build: bootstrap with python gnulib-tool by default

2024-04-27 Thread Pádraig Brady
* gnulib: Update to support bootstrapping with python by default. * bootstrap: Sync with gnulib. * cfg.mk: Don't force python implementation with `make world`, rather rely on the auto selection of python if appropriate. --- bootstrap | 210 -- cf

[PATCH] build: provide way to bootstrap with python gnulib-tool

2024-04-23 Thread Pádraig Brady
* cfg.mk: Add a new "world" default target so that one can bootstrap (using the python implementation), configure, and make, by using `make -f cfg.mk`. * gnulib: Update to latest primarily to test the bootstrap python implementation which is now in beta test. * README-hacking: Document the `make -f

Re: Modify buffering of standard streams via environment variables (not LD_PRELOAD)?

2024-04-19 Thread Pádraig Brady
On 19/04/2024 12:36, Zachary Santer wrote: On Fri, Apr 19, 2024 at 5:32 AM Pádraig Brady wrote: env variables are what I proposed 18 years ago now: https://sourceware.org/bugzilla/show_bug.cgi?id=2457 And the "resistance to that" from the Red Hat people 24 years ago is listed on

Re: Modify buffering of standard streams via environment variables (not LD_PRELOAD)?

2024-04-19 Thread Pádraig Brady
On 19/04/2024 01:16, Zachary Santer wrote: Was "RFE: enable buffering on null-terminated data" On Wed, Mar 20, 2024 at 4:54 AM Carl Edquist wrote: However, if stdbuf's magic env vars are exported in your shell (either by doing a trick like 'export $(env -i stdbuf -oL env)', or else more simpl

Re: [PATCH] cksum: --quiet option to output only the checksum when reading tty stdin

2024-04-18 Thread Pádraig Brady
On 17/04/2024 18:51, Piotr H. Dabrowski wrote: * src/digest.c: --quiet option when reading tty stdin --- src/digest.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/digest.c b/src/digest.c index 1a4cfd1fb..6501f5e9d 100644 --- a/src/digest.c +++ b/src/d

Re: maint: Remove unnecessary stdbool.h include

2024-04-17 Thread Pádraig Brady
On 16/04/2024 21:53, Collin Funk wrote: I noticed 'src/temp-stream.c' includes . This should be unnecessary since Gnulib defines in in config.h right? Feel free to apply this patch unless I am missing something. The following returns no other files: $ find . -name '*.[ch]' | xargs grep -E '[[:

[PATCH] join: fix error message for -a and -v

2024-04-12 Thread Pádraig Brady
* src/join.c (main): s/field/file/ in the error message for -a and -v, introduced in TEXTUTILS-1_13-24-g6f63d53e1. Reported at https://bugs.debian.org/1068864 --- src/join.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/join.c b/src/join.c index fd6fc74ce..fd28febfb 10064

Re: ls flag to show number of hard links

2024-04-10 Thread Pádraig Brady
On 09/04/2024 16:58, Tony Freeman wrote: I seem to recall that some years ago ls -l would show the number of hard links to a file. This may have been on an AIX system. I needed to use this today on a red hat 8 machine but couldn't figure it out. So I used ls -i | sort Am I overlooking a flag t

Re: coreutils-9.5.7-11163 cut/cut test failure

2024-04-07 Thread Pádraig Brady
On 07/04/2024 14:41, Kevin Jerebica wrote: The cut/cut test fails on Arch Linux (kernel: 6.7.0-arch3-1). Any ideas why this might be? The only lines that stick out to me are these three at the top of the log: E 00:00:1712495787.461523  698728 wire_format_lite.cc:603] String field 'rpc.Execu

[PATCH] build: update gnulib submodule to latest

2024-04-04 Thread Pádraig Brady
* gnulib: Update to latest. * NEWS: Document 2 bugs fixed. --- NEWS | 10 ++ gnulib | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 0d380a8ae..0a5130331 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,16 @@ GNU coreutils NEWS

Re: [PATCH] wc: speed-up by simplifying avx code

2024-03-31 Thread Pádraig Brady
On 31/03/2024 18:58, Evgeny Nizhibitsky wrote: Yes, it's true that simplifying and speeding-up by the bufsize increase are two different things although the former allowed the latter. I just landed more tests with hyperfine for various configurations spanning over the current master version an

Re: [PATCH] wc: speed-up by simplifying avx code

2024-03-31 Thread Pádraig Brady
On 31/03/2024 13:12, Pádraig Brady wrote: On 31/03/2024 00:18, Evgeny Nizhibitsky wrote: Here is the proposed patch for both simplifying and consistently speeding up the avx version of wc -l by 10% in up to 1 billion rows scenarios on 7800X3D (probably should be tested on different data

Re: [PATCH] wc: speed-up by simplifying avx code

2024-03-31 Thread Pádraig Brady
On 31/03/2024 00:18, Evgeny Nizhibitsky wrote: Here is the proposed patch for both simplifying and consistently speeding up the avx version of wc -l by 10% in up to 1 billion rows scenarios on 7800X3D (probably should be tested on different data samples and CPUs). The patch was mangled, but I

Re: wc -l AVX code 10%+10% speedup

2024-03-30 Thread Pádraig Brady
On 30/03/2024 14:52, Evgeny Nizhibitsky wrote: Dear GNU coreutils maintainers, It seems that I found a way to both speed-up (~10%) and simplify (13 insertions, 43 deletions) the wc -l avx code while playing with it, at least on several million to 1 billion row files I tested with my cpu. It mos

Re: Feature Request: env -f to read from file

2024-03-29 Thread Pádraig Brady
On 29/03/2024 05:05, Kaz Kylheku wrote: On 2024-03-28 15:29, Balakrishnan Balasubramanian wrote: On 2024-03-28 3:38 p.m., Pádraig Brady wrote: Yes the feature has merit, and was previously discussed at: https://lists.gnu.org/archive/html/coreutils/2021-10/msg1.html There are some

Re: [PATCH 4/4] cut: Optionally treat multiple consecutive delimiters as one

2024-03-28 Thread Pádraig Brady
On 28/03/2024 19:43, Dragan Simic wrote: Hello, Just checking, are there any further thoughts on this topic? It's on the list, but didn't have the priority for this release. I intend to have a look at the new cut proposals for next release. cheers, Pádraig

Re: Date setting examples in manual

2024-03-28 Thread Pádraig Brady
On 24/03/2024 18:32, wrotycz wrote: I noticed there are no examples of how to set date using date, in the manual. Therefore I propose to add these to examples section to make it clear and easy to do so. I used simple formats, more like 'machine formats' to make it even simpler, as no one wants

Re: Feature Request: env -f to read from file

2024-03-28 Thread Pádraig Brady
On 28/03/2024 15:52, Balakrishnan Balasubramanian wrote: When env command is used to pass extra environment variables to a program, it will be useful to read them from a file instead of command line. Instead of     env MYAPP_QA_KEY=X MYAPP_QA_URL=https://qa.myapp.example.com clicommand W

coreutils-9.5 released [stable]

2024-03-28 Thread Pádraig Brady
) Petr Malat (1) Bruno Haible (3)Pádraig Brady (75) Christian Göttsche (1) Samuel Tardieu (1) Collin Funk (4) Stephane Chazelas (1) Daan De Meyer (1) Stephen Kitt (1) Greg Wooledge (1) Sylvestre Ledru (3) Grisha Levit

Re: new snapshot available: coreutils-9.4.185-541b02.tar.xz

2024-03-28 Thread Pádraig Brady
0 test failures on Fedora 39 amd64 (with ASAN enabled) 0 test failures on Centos 7.9 IBM POWER8 8247-22L 0 test failures on AlmaLinux 9.3 IBM POWER10 9043-MRX

Re: coreutils-9.4.185-541b02 od/od-multiple-t test failure

2024-03-27 Thread Pádraig Brady
On 27/03/2024 12:35, Bruno Haible wrote: Pádraig Brady wrote: The original bug report was not specific to floats, so I'll just remove them from the test. I think it is enough to remove the 'long double' part from the test (option letter 'L'). 'float' and &#

Re: coreutils-9.4.185-541b02 od/od-multiple-t test failure

2024-03-27 Thread Pádraig Brady
On 27/03/2024 12:03, Bruno Haible wrote: The tests/od/od-multiple-t.sh test fails on - Linux/ia64 (Gentoo, recent glibc, real hardware) - Linux/m68k (Debian 12, QEMU emulated) The first 'od' invocation that causes fail=1 to be set is: $ seq 19 > input $ ./od -An -taz -tfLz input 1 nl

Re: [platform-testers] new snapshot available: coreutils-9.4.184-606f5.tar.xz

2024-03-26 Thread Pádraig Brady
On 26/03/2024 21:19, Bruno Haible wrote: Pádraig Brady wrote: We plan to release coreutils-9.5 in the next few days I would suggest to update to the current gnulib, in order to get these two fixes: https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h

new snapshot available: coreutils-9.4.185-541b02.tar.xz

2024-03-26 Thread Pádraig Brady
We plan to release coreutils-9.5 in the next few days so any testing you can do on various different systems between now and then would be most welcome. This release comes about 30 weeks after the 9.4 release. Changes since the last pre-release (https://lists.gnu.org/archive/html/coreutils/2024-0

Re: new snapshot available: coreutils-9.4.184-606f5.tar.xz

2024-03-26 Thread Pádraig Brady
0 test failures on Fedora 39 amd64 (with ASAN enabled) 0 test failures on macOS 12.6 arm64 (m1) FAIL: tests/chown/preserve-root === Bruno already reported. Not a new issue. Due to "chgrp: invalid group: '4294967295'" 1 gnulib test failure on Centos 7.9.2009 ppc64 (cfa

new snapshot available: coreutils-9.4.184-606f5.tar.xz

2024-03-26 Thread Pádraig Brady
We plan to release coreutils-9.5 in the next few days so any testing you can do on various different systems between now and then would be most welcome. This release comes about 30 weeks after the 9.4 release. Changes since the last pre-release (https://lists.gnu.org/archive/html/coreutils/2024-0

Re: coreutils-9.4.170-7b206 misc/numfmt test failure

2024-03-26 Thread Pádraig Brady
On 26/03/2024 18:54, Bruno Haible wrote: Pádraig Brady wrote: The misc/numfmt test fails on - Alpine Linux 3.18, - macOS 12.5, - FreeBSD 14.0, - Solaris 11 OpenIndiana. Find attached the test-suite.log files. If these test failures are due to platform-specific *printf bugs

Re: uniq for unsorted input

2024-03-26 Thread Pádraig Brady
On 26/03/2024 16:40, Bruno Haible wrote: The documentation of 'uniq' [1] says: "The input need not be sorted, but repeated input lines are detected only if they are adjacent. If you want to discard non-adjacent duplicate lines, perhaps you want to use 'sort -u'." When I wrote gnulib-

Re: coreutils-9.4.170-7b206 ls/removed-directory test failure

2024-03-26 Thread Pádraig Brady
On 26/03/2024 18:25, Bruno Haible wrote: Pádraig Brady wrote: The ls/removed-directory test fails on FreeBSD 14.0. tests-suite.log from FreeBSD 14.0: FAIL: tests/ls/removed-directory diff -u /dev/null err --- /dev/null 1970-01-01 +++ err 1970-01-01 +ls

Re: coreutils-9.4.170-7b206 ls/removed-directory test failure

2024-03-26 Thread Pádraig Brady
On 26/03/2024 17:08, Paul Eggert wrote: On 3/26/24 10:50, Pádraig Brady wrote: It seems that readdir() on FreeBSD 14 is _not_ eating the ENOENT from getdirentries(). Attached is an extra check for that, that avoids the test in that case. An alternative would be for ls to ignore the ENOENT from

Re: coreutils-9.4.170-7b206 ls/removed-directory test failure

2024-03-26 Thread Pádraig Brady
On 24/03/2024 16:30, Bruno Haible wrote: The ls/removed-directory test fails on FreeBSD 14.0. tests-suite.log from FreeBSD 14.0: FAIL: tests/ls/removed-directory diff -u /dev/null err --- /dev/null 1970-01-01 +++ err 1970-01-01 +ls: reading directory '.': No

Re: Feature request: numfmt --from=K or k

2024-03-26 Thread Pádraig Brady
On 26/03/2024 13:13, Tim Baverstock wrote: Hi. I sometimes end up with a list of files whose sizes represent K instead of bytes. I recognise I can filter them to add the 'K' before passing them through numfmt, but if I could tell numfmt --from=K it would be more convenient. Thanks for your con

Re: coreutils-9.4.170-7b206 uniq/uniq test failure

2024-03-26 Thread Pádraig Brady
On 25/03/2024 22:28, Bruno Haible wrote: Pádraig Brady wrote: while uniq (c32isblank) now determines it is not blank (which seems more correct). I agree that U+00A0 NO-BREAK SPACE should better be considered to be non-blank (and Gnulib's c32isblank does so). The only solaris 11 sys

Re: coreutils-9.4.170-7b206 cp/preserve-mode test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 16:42, Bruno Haible wrote: The cp/preserve-mode test fails on Alpine Linux 3.18. test-suite.log from Alpine Linux 3.18: FAIL: tests/cp/preserve-mode + mkdir d1 d2 + chmod 705 d2 + cp '--no-preserve=mode' -r d2 d3 + get_mode d1 + stat '-c%f' d1 + g

Re: coreutils-9.4.170-7b206 uniq/uniq test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 16:15, Bruno Haible wrote: The uniq/uniq test fails on Solaris 11 OpenIndiana. test-suite.log on Solaris 11 OpenIndiana: FAIL: tests/uniq/uniq = schar... uniq: test schar: stdout mismatch, comparing schar.2 (expected) and schar.O (actual) *** schar.2 Sun

Re: coreutils-9.4.170-7b206 misc/numfmt test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 17:14, Bruno Haible wrote: The misc/numfmt test fails on - Alpine Linux 3.18, - macOS 12.5, - FreeBSD 14.0, - Solaris 11 OpenIndiana. Find attached the test-suite.log files. If these test failures are due to platform-specific *printf bugs, please provide a test case fo

Re: coreutils-9.4.170-7b206 ls/dired test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 16:37, Bruno Haible wrote: The ls/dired test fails on: - FreeBSD 14.0, - Solaris 11 OpenIndiana. https://github.com/coreutils/coreutils/commit/a51af4329 thanks, Pádraig

Re: coreutils-9.4.170-7b206 chmod/symlinks test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 16:55, Bruno Haible wrote: The chmod/symlinks test fails on: - Alpine Linux 3.18, That was not Alpine specific, rather due to setgid dirs: https://github.com/coreutils/coreutils/commit/f77a6352f - macOS 12.5, - FreeBSD 14.0, - NetBSD 9.3 and 10.0-rc4, - OpenBSD 7.

Re: Correction to pl po translation

2024-03-24 Thread Pádraig Brady
On 24/03/2024 18:43, wrotycz wrote: I noticed some minor mistakes or inconsistences in translation so I send correction. Regards Wrotycz Please direct this to the translation project https://translationproject.org/team/ lists this as: translation-team...@lists.sourceforge.net thanks, Pádra

Re: some string issues in coreutils-9.4.170-7b206

2024-03-24 Thread Pádraig Brady
On 24/03/2024 16:35, Wenbin Lv wrote: Hi, I just finished updating the zh_CN translation for 9.4.170-7b206. Below are some string related issues I have noticed: src/chown-core.h:101: "owner and/or "should be translatable; Fixed in https://bugs.gnu.org/69985 src/chown.c:84: "[OWNER][:[GROUP]

Re: Test failure when building in setgid directory

2024-03-24 Thread Pádraig Brady
On 24/03/2024 16:29, Sven Joachim wrote: When building coreutils 9.4.170-7b206 on x86_64 GNU/Linux, I got a test failure in tests/chmod/symlinks, apparently because I was building in a setgid directory. The log file of the failed test is attached. , | $ LANG=C ls -ld /usr/local/src/coreutil

Re: coreutils-9.4.170-7b206 mv/mv-exchange test failure

2024-03-24 Thread Pádraig Brady
On 24/03/2024 16:26, Bruno Haible wrote: The mv/mv-exchange test fails on: - NetBSD 9.3 - OpenBSD 7.4 - AIX 7.1 - AIX 7.3.1 The attached should fix the issue with this new test. thanks for all the testing! Pádraig From c45fcb2ed2d80df5e7dea3c52eba24a9676d9eae Mon Sep 17 00:00:00 20

Re: env: follow up on argv0 setting feature

2024-03-24 Thread Pádraig Brady
On 23/03/2024 20:24, Matheus Afonso Martins Moreira wrote: Thank you!! Really happy to have this feature in upstream coreutils! Would you mind giving me feedback on the patch I sent? What can I do to make future contributions acceptable? I'm not very familiar with the GNU development processes.

Re: new snapshot available: coreutils-9.4.170-7b206.tar.xz

2024-03-23 Thread Pádraig Brady
On 23/03/2024 17:47, Sam James wrote: Pádraig Brady writes: We plan to release coreutils-9.5 in the coming week so any testing you can do on various different systems between now and then would be most welcome. This release comes about 30 weeks after the 9.4 release. I hit this build

new snapshot available: coreutils-9.4.170-7b206.tar.xz

2024-03-23 Thread Pádraig Brady
cp,ln,mv: improve dir vs nondir diagnostics mv: treat --exchange more like non-exchange Petr Malat (1): mv: add --swap (-x) option to atomically swap 2 paths Pádraig Brady (59): maint: post-release administrivia maint: avoid syntax check failure doc: add subsecti

Re: sc_strftime_check: adjust to newer info quoting style

2024-03-23 Thread Pádraig Brady
On 23/03/2024 10:18, Bernhard Voelker wrote: On my openSUSE:Tumbleweed system, the info pages seem to have changed the quoting style for the strftime for the conversion specifiers from the good old '%a' or `%a' styles to ‘%a’. $ info libc date calendar format | grep '^[^a-z%]*%.[^a-z%]*$' |

Re: env: follow up on argv0 setting feature

2024-03-21 Thread Pádraig Brady
On 20/03/2024 23:19, Pádraig Brady wrote: On 13/03/2024 10:19, Matheus Afonso Martins Moreira wrote: About a year ago, I posted an env feature request on this list: the ability to set the value of argv[0]. https://lists.gnu.org/archive/html/coreutils/2023-03/msg2.html I also sent a patch

Re: env: follow up on argv0 setting feature

2024-03-20 Thread Pádraig Brady
On 13/03/2024 10:19, Matheus Afonso Martins Moreira wrote: About a year ago, I posted an env feature request on this list: the ability to set the value of argv[0]. https://lists.gnu.org/archive/html/coreutils/2023-03/msg2.html I also sent a patch: https://lists.gnu.org/archive/html/coreuti

Re: Symlink flag for chmod

2024-03-19 Thread Pádraig Brady
On 18/03/2024 18:31, Pádraig Brady wrote: On 25/01/2024 14:13, Pádraig Brady wrote: On 25/01/2024 12:30, Johannes Segitz wrote: Hello, chown has a flag that prevents symlink following. chown/chmod is sometimes used in %post/%pre sections of rpm packages to fix up permissions. When this is

[PATCH] maint: basenc: consistently check buffer bounds when encoding

2024-03-19 Thread Pádraig Brady
* src/basenc.c (base16_encode, base2msbf_encode, base2lsbf_encode): Ensure we don't overflow the output buffer, whose length is passed in the OUTLEN parameter. This issue was flagged by clang with -Wunused-but-set-parameter. --- src/basenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 del

Re: Bug#628815: coreutils: pinky makes crazy DNS queries

2024-03-19 Thread Pádraig Brady
On 19/03/2024 10:54, deb...@perkelt.hu wrote: I looked into this and found that pinky tries to canonicalize the information in the "Where" column automaticaly, and it has no option to disable this behaviour. see line 285 pinky.c: if (*ut_host) /* See if we can canonicalize

[PATCH] doc: fix stale --dereference info for chown/chgrp

2024-03-18 Thread Pádraig Brady
Following v5.2.1-679-g7e29ef8b8 symlinks specified on the command line no longer induce an error if lchown() is not supported on the system. * doc/coreutils.texi (chown invocation, chgrp invocation): Adjust accordingly, and also use a macro to avoid duplication. * src/chown-core.c: Use our more st

Re: Symlink flag for chmod

2024-03-18 Thread Pádraig Brady
On 25/01/2024 14:13, Pádraig Brady wrote: On 25/01/2024 12:30, Johannes Segitz wrote: Hello, chown has a flag that prevents symlink following. chown/chmod is sometimes used in %post/%pre sections of rpm packages to fix up permissions. When this is done in user owned directories (somewhere

Re: pr option -i turned on by default

2024-03-13 Thread Pádraig Brady
On 13/03/2024 14:19, Douglas McIlroy wrote: In coreutils 9.0, pr option -i (output tabification) is turned on by default. This mistake radically complicates any further processing of the output. Has it been fixed in later versions? (I didn't spot it in the bug archive, but my search terms could h

Re: [PATCH] maint: prefer minmax.h instead of defining our own

2024-03-12 Thread Pádraig Brady
On 12/03/2024 17:59, Collin Funk wrote: I noticed that src/comm.c #define's min. Since system.h includes gnulib's minmax.h we can just remove it and use that. Pretty pointless, but might as well remove the duplication. :) Applied. thanks, Pádraig.

Re: Still a need for [ and pinky info pages?

2024-03-12 Thread Pádraig Brady
On 12/03/2024 13:58, Collin Funk wrote: On 2/19/24 6:16 AM, Pádraig Brady wrote: A basic info page for pinky would be appreciated. I just realized I sent this and then never responded. Sorry about that... I've attached a *very* basic patch adding mostly the same information as the man

Re: Fix race conditions in timeout(1)

2024-03-12 Thread Pádraig Brady
On 11/03/2024 16:22, Pádraig Brady wrote: On 11/03/2024 15:17, Pádraig Brady wrote: There was a narrow race condition reported at: https://github.com/coreutils/coreutils/issues/82 Then I noticed another related race condition in the case of failing fork(). Both should be addressed by the

Re: 'wc -m' and combining characters

2024-03-11 Thread Pádraig Brady
On 10/03/2024 15:16, Nick wrote: I'm attempting to learn about UTF-8. My question is about how wc counts "combining characters", as discussed here . I made two files, one with "LATIN CAPITAL LETTER A WITH DIAERESIS" called p1.txt. The other wi

Re: Fix race conditions in timeout(1)

2024-03-11 Thread Pádraig Brady
On 11/03/2024 15:17, Pádraig Brady wrote: There was a narrow race condition reported at: https://github.com/coreutils/coreutils/issues/82 Then I noticed another related race condition in the case of failing fork(). Both should be addressed by the attached. Actually the second one to ensure

Fix race conditions in timeout(1)

2024-03-11 Thread Pádraig Brady
There was a narrow race condition reported at: https://github.com/coreutils/coreutils/issues/82 Then I noticed another related race condition in the case of failing fork(). Both should be addressed by the attached. cheers, PádraigFrom c1cf5148a1c6302d27661ff0af772de1e7dbb2b6 Mon Sep 17 00:00:00

  1   2   3   4   5   6   7   8   9   10   >