Re: [PATCH 3/3] ls: add statx-enabled variants of stat and lstat calls

2019-09-12 Thread Andreas Dilger
On Sep 11, 2019, at 7:51 AM, Jeff Layton wrote: > > * add wrapper functions for stat, lstat and stat_for_mode so that we > can conditionally plug in statx-enabled variants > * add statx-enabled functions and set the request mask based on the > output format and what values are needed > --- >

Re: [PATCH 1/3] stat: move struct statx to struct stat conversion routines to new header

2019-09-12 Thread Andreas Dilger
On Sep 11, 2019, at 7:51 AM, Jeff Layton wrote: > > * move statx_timestamp_to_timespec and statx_to_stat to a new header Jeff, thanks for working out this patch series. Looks good to me. Reviewed-by: Andreas Dilger > --- > src/stat.c | 32 +-- > src/statx.h | 54

Re: [PATCH 2/3] ls: use statx for loop detection if it's available

2019-09-12 Thread Andreas Dilger
> On Sep 11, 2019, at 7:51 AM, Jeff Layton wrote: > > * move loop detection routine into separate function > * add a statx-enabled variant that is used when it's available. No need > for a full stat since all we care about is the dev/ino. > * Since dev/ino should never change, set