Re: Files full of zeros with coreutils-8.11 and xfs (FIEMAP related?)

2011-04-15 Thread Andreas Dilger
On 2011-04-14, at 6:09 PM, Dave Chinner da...@fromorbit.com wrote: On Fri, Apr 15, 2011 at 12:29:46AM +0100, Pádraig Brady wrote: On 14/04/11 23:59, Dave Chinner wrote: On Thu, Apr 14, 2011 at 10:50:10AM -0500, Eric Sandeen wrote: On 4/14/11 9:59 AM, Pádraig Brady wrote: On 14/04/11 15:02,

Re: Files full of zeros with coreutils-8.11 and xfs (FIEMAP related?)

2011-04-15 Thread Andreas Dilger
On 2011-04-15, at 11:26 AM, Christoph Hellwig wrote: On Fri, Apr 15, 2011 at 11:24:19AM -0600, Eric Blake wrote: Would it be worth borrowing from Solaris' semantics and adding SEEK_HOLE and SEEK_DATA to lseek(2), as a higher level (less-detailed, but easier to define and easier to use)

Re: Files full of zeros with coreutils-8.11 and xfs (FIEMAP related?)

2011-04-15 Thread Andreas Dilger
On 2011-04-15, at 6:50 PM, Dave Chinner da...@fromorbit.com wrote: What you are suggesting is that FIEMAP needs to be page cache coherent, and that is far, far away from the intended use of the interface. Even consiering that you need to looking for active pages in the page cache when mapping

Re: Files full of zeros with coreutils-8.11 and xfs (FIEMAP related?)

2011-04-17 Thread Andreas Dilger
On 2011-04-17, at 6:40 PM, Dave Chinner da...@fromorbit.com wrote: On Sat, Apr 16, 2011 at 08:21:28AM -0400, Theodore Tso wrote: On Apr 16, 2011, at 1:11 AM, Andreas Dilger wrote: In that case, it means cp should just always use FIEMAP_FLAG_SYNC, which is fine. Except that if someone

Re: [PATCH] stat: don't explicitly request file size for filenames

2019-07-04 Thread Andreas Dilger
On Jul 4, 2019, at 04:44, Pádraig Brady wrote: > > On 03/07/19 21:24, Andreas Dilger wrote: >> When calling 'stat -c %N' to print the filename, don't explicitly >> request the size of the file via statx(), as it may add overhead on >> some filesystems. The size is

Re: [PATCH] stat: don't explicitly request file size for filenames

2019-07-04 Thread Andreas Dilger
On Jul 4, 2019, at 04:44, Pádraig Brady wrote: > > diff --git a/lib/areadlink-with-size.c b/lib/areadlink-with-size.c > index eacad3f..2fbe51c 100644 > --- a/lib/areadlink-with-size.c > +++ b/lib/areadlink-with-size.c > @@ -36,14 +36,15 @@ > check, so it's OK to guess too small on hosts where

Re: [PATCH] stat: don't explicitly request file size for filenames

2019-07-04 Thread Andreas Dilger
On Jul 4, 2019, at 04:43, Jeff Layton wrote: > > On Thu, 2019-07-04 at 06:37 -0400, Jeff Layton wrote: >> On Wed, 2019-07-03 at 20:24 +0000, Andreas Dilger wrote: >>> When calling 'stat -c %N' to print the filename, don't explicitly >>> request the size of the f

[PATCH] stat: don't explicitly request file size for filenames

2019-07-03 Thread Andreas Dilger
nkname = areadlink_with_size (filename, statbuf->st_size ?: +1023); if (linkname == NULL) { error (0, errno, _("cannot read symbolic link %s"), -- 2.4.5 Cheers, Andreas -- Andreas Dilger Whamcloud

Re: [PATCH 3/3] ls: add statx-enabled variants of stat and lstat calls

2019-09-12 Thread Andreas Dilger
On Sep 11, 2019, at 7:51 AM, Jeff Layton wrote: > > * add wrapper functions for stat, lstat and stat_for_mode so that we > can conditionally plug in statx-enabled variants > * add statx-enabled functions and set the request mask based on the > output format and what values are needed > --- >

Re: [PATCH 1/3] stat: move struct statx to struct stat conversion routines to new header

2019-09-12 Thread Andreas Dilger
On Sep 11, 2019, at 7:51 AM, Jeff Layton wrote: > > * move statx_timestamp_to_timespec and statx_to_stat to a new header Jeff, thanks for working out this patch series. Looks good to me. Reviewed-by: Andreas Dilger > --- > src/stat.c | 32 +-- > s

Re: [PATCH 2/3] ls: use statx for loop detection if it's available

2019-09-12 Thread Andreas Dilger
> On Sep 11, 2019, at 7:51 AM, Jeff Layton wrote: > > * move loop detection routine into separate function > * add a statx-enabled variant that is used when it's available. No need > for a full stat since all we care about is the dev/ino. > * Since dev/ino should never change, set

Re: [PATCH v4 0/2] ls: use statx() when it's available

2019-09-19 Thread Andreas Dilger
t factor out loop > detection > - style cleanups > > Limiting the distribution list on this posting since the changes from > the last set are very minor. I'm not sure what the approval process for patches to fileutils are, but the whole patch series looks good to me. You can add (

Re: [PATCH] stat: don't explicitly request file size for filenames

2019-07-09 Thread Andreas Dilger
On Jul 5, 2019, at 04:18, Jeff Layton wrote: > > On Thu, 2019-07-04 at 21:18 +, Andreas Dilger wrote: >> On Jul 4, 2019, at 04:43, Jeff Layton wrote: >>> On Thu, 2019-07-04 at 06:37 -0400, Jeff Layton wrote: >>>> On Wed, 2019-07-03 at 20:24 +, Andreas

[PATCH] add lustre filesystem type

2008-10-06 Thread Andreas Dilger
: /* 0x137F */ return minix; case S_MAGIC_MINIX_30: /* 0x138F */ Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org