This argument is unused, and the function itself is not used outside of
src/stat.c.
* src/stat.c: drop statbuf argument from out_epoch_sec()
---
src/stat.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/stat.c b/src/stat.c
index bb1ef1a3d9ec..a0f32b32b958 100644
If HAVE_STATX is available, then use statx instead of stat/lstat/fstat.
This necessitates some copying due to the fact that we need a struct
stat to pass to some of the gnulib printing routines.
* src/stat.c: more comprehensive use of statx when available
---
src/stat.c | 565
Add two new command-line options that set the appropriate hint flags in
the statx call. These are primarily used with network filesystems to
indicate what level of cache coherency the application can tolerate.
The new options are only implemented when built with HAVE_STATX.
* NEWS: mention the
two new command-line options that allow it to control
whether to synchronize with the backend server (again, mostly useful
on network filesystems).
Jeff Layton (4):
stat: drop statbuf argument from out_epoch_sec()
stat: use statx instead of stat if it's available
stat: only set STATX_* mask b
If HAVE_STATX is available, then use statx instead of stat/lstat/fstat.
This necessitates some copying due to the fact that we need a struct
stat to pass to some of the gnulib printing routines.
* src/stat.c: more comprehensive use of statx when available
---
src/stat.c | 566
ment for some filesystems (particularly networked
ones).
This also adds two new command-line options that allow it to control
whether to synchronize with the backend server (again, mostly useful
on network filesystems).
Jeff Layton (4):
stat: drop statbuf argument from out_epoch_sec()
stat: use
This argument is unused, and the function itself is not used outside of
src/stat.c.
* src/stat.c: drop statbuf argument from out_epoch_sec()
---
src/stat.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/stat.c b/src/stat.c
index bb1ef1a3d9ec..a0f32b32b958 100644
Add two new command-line options that set the appropriate hint flags in
the statx call. These are primarily used with network filesystems to
indicate what level of cache coherency the application can tolerate.
The new options are only implemented when built with HAVE_STATX.
* NEWS: mention the
Scan the format string to build a STATX_* mask prior to calling statx.
This allows us to avoid setting bits for attributes that we don't
intend to display, which can mean a much lighter-weight operation on
some filesystems.
* src/stat.c: only set STATX_* mask bits for things we want to print
---
If HAVE_STATX is available, then use statx instead of stat/lstat/fstat.
This necessitates some copying due to the fact that we need a struct
stat to pass to some of the gnulib printing routines.
* src/stat.c: more comprehensive use of statx when available
---
src/stat.c | 561
Add two new command-line options that change how the statx call that
set the appropriate flags in the statx call, to modify its behavior
vs. network filesystems. These options are only implemented when
built with HAVE_STATX.
* NEWS: mention the enhancements
* src/stat.c: add new options to
adds two new command-line options that allow it to control
whether to synchronize with the backend server (again, mostly useful
on network filesystems).
Jeff Layton (4):
stat: drop statbuf argument from out_epoch_sec()
stat: use statx instead of stat if it's available
stat: only set STATX_
This argument is unused, and the function itself is not used outside of
src/stat.c.
* src/stat.c: drop statbuf argument from out_epoch_sec()
---
src/stat.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/stat.c b/src/stat.c
index bb1ef1a3d9ec..a0f32b32b958 100644
Scan the format string to build a STATX_* mask prior to calling statx.
This allows us to avoid setting bits for attributes that we don't
intend to display, which can mean a much lighter-weight operation on
some filesystems.
* src/stat.c: only set STATX_* mask bits for things we want to print
---
t on the mailing list).
>
+1
Just add new --offload / --no-offload options and wire up accordingly.
We could start with --no-offload being the default and flip that later,
once we feel that it's safe enough.
--
Jeff Layton
this? Should we just
apply the v6 set, and put yours on top, or would you rather I merge
these deltas into the set and send a v7 series?
Thanks,
--
Jeff Layton
This argument is unused, and the function itself is not used outside of
src/stat.c.
* src/stat.c: drop statbuf argument from out_epoch_sec()
---
src/stat.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/stat.c b/src/stat.c
index bb1ef1a3d9ec..a0f32b32b958 100644
If HAVE_STATX is available, then use statx instead of stat/lstat/fstat.
This necessitates some copying due to the fact that we need a struct
stat to pass to some of the gnulib printing routines.
* src/stat.c: more comprehensive use of statx when available
---
src/stat.c | 566
ful on
network filesystems).
Jeff Layton (4):
stat: drop statbuf argument from out_epoch_sec()
stat: use statx instead of stat if it's available
stat: only set STATX_* mask bits for things we want to print
stat: support statx DONT_SYNC and FORCE_SYNC flags
NEWS | 7 +
src/stat.c |
Scan the format string to build a STATX_* mask prior to calling statx.
This allows us to avoid setting bits for attributes that we don't
intend to display, which can mean a much lighter-weight operation on
some filesystems.
* src/stat.c: only set STATX_* mask bits for things we want to print
---
Add a new --cache= command-line option that sets the appropriate hint
flags in the statx call. These are primarily used with network
filesystems to indicate what level of cache coherency the application
can tolerate. The new option is only implemented when built with
HAVE_STATX.
* NEWS: mention
On Wed, 2019-06-05 at 23:46 +0100, Pádraig Brady wrote:
> On 05/06/19 16:52, Jeff Layton wrote:
> > On Mon, 2019-06-03 at 03:55 +0100, Pádraig Brady wrote:
> > > The main change here is to refactor code duplication.
> > > In particular this reuses the large print_stat()
* STATX_INO isn't defined until stat.h is included. Move the test down
so it works properly.
---
src/stat.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/stat.c b/src/stat.c
index 3bb84f35d4c0..ec0bb7de496c 100644
--- a/src/stat.c
+++ b/src/stat.c
@@
If HAVE_STATX is available, then use statx instead of stat/lstat/fstat.
This necessitates some copying due to the fact that we need a struct
stat to pass to some of the gnulib printing routines.
* src/stat.c: more comprehensive use of statx when available
---
src/stat.c | 566
Scan the format string to build a STATX_* mask prior to calling statx.
This allows us to avoid setting bits for attributes that we don't
intend to display, which can mean a much lighter-weight operation on
some filesystems.
* src/stat.c: only set STATX_* mask bits for things we want to print
---
Add a new --cache= command-line option that sets the appropriate hint
flags in the statx call. These are primarily used with network
filesystems to indicate what level of cache coherency the application
can tolerate. The new option is only implemented when built with
HAVE_STATX.
* NEWS: mention
e backend server (again, mostly useful on
network filesystems).
Jeff Layton (4):
stat: drop statbuf argument from out_epoch_sec()
stat: use statx instead of stat if it's available
stat: only set STATX_* mask bits for things we want to print
stat: support statx DONT_SYNC and FORCE_SYNC flags
On Mon, 2019-05-13 at 09:18 -0400, Jeff Layton wrote:
> Add a new --cache= command-line option that sets the appropriate hint
> flags in the statx call. These are primarily used with network
> filesystems to indicate what level of cache coherency the application
> can tolerate. Th
On Fri, 2019-05-10 at 02:28 -0700, Pádraig Brady wrote:
> On 01/05/19 06:57, Jeff Layton wrote:
> > Scan the format string to build a STATX_* mask prior to calling statx.
> > This allows us to avoid setting bits for attributes that we don't
> > intend to display, which ca
If HAVE_STATX is available, then use statx instead of stat/lstat/fstat.
This necessitates some copying due to the fact that we need a struct
stat to pass to some of the gnulib printing routines.
* src/stat.c: more comprehensive use of statx when available
---
src/stat.c | 566
k filesystems).
Jeff Layton (4):
stat: drop statbuf argument from out_epoch_sec()
stat: use statx instead of stat if it's available
stat: only set STATX_* mask bits for things we want to print
stat: support statx DONT_SYNC and FORCE_SYNC flags
NEWS | 8 +
src
Scan the format string to build a STATX_* mask prior to calling statx.
This allows us to avoid setting bits for attributes that we don't
intend to display, which can mean a much lighter-weight operation on
some filesystems.
* src/stat.c: only set STATX_* mask bits for things we want to print
---
Add a new --cache= command-line option that set the appropriate hint
flags in the statx call. These are primarily used with network
filesystems to indicate what level of cache coherency the application
can tolerate. The new option is only implemented when built with
HAVE_STATX.
* NEWS: mention
This argument is unused, and the function itself is not used outside of
src/stat.c.
* src/stat.c: drop statbuf argument from out_epoch_sec()
---
src/stat.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/stat.c b/src/stat.c
index bb1ef1a3d9ec..a0f32b32b958 100644
On Mon, 2019-04-29 at 09:40 -0700, Pádraig Brady wrote:
> On 23/04/19 04:59, Jeff Layton wrote:
> > > +#if HAVE_STATX && defined STATX_INO
> > > + fputs (_("\
> > > + -D, --dont-sync don't synchronize with server (for network
> &g
On Fri, 2019-07-05 at 06:18 -0400, Jeff Layton wrote:
> On Thu, 2019-07-04 at 21:18 +, Andreas Dilger wrote:
> > On Jul 4, 2019, at 04:43, Jeff Layton wrote:
> > > On Thu, 2019-07-04 at 06:37 -0400, Jeff Layton wrote:
> > > > On Wed, 2019-07-03 at 20:
On Thu, 2019-07-04 at 21:18 +, Andreas Dilger wrote:
> On Jul 4, 2019, at 04:43, Jeff Layton wrote:
> > On Thu, 2019-07-04 at 06:37 -0400, Jeff Layton wrote:
> > > On Wed, 2019-07-03 at 20:24 +, Andreas Dilger wrote:
> > > > When calling 'stat -c %N
ilename, statbuf->st_size ?:
> +1023);
>if (linkname == NULL)
> {
>error (0, errno, _("cannot read symbolic link %s"),
Looks reasonable to me.
Reviewed-by: Jeff Layton
On Thu, 2019-07-04 at 06:37 -0400, Jeff Layton wrote:
> On Wed, 2019-07-03 at 20:24 +, Andreas Dilger wrote:
> > When calling 'stat -c %N' to print the filename, don't explicitly
> > request the size of the file via statx(), as it may add overhead on
> > some filesyste
On Tue, Apr 16, 2019 at 5:23 PM Jeff Layton wrote:
>
> Add two new command-line options that set the appropriate hint flags in
> the statx call. These are primarily used with network filesystems to
> indicate what level of cache coherency the application can tolerate.
> The new o
* add wrapper functions for stat/lstat/fstat calls, and add variants for
when we are only interested in specific info
* add statx-enabled functions and set the request mask based on the
output format and what values are needed
* for loop detection, use AT_STATX_DONT_SYNC since we're only
io=4555MiB (4776MB), run=60019-60019msec
Jeff Layton (2):
stat: move struct statx to struct stat conversion routines to new
header
ls: use statx instead of stat when available
src/ls.c| 106
src/stat.c | 32 +---
s
* move statx_timestamp_to_timespec and statx_to_stat to a new header
---
src/stat.c | 32 +--
src/statx.h | 54 +
2 files changed, 55 insertions(+), 31 deletions(-)
create mode 100644 src/statx.h
diff --git
On Thu, 2019-09-12 at 11:58 -0600, Andreas Dilger wrote:
> > On Sep 11, 2019, at 7:51 AM, Jeff Layton wrote:
> >
> > * move loop detection routine into separate function
> > * add a statx-enabled variant that is used when it's available. No need
> > for a ful
On Fri, 2019-09-13 at 17:31 +0100, Pádraig Brady wrote:
> On 13/09/19 11:08, Jeff Layton wrote:
> > On Thu, 2019-09-12 at 11:58 -0600, Andreas Dilger wrote:
> > > Should this have a runtime fallback to stat() if statx() is not
> > > implemented
> > > on th
* add wrapper functions for stat/lstat/fstat calls, and add variants for
when we are only interested in specific info
* add statx-enabled functions and set the request mask based on the
output format and what values are needed
* for loop detection, use AT_STATX_DONT_SYNC since we're only
* move statx_timestamp_to_timespec and statx_to_stat to a new header
---
src/stat.c | 32 +---
src/statx.h | 52
2 files changed, 53 insertions(+), 31 deletions(-)
create mode 100644 src/statx.h
diff --git
76MB), run=60019-60019msec
Jeff Layton (2):
stat: move struct statx to struct stat conversion routines to new
header
ls: use statx instead of stat when available
src/ls.c| 106
src/stat.c | 32 +---
src/sta
76MB), run=60019-60019msec
Jeff Layton (3):
stat: move struct statx to struct stat conversion routines to new
header
ls: use statx for loop detection if it's available
ls: add statx-enabled variants of stat and lstat calls
src/ls.c| 179 ---
* move loop detection routine into separate function
* add a statx-enabled variant that is used when it's available. No need
for a full stat since all we care about is the dev/ino.
* Since dev/ino should never change, set AT_STATX_DONT_SYNC
unconditionally.
---
src/ls.c | 106
* add wrapper functions for stat, lstat and stat_for_mode so that we
can conditionally plug in statx-enabled variants
* add statx-enabled functions and set the request mask based on the
output format and what values are needed
---
src/ls.c | 73
* move statx_timestamp_to_timespec and statx_to_stat to a new header
---
src/stat.c | 32 +--
src/statx.h | 54 +
2 files changed, 55 insertions(+), 31 deletions(-)
create mode 100644 src/statx.h
diff --git
* move statx_timestamp_to_timespec and statx_to_stat to a new header
---
src/stat.c | 32 +---
src/statx.h | 52
2 files changed, 53 insertions(+), 31 deletions(-)
create mode 100644 src/statx.h
diff --git
* add wrapper functions for stat/lstat/fstat calls, and add variants for
when we are only interested in specific info
* add statx-enabled functions and set the request mask based on the
output format and what values are needed
* for loop detection, use AT_STATX_DONT_SYNC since we're only
WRITE: bw=75.9MiB/s (79.6MB/s), 75.9MiB/s-75.9MiB/s (79.6MB/s-79.6MB/s),
io=4555MiB (4776MB), run=60019-60019msec
Jeff Layton (2):
stat: move struct statx to struct stat conversion routines to new
header
ls: use statx instead of stat when available
src/ls.
On Fri, 2019-09-20 at 00:53 +0100, Pádraig Brady wrote:
> This looks good upon quick review.
> I will try to merge over the next couple of days.
>
> thanks!
> Pádraig
Ping? Any idea when you'll get a chance to review and merge this?
Thanks,
--
Jeff Layton
be for the directory itself. Maybe I'm
misunderstanding your question however.
--
Jeff Layton
On Tue, 2019-07-09 at 21:43 +, Andreas Dilger wrote:
> On Jul 5, 2019, at 04:18, Jeff Layton wrote:
> >
> > On Thu, 2019-07-04 at 21:18 +, Andreas Dilger wrote:
> >> On Jul 4, 2019, at 04:43, Jeff Layton wrote:
> >>> On Thu, 2019-07-04 at 06:37 -04
On Thu, 2019-10-24 at 10:16 +0100, Pádraig Brady wrote:
> On 09/10/2019 22:23, Pádraig Brady wrote:
> > On 09/10/2019 11:14, Jeff Layton wrote:
> > > On Wed, 2019-10-09 at 10:19 +0100, Pádraig Brady wrote:
> > > > On 19/09/19 16:59, Jeff Layton wrote:
> > &
On Wed, 2019-10-09 at 10:19 +0100, Pádraig Brady wrote:
> On 19/09/19 16:59, Jeff Layton wrote:
> > v4:
> > - set appropriate STATX_* bits for time_type, sort_type and
> > print_block_size
> >
> > v3:
> > - syntax cleanups. make syntax-check now
On Thu, 2020-09-10 at 15:02 +0300, Heikkinen, Ville (Nokia - FI/Espoo)
wrote:
> On 9/9/20 10:35 PM, Jeff Layton wrote:
> > On Tue, 2020-09-08 at 10:56 +0300, Ville Heikkinen wrote:
> >
> > Does this actually work around the seccomp bugs? What we found here was
> > that
; i < argc; i++)
> ok &= (fs
> ? do_statfs (argv[i], format)
> - : do_stat (argv[i], format, format2));
> +#if USE_STATX
> + : (use_stat
> + ? do_stat (argv[i], format, format2)
> + : do_statx (argv[i], format, format2))
> +#else
> + : do_stat (argv[i], format, format2)
> +#endif
> + );
>
>return ok ? EXIT_SUCCESS : EXIT_FAILURE;
> }
--
Jeff Layton
62 matches
Mail list logo