Re: du enhancement

2023-10-20 Thread Pádraig Brady
On 20/10/2023 00:22, Rusty Duplessis wrote: Would be nice to have an option to append a / to the end of directory names, so that you can distinguish between a file and directory when using -a. Something like -F option to ls. It's a good suggestion. I generally only use du with single files

Re: du enhancement

2023-10-20 Thread Pádraig Brady
On 20/10/2023 15:05, Dragan Simic wrote: On 2023-10-20 15:55, Arsen Arsenović wrote: Dragan Simic writes: On 2023-10-20 15:18, Pádraig Brady wrote: On 20/10/2023 00:22, Rusty Duplessis wrote: Would be nice to have an option to append a / to the end of directory names, so that you can

Re: 'tr' strange behaviors with '-t'

2023-10-22 Thread Pádraig Brady
On 22/10/2023 00:46, Eduardo Mezêncio wrote: Greetings, I would like some help to understand if some behaviors of 'tr' are bugs or just the intended behavior. # First case Consider `echo aaabcc | tr -ds bc a`: It outputs `a` as expected, because it deletes `b` and `c` and squeezes `aaa` t

[PATCH] base32,base64: disallow non-canonical encodings

2023-10-27 Thread Pádraig Brady
This will make decoding more resilient to corruption whether due to transmission errors or nefarious adjustment. See https://eprint.iacr.org/2022/361.pdf * gnulib: Update to commit 3f463202bd enforcing canonical encoding. * tests/basenc/base64.pl: Add a test cases, and adjust existing. * NEWS: Men

Re: [PATCH] chgrp: --from parameter similar to chown

2023-10-31 Thread Pádraig Brady
On 31/10/2023 17:51, Ed Neville wrote: Hi there, Please could one of the maintainers take a look at this patch? Is it ready for merge? It should be a straight forward change that brings the same functionality from chown. Best regards, Ed Yes I'll get to this one soon.

Re: Add -C to sha256sum and other cksum tool (similar to tar)

2023-11-07 Thread Pádraig Brady
On 07/11/2023 08:09, Przemysław Sztoch via GNU coreutils General Discussion wrote: Please add -C, --directory=DIR to sha256/512sum with similar action as in tar command: Change to DIR before performing any operations.  This option is order-sensitive, i.e. it affects all options that follow. Sec

Re: base64 feature request / enhancement ideas

2023-11-18 Thread Pádraig Brady
On 18/11/2023 09:07, Sadi Yumuşak wrote: I've recently experienced some difficulties in decoding/saving several inline attachments in an EML (Internet Message Format) file saved from Thunderbird (same for GMail web client) using the command "base64 --decode ". I've finally managed to do this aft

Re: [PATCH] chgrp: --from parameter similar to chown

2023-12-15 Thread Pádraig Brady
On 31/10/2023 19:49, Pádraig Brady wrote: On 31/10/2023 17:51, Ed Neville wrote: Hi there, Please could one of the maintainers take a look at this patch? Is it ready for merge? It should be a straight forward change that brings the same functionality from chown. Best regards, Ed Yes I&#x

Re: [PATCH] chgrp: --from parameter similar to chown

2023-12-17 Thread Pádraig Brady
On 16/12/2023 22:01, Bernhard Voelker wrote: On 12/15/23 14:22, Pádraig Brady wrote: On 31/10/2023 19:49, Pádraig Brady wrote: On 31/10/2023 17:51, Ed Neville wrote: Hi there, Please could one of the maintainers take a look at this patch? Is it ready for merge? It should be a straight

Re: [COREUTILS PATCH] selinux: avoid unnecessary security context translations

2023-12-19 Thread Pádraig Brady
On 19/12/2023 14:55, Christian Göttsche wrote: Do not perform SELinux context translation for operations not involving user input or output. Context translation converts MCS/MLS labels into human readable form, which is useful for user facing applications like ls(1) or the --context=CTX argument

Re: [COREUTILS PATCH] selinux: avoid unnecessary security context translations

2023-12-19 Thread Pádraig Brady
On 19/12/2023 15:53, Pádraig Brady wrote: On 19/12/2023 14:55, Christian Göttsche wrote: Do not perform SELinux context translation for operations not involving user input or output. Context translation converts MCS/MLS labels into human readable form, which is useful for user facing

Re: 'Cat' feature request

2023-12-25 Thread Pádraig Brady
On 25/12/2023 21:25, Kaz Kylheku wrote: On 2023-12-22 10:09, Evan Tremblay wrote: so, if you run: cat * it wont run(unless you use --show-all). Are scrambling to win a stupidest post of 2023 contest or something? That is not an appropriate response. The split between shell and utility hand

Re: head and file with CR line terminators

2023-12-26 Thread Pádraig Brady
On 26/12/2023 16:51, Fred H Olson wrote: I'm using the command: head -n1 on all the 12,000+ text files in my system (!) I have a few with CR line terminators (old Mac files?). I used the command "file" to identify and make a list of text files and created a long linear (12000+ lines) script that

Re: [PATCH] chgrp: --from parameter similar to chown

2023-12-27 Thread Pádraig Brady
On 17/12/2023 14:17, Pádraig Brady wrote: On 16/12/2023 22:01, Bernhard Voelker wrote: On 12/15/23 14:22, Pádraig Brady wrote: On 31/10/2023 19:49, Pádraig Brady wrote: On 31/10/2023 17:51, Ed Neville wrote: Hi there, Please could one of the maintainers take a look at this patch? Is it

Re: [PATCH] chgrp: --from parameter similar to chown

2023-12-27 Thread Pádraig Brady
On 27/12/2023 16:45, Jim Meyering wrote: On Wed, Dec 27, 2023 at 8:20 AM Pádraig Brady wrote: On 17/12/2023 14:17, Pádraig Brady wrote: On 16/12/2023 22:01, Bernhard Voelker wrote: On 12/15/23 14:22, Pádraig Brady wrote: On 31/10/2023 19:49, Pádraig Brady wrote: On 31/10/2023 17:51, Ed

Re: [PATCH] chgrp: --from parameter similar to chown

2023-12-27 Thread Pádraig Brady
On 27/12/2023 18:52, Pádraig Brady wrote: Oops. Updated patch attached. The above contains this inadvertent change, which I've undone locally: -src_chown_LDADD = $(LDADD) +src_chown = $(LDADD) cheers, Pádraig

fix thousands grouping issues

2023-12-27 Thread Pádraig Brady
On 27/12/2023 20:52, Jim Meyering wrote: Thanks. Nice improvement. I compared --help and --version output, which showed no difference other than the intended ones. Thanks for the review. Pushed. make check passed, modulo this unrelated failure on Fedora 38: numfmt.pl: test lcl-dbl-to-human-

Re: fix thousands grouping issues

2023-12-30 Thread Pádraig Brady
On 30/12/2023 05:47, Jim Meyering wrote: On Wed, Dec 27, 2023 at 4:14 PM Pádraig Brady wrote: On 27/12/2023 20:52, Jim Meyering wrote: Thanks. Nice improvement. I compared --help and --version output, which showed no difference other than the intended ones. Thanks for the review. Pushed

Re: [PATCH] ls: add a test to verify that '+' is added

2024-01-10 Thread Pádraig Brady
On 10/01/2024 18:21, Sylvestre Ledru wrote: Hello AFAIK, there isn't a test in ls to verify that using setfactl on directory shows a "+". This patch should cover this. That's worthwhile adding. It may need more guards though. I'd be inclined to check getfacl output first before testing with l

Re: [PATCH] ls: add a test to verify that '+' is added

2024-01-10 Thread Pádraig Brady
On 10/01/2024 21:10, Sylvestre Ledru wrote: Le 10/01/2024 à 21:41, Pádraig Brady a écrit : On 10/01/2024 18:21, Sylvestre Ledru wrote: Hello AFAIK, there isn't a test in ls to verify that using setfactl on directory shows a "+". This patch should cover this. That's w

Re: Possible ls locale bug

2024-01-16 Thread Pádraig Brady
On 15/01/2024 20:42, gnu.3bp3s--- via GNU coreutils General Discussion wrote: Hello, My locale is en_IE.UTF-8, so when I run the date command, the output at time of writing is "Mon 15 Jan 2024 20:39:04 GMT" Maybe I'm mistaken, but with that in mind I'd expect the following scenario: With time

[PATCH] tests: make ulimit -v interact better with ASAN

2024-01-17 Thread Pádraig Brady
ulimit -v is generally not supported with ASAN, giving errors like: "ReserveShadowMemoryRange failed while trying to map 0x... bytes. Perhaps you're using ulimit -v" * tests/cp/link-heap.sh: Mention ASAN as a possible reason for skipping. * tests/csplit/csplit-heap.sh: Likewise. * tests/cut/c

Re: Unset ICRNL in CBREAK mode in stty(1) following X/Open Curses

2024-01-21 Thread Pádraig Brady
On 21/01/2024 04:01, Soumendra Ganguly wrote: Respected maintainers, In X/Open Curses, Issue 7 ( https://pubs.opengroup.org/onlinepubs/9699909599/toc.pdf), the following is mentioned about the cbreak mode: This mode achieves the same effect as non-canonical-mode, Case B input processing (with M

Re: Unset ICRNL in CBREAK mode in stty(1) following X/Open Curses

2024-01-22 Thread Pádraig Brady
On 22/01/2024 06:41, Soumendra Ganguly wrote: Dear Pádraig, Thank you for the excellent explanation. Specifically, "I.e. input _is_ sent character at a time rather than line at a time," is enlightening. Kaz Kylheku gave a helpful response earlier, but I forgot to cc coreutils in my response t

Re: [PATCH] cp: Add --keep-directory-symlink option

2024-01-24 Thread Pádraig Brady
On 24/01/2024 12:16, Daan De Meyer wrote: When recursively copying files into OS trees, it often happens that some subdirectory of the source directory is a symlink in the target directory. Currently, cp will fail in that scenario with the error: "cannot overwrite non-directory %s with directory

Re: Symlink flag for chmod

2024-01-25 Thread Pádraig Brady
On 25/01/2024 12:30, Johannes Segitz wrote: Hello, chown has a flag that prevents symlink following. chown/chmod is sometimes used in %post/%pre sections of rpm packages to fix up permissions. When this is done in user owned directories (somewhere along the path) this is a security problem. chow

Re: Improve dircolors accessibility and readability

2024-01-28 Thread Pádraig Brady
On 28/01/2024 14:26, Fabio Sirna wrote: Hi, I want to suggest a small change that can improve dircolors default accessibility. The current default (view default screenshot) is: OTHER_WRITABLE 34;42 # dir that is other-writable (o+w) and not sticky that is not easy to read. I'm using OTHER_WR

Re: Build error caused by latest od commit

2024-02-07 Thread Pádraig Brady
On 07/02/2024 03:57, Collin Funk wrote: Hello, I ran into a build failure when compiling coreutils from master. On FreeBSD amd64 14.0-RELEASE-p4 with clang version 16.0.6 and no options given to ./configure I see the following error: src/od.c:510:1: error: passing 'bfloat16' (aka '__bf16') to pa

avoid clang -Wshadow warning

2024-02-07 Thread Pádraig Brady
On 07/02/2024 12:14, Collin Funk wrote: On 2/7/24 3:14 AM, Pádraig Brady wrote: I've added and extra configure check for that and pushed. Thanks, that seems to have fixed it. GCC 12.2.0 and GCC 13.2.1 seemed to fail from -Werror=shadow. I attached a patch that should fix it. Ah I see

Re: Still a need for [ and pinky info pages?

2024-02-19 Thread Pádraig Brady
On 12/02/2024 05:42, Collin Funk wrote: Hello, I noticed an old FIXME note in coreutils.texi and TODO about info pages for these programs. Is there still a need/desire for them? I notice that `man [' opens the manpage for `test' so I assume there isn't much need for a separate one. When opening t

Re: [PATCH] maint: Prefer #include <...> for gnulib substitute headers

2024-02-19 Thread Pádraig Brady
On 18/02/2024 20:27, Collin Funk wrote: Hello, this patch just changes some include directives for system headers guaranteed by gnulib. More information can be found on this thread: https://lists.gnu.org/archive/html/bug-gnulib/2024-02/msg00133.html Thanks, Collin Pushed. Thanks, Pádraig

Re: [PATCH] blake2-impl.h: use the C99's inline keyword

2024-02-19 Thread Pádraig Brady
On 13/02/2024 07:36, nightquick wrote: Note: I'm aware that there's a GitHub repository (upstream) but it doesn't seem like the repository is practically active anymore. There's libb2 which also implements blake2 (with C99 inline), but it's a little different than the current one. The implemen

Re: [PATCH] dircolors: update list of archive file extensions

2024-02-19 Thread Pádraig Brady
On 16/02/2024 16:24, Michel Lind wrote: * src/dircolors.hin: Sort archive section by extension. Treat .crate (Rust archives) as archive files. Signed-off-by: Michel Lind This makes sense. We already have jar files included, and crates are essentially tar.gz files. Applied. thanks, Pádraig.

Re: [PATCH v2] cp: Add --keep-directory-symlink option

2024-02-22 Thread Pádraig Brady
Made a few tweaks as per `make syntax-check`, added a NEWS entry and pushed. thank you, Pádraig

Re: sort dynamic linking overhead

2024-02-26 Thread Pádraig Brady
On 26/02/2024 06:44, Yann Collet wrote: * xxhash128 is not a cryptographic hash function, so it doesn't attempt tobe random. Just a correction : xxh128 does try to be random. And quite hardly: a significant amount of development is spent on ensuring this property. It’s even tested with Prac

Re: sort dynamic linking overhead

2024-02-26 Thread Pádraig Brady
On 26/02/2024 06:25, Paul Eggert wrote: On 2023-10-09 06:48, Pádraig Brady wrote: An incremental patch attached to use xxhash128 (0.8.2) shows a good improvement (note avx2 being used on this cpu): xxhash128 is not a cryptographic hash function, so it doesn't attempt to be random. Of c

Re: sort dynamic linking overhead

2024-02-26 Thread Pádraig Brady
On 26/02/2024 17:11, Andreas Schwab wrote: On Feb 25 2024, Paul Eggert wrote: +/* Dynamically link the crypto library, if it needs linking. */ +static void +link_libcrypto (void) +{ +#if DLOPEN_LIBCRYPTO && HAVE_OPENSSL_MD5 + void *handle = dlopen ("libcrypto.so", RTLD_LAZY | RTLD_GLOBAL);

Re: sort dynamic linking overhead

2024-02-26 Thread Pádraig Brady
On 26/02/2024 17:39, Bruno Haible wrote: Pádraig Brady wrote: + void *handle = dlopen ("libcrypto.so", RTLD_LAZY | RTLD_GLOBAL); That only works if libopenssl-devel is installed. Good spot. I'd already pushed a fix for this at: https://git.sv.gnu.org/gitweb/?p=coreutils.git

Re: sort dynamic linking overhead

2024-02-26 Thread Pádraig Brady
On 26/02/2024 18:06, Andreas Schwab wrote: On Feb 26 2024, Pádraig Brady wrote: https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=3bbdb3938 It's still bad as it adds a hidden dependency that is invisible to rpm. Right. In practice though since coreutils also links libcrypt

Re: sort dynamic linking overhead

2024-02-27 Thread Pádraig Brady
On 27/02/2024 11:15, Bruno Haible wrote: Paul Eggert wrote: I installed the attached patch into coreutils. With it, 'sort -R' continues to use MD5 but on GNUish platforms 'sort' links libcrypto dynamically only if -R is used (Bruno's suggestion). This doesn't significantly affect 'sort -R' perfo

Re: [PATCH] mktemp: cut the output info when suffix contains XXX.

2024-02-27 Thread Pádraig Brady
On 27/02/2024 01:41, lvgenggeng wrote: * src/mktemp.c: When --suffix was supply in cmdline, the template points to the meraged buffer(dest_name). As X is counted from template which not contains suffix, So the output should be cut. Signed-off-by: lvgenggeng --- src/mktemp.c | 9 +++-- 1

Re: sort dynamic linking overhead

2024-02-28 Thread Pádraig Brady
On 27/02/2024 21:36, Bruno Haible wrote: Pádraig Brady wrote: Does this work for all the various names of libcrypto in various distros? Debian 12 libcrypto.so.3 Ubuntu 22.04libcrypto.so.1.1 libcrypto.so.3 Slackware 15libcrypto.so.1.1 openSUSE 15.5 libcrypto.so.1.1 CentOS Stream

[PATCH] cat,cp,mv,install,split: Set the minimum IO block size used to 256KiB

2024-02-28 Thread Pádraig Brady
>> On 11/30/23 12:11, Pádraig Brady wrote: >>> Though that will generally give 128K, which is good when processing all >>> of a file, >>> but perhaps overkill when processing just the last part of a file. >> >> The 128 KiB number was computed as being

Re: On Translation Issues

2024-02-28 Thread Pádraig Brady
On 28/02/2024 09:16, qxrh_0228 wrote: I hope you can come up with a Chinese version. I believe there are a lot of users from China who have the same idea as me. Thanks We have basic support where required, like locale month abbreviations in ls: $ LC_ALL=zh_CN.UTF8 ls -l / | head -n2 总计 20

Re: [PATCH] cat,cp,mv,install,split: Set the minimum IO block size used to 256KiB

2024-02-28 Thread Pádraig Brady
On 28/02/2024 21:49, Jim Meyering wrote: On Wed, Feb 28, 2024 at 9:09 AM Pádraig Brady wrote: >> On 11/30/23 12:11, Pádraig Brady wrote: >>> Though that will generally give 128K, which is good when processing all >>> of a file, >>> but perhaps overk

Re: [PATCH] mv: add --swap (-s) option to atomically swap 2 paths

2024-03-01 Thread Pádraig Brady
On 29/02/2024 22:02, Petr Malat wrote: renameat2() syscall allows atomically swapping 2 paths on one file system. Expose this ability to the user using -s option. * NEWS: Mention the new option Thanks for the patch. That was suggested previously: https://lists.gnu.org/archive/html/coreutils/2

Re: [PATCH] mv: add --swap (-s) option to atomically swap 2 paths

2024-03-02 Thread Pádraig Brady
On 02/03/2024 01:41, Rob Landley wrote: On 3/1/24 05:05, Petr Malat wrote: Hi! On Fri, Mar 01, 2024 at 09:18:31AM +, Padraig Brady wrote: On 29/02/2024 22:02, Petr Malat wrote: renameat2() syscall allows atomically swapping 2 paths on one file system. Expose this ability to the user using

Re: [PATCH] mv: add --swap (-s) option to atomically swap 2 paths

2024-03-02 Thread Pádraig Brady
On 02/03/2024 12:46, Dominique Martinet wrote: Thanks for remembering me; didn't try the patch yet but overall looks good to me. Just one nitpick on the not supported message check: Pádraig Brady wrote on Sat, Mar 02, 2024 at 11:01:42AM +: + if (renameatu (AT_FDCWD, file[0], AT_

Re: [PATCH] mv: add --swap (-s) option to atomically swap 2 paths

2024-03-03 Thread Pádraig Brady
On 02/03/2024 23:18, Petr Malat wrote: On Sat, Mar 02, 2024 at 01:59:31PM +, P??draig Brady wrote: On 02/03/2024 12:46, Dominique Martinet wrote: Thanks for remembering me; didn't try the patch yet but overall looks good to me. Just one nitpick on the not supported message check: P??draig

Re: cksum: mode flag change when using --tag --untagged

2024-03-06 Thread Pádraig Brady
On 06/03/2024 15:32, Daniel Hofstetter wrote: Hi, I noticed some unexpected behavior and I'm unsure whether it's a bug or a feature. When using --untagged with non legacy checksums, the mode flag in the output is ' ' (space), meaning text mode: $ printf "hello" | cksum --untagged --algo=md5 5d

Re: stdbuf feature request - line buffering but for null-terminated data

2024-03-10 Thread Pádraig Brady
On 09/03/2024 16:30, Zachary Santer wrote: 'stdbuf --output=L' will line-buffer the command's output stream. Pretty useful, but that's looking for newlines. Filenames should be passed between utilities in a null-terminated fashion, because the null byte is the only byte that can't appear within o

Fix race conditions in timeout(1)

2024-03-11 Thread Pádraig Brady
There was a narrow race condition reported at: https://github.com/coreutils/coreutils/issues/82 Then I noticed another related race condition in the case of failing fork(). Both should be addressed by the attached. cheers, PádraigFrom c1cf5148a1c6302d27661ff0af772de1e7dbb2b6 Mon Sep 17 00:00:00

Re: Fix race conditions in timeout(1)

2024-03-11 Thread Pádraig Brady
On 11/03/2024 15:17, Pádraig Brady wrote: There was a narrow race condition reported at: https://github.com/coreutils/coreutils/issues/82 Then I noticed another related race condition in the case of failing fork(). Both should be addressed by the attached. Actually the second one to ensure

Re: 'wc -m' and combining characters

2024-03-11 Thread Pádraig Brady
On 10/03/2024 15:16, Nick wrote: I'm attempting to learn about UTF-8. My question is about how wc counts "combining characters", as discussed here . I made two files, one with "LATIN CAPITAL LETTER A WITH DIAERESIS" called p1.txt. The other wi

Re: Fix race conditions in timeout(1)

2024-03-12 Thread Pádraig Brady
On 11/03/2024 16:22, Pádraig Brady wrote: On 11/03/2024 15:17, Pádraig Brady wrote: There was a narrow race condition reported at: https://github.com/coreutils/coreutils/issues/82 Then I noticed another related race condition in the case of failing fork(). Both should be addressed by the

Re: Still a need for [ and pinky info pages?

2024-03-12 Thread Pádraig Brady
On 12/03/2024 13:58, Collin Funk wrote: On 2/19/24 6:16 AM, Pádraig Brady wrote: A basic info page for pinky would be appreciated. I just realized I sent this and then never responded. Sorry about that... I've attached a *very* basic patch adding mostly the same information as the man

Re: [PATCH] maint: prefer minmax.h instead of defining our own

2024-03-12 Thread Pádraig Brady
On 12/03/2024 17:59, Collin Funk wrote: I noticed that src/comm.c #define's min. Since system.h includes gnulib's minmax.h we can just remove it and use that. Pretty pointless, but might as well remove the duplication. :) Applied. thanks, Pádraig.

Re: pr option -i turned on by default

2024-03-13 Thread Pádraig Brady
On 13/03/2024 14:19, Douglas McIlroy wrote: In coreutils 9.0, pr option -i (output tabification) is turned on by default. This mistake radically complicates any further processing of the output. Has it been fixed in later versions? (I didn't spot it in the bug archive, but my search terms could h

Re: Symlink flag for chmod

2024-03-18 Thread Pádraig Brady
On 25/01/2024 14:13, Pádraig Brady wrote: On 25/01/2024 12:30, Johannes Segitz wrote: Hello, chown has a flag that prevents symlink following. chown/chmod is sometimes used in %post/%pre sections of rpm packages to fix up permissions. When this is done in user owned directories (somewhere

[PATCH] doc: fix stale --dereference info for chown/chgrp

2024-03-18 Thread Pádraig Brady
Following v5.2.1-679-g7e29ef8b8 symlinks specified on the command line no longer induce an error if lchown() is not supported on the system. * doc/coreutils.texi (chown invocation, chgrp invocation): Adjust accordingly, and also use a macro to avoid duplication. * src/chown-core.c: Use our more st

Re: Bug#628815: coreutils: pinky makes crazy DNS queries

2024-03-19 Thread Pádraig Brady
On 19/03/2024 10:54, deb...@perkelt.hu wrote: I looked into this and found that pinky tries to canonicalize the information in the "Where" column automaticaly, and it has no option to disable this behaviour. see line 285 pinky.c: if (*ut_host) /* See if we can canonicalize

[PATCH] maint: basenc: consistently check buffer bounds when encoding

2024-03-19 Thread Pádraig Brady
* src/basenc.c (base16_encode, base2msbf_encode, base2lsbf_encode): Ensure we don't overflow the output buffer, whose length is passed in the OUTLEN parameter. This issue was flagged by clang with -Wunused-but-set-parameter. --- src/basenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 del

Re: Symlink flag for chmod

2024-03-19 Thread Pádraig Brady
On 18/03/2024 18:31, Pádraig Brady wrote: On 25/01/2024 14:13, Pádraig Brady wrote: On 25/01/2024 12:30, Johannes Segitz wrote: Hello, chown has a flag that prevents symlink following. chown/chmod is sometimes used in %post/%pre sections of rpm packages to fix up permissions. When this is

Re: env: follow up on argv0 setting feature

2024-03-20 Thread Pádraig Brady
On 13/03/2024 10:19, Matheus Afonso Martins Moreira wrote: About a year ago, I posted an env feature request on this list: the ability to set the value of argv[0]. https://lists.gnu.org/archive/html/coreutils/2023-03/msg2.html I also sent a patch: https://lists.gnu.org/archive/html/coreuti

Re: env: follow up on argv0 setting feature

2024-03-21 Thread Pádraig Brady
On 20/03/2024 23:19, Pádraig Brady wrote: On 13/03/2024 10:19, Matheus Afonso Martins Moreira wrote: About a year ago, I posted an env feature request on this list: the ability to set the value of argv[0]. https://lists.gnu.org/archive/html/coreutils/2023-03/msg2.html I also sent a patch

Re: sc_strftime_check: adjust to newer info quoting style

2024-03-23 Thread Pádraig Brady
On 23/03/2024 10:18, Bernhard Voelker wrote: On my openSUSE:Tumbleweed system, the info pages seem to have changed the quoting style for the strftime for the conversion specifiers from the good old '%a' or `%a' styles to ‘%a’. $ info libc date calendar format | grep '^[^a-z%]*%.[^a-z%]*$' |

new snapshot available: coreutils-9.4.170-7b206.tar.xz

2024-03-23 Thread Pádraig Brady
cp,ln,mv: improve dir vs nondir diagnostics mv: treat --exchange more like non-exchange Petr Malat (1): mv: add --swap (-x) option to atomically swap 2 paths Pádraig Brady (59): maint: post-release administrivia maint: avoid syntax check failure doc: add subsecti

Re: new snapshot available: coreutils-9.4.170-7b206.tar.xz

2024-03-23 Thread Pádraig Brady
On 23/03/2024 17:47, Sam James wrote: Pádraig Brady writes: We plan to release coreutils-9.5 in the coming week so any testing you can do on various different systems between now and then would be most welcome. This release comes about 30 weeks after the 9.4 release. I hit this build

Re: env: follow up on argv0 setting feature

2024-03-24 Thread Pádraig Brady
On 23/03/2024 20:24, Matheus Afonso Martins Moreira wrote: Thank you!! Really happy to have this feature in upstream coreutils! Would you mind giving me feedback on the patch I sent? What can I do to make future contributions acceptable? I'm not very familiar with the GNU development processes.

Re: coreutils-9.4.170-7b206 mv/mv-exchange test failure

2024-03-24 Thread Pádraig Brady
On 24/03/2024 16:26, Bruno Haible wrote: The mv/mv-exchange test fails on: - NetBSD 9.3 - OpenBSD 7.4 - AIX 7.1 - AIX 7.3.1 The attached should fix the issue with this new test. thanks for all the testing! Pádraig From c45fcb2ed2d80df5e7dea3c52eba24a9676d9eae Mon Sep 17 00:00:00 20

Re: Test failure when building in setgid directory

2024-03-24 Thread Pádraig Brady
On 24/03/2024 16:29, Sven Joachim wrote: When building coreutils 9.4.170-7b206 on x86_64 GNU/Linux, I got a test failure in tests/chmod/symlinks, apparently because I was building in a setgid directory. The log file of the failed test is attached. , | $ LANG=C ls -ld /usr/local/src/coreutil

Re: some string issues in coreutils-9.4.170-7b206

2024-03-24 Thread Pádraig Brady
On 24/03/2024 16:35, Wenbin Lv wrote: Hi, I just finished updating the zh_CN translation for 9.4.170-7b206. Below are some string related issues I have noticed: src/chown-core.h:101: "owner and/or "should be translatable; Fixed in https://bugs.gnu.org/69985 src/chown.c:84: "[OWNER][:[GROUP]

Re: Correction to pl po translation

2024-03-24 Thread Pádraig Brady
On 24/03/2024 18:43, wrotycz wrote: I noticed some minor mistakes or inconsistences in translation so I send correction. Regards Wrotycz Please direct this to the translation project https://translationproject.org/team/ lists this as: translation-team...@lists.sourceforge.net thanks, Pádra

Re: coreutils-9.4.170-7b206 chmod/symlinks test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 16:55, Bruno Haible wrote: The chmod/symlinks test fails on: - Alpine Linux 3.18, That was not Alpine specific, rather due to setgid dirs: https://github.com/coreutils/coreutils/commit/f77a6352f - macOS 12.5, - FreeBSD 14.0, - NetBSD 9.3 and 10.0-rc4, - OpenBSD 7.

Re: coreutils-9.4.170-7b206 ls/dired test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 16:37, Bruno Haible wrote: The ls/dired test fails on: - FreeBSD 14.0, - Solaris 11 OpenIndiana. https://github.com/coreutils/coreutils/commit/a51af4329 thanks, Pádraig

Re: coreutils-9.4.170-7b206 misc/numfmt test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 17:14, Bruno Haible wrote: The misc/numfmt test fails on - Alpine Linux 3.18, - macOS 12.5, - FreeBSD 14.0, - Solaris 11 OpenIndiana. Find attached the test-suite.log files. If these test failures are due to platform-specific *printf bugs, please provide a test case fo

Re: coreutils-9.4.170-7b206 uniq/uniq test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 16:15, Bruno Haible wrote: The uniq/uniq test fails on Solaris 11 OpenIndiana. test-suite.log on Solaris 11 OpenIndiana: FAIL: tests/uniq/uniq = schar... uniq: test schar: stdout mismatch, comparing schar.2 (expected) and schar.O (actual) *** schar.2 Sun

Re: coreutils-9.4.170-7b206 cp/preserve-mode test failure

2024-03-25 Thread Pádraig Brady
On 24/03/2024 16:42, Bruno Haible wrote: The cp/preserve-mode test fails on Alpine Linux 3.18. test-suite.log from Alpine Linux 3.18: FAIL: tests/cp/preserve-mode + mkdir d1 d2 + chmod 705 d2 + cp '--no-preserve=mode' -r d2 d3 + get_mode d1 + stat '-c%f' d1 + g

Re: coreutils-9.4.170-7b206 uniq/uniq test failure

2024-03-26 Thread Pádraig Brady
On 25/03/2024 22:28, Bruno Haible wrote: Pádraig Brady wrote: while uniq (c32isblank) now determines it is not blank (which seems more correct). I agree that U+00A0 NO-BREAK SPACE should better be considered to be non-blank (and Gnulib's c32isblank does so). The only solaris 11 sys

Re: Feature request: numfmt --from=K or k

2024-03-26 Thread Pádraig Brady
On 26/03/2024 13:13, Tim Baverstock wrote: Hi. I sometimes end up with a list of files whose sizes represent K instead of bytes. I recognise I can filter them to add the 'K' before passing them through numfmt, but if I could tell numfmt --from=K it would be more convenient. Thanks for your con

Re: coreutils-9.4.170-7b206 ls/removed-directory test failure

2024-03-26 Thread Pádraig Brady
On 24/03/2024 16:30, Bruno Haible wrote: The ls/removed-directory test fails on FreeBSD 14.0. tests-suite.log from FreeBSD 14.0: FAIL: tests/ls/removed-directory diff -u /dev/null err --- /dev/null 1970-01-01 +++ err 1970-01-01 +ls: reading directory '.': No

Re: coreutils-9.4.170-7b206 ls/removed-directory test failure

2024-03-26 Thread Pádraig Brady
On 26/03/2024 17:08, Paul Eggert wrote: On 3/26/24 10:50, Pádraig Brady wrote: It seems that readdir() on FreeBSD 14 is _not_ eating the ENOENT from getdirentries(). Attached is an extra check for that, that avoids the test in that case. An alternative would be for ls to ignore the ENOENT from

Re: coreutils-9.4.170-7b206 ls/removed-directory test failure

2024-03-26 Thread Pádraig Brady
On 26/03/2024 18:25, Bruno Haible wrote: Pádraig Brady wrote: The ls/removed-directory test fails on FreeBSD 14.0. tests-suite.log from FreeBSD 14.0: FAIL: tests/ls/removed-directory diff -u /dev/null err --- /dev/null 1970-01-01 +++ err 1970-01-01 +ls

Re: uniq for unsorted input

2024-03-26 Thread Pádraig Brady
On 26/03/2024 16:40, Bruno Haible wrote: The documentation of 'uniq' [1] says: "The input need not be sorted, but repeated input lines are detected only if they are adjacent. If you want to discard non-adjacent duplicate lines, perhaps you want to use 'sort -u'." When I wrote gnulib-

Re: coreutils-9.4.170-7b206 misc/numfmt test failure

2024-03-26 Thread Pádraig Brady
On 26/03/2024 18:54, Bruno Haible wrote: Pádraig Brady wrote: The misc/numfmt test fails on - Alpine Linux 3.18, - macOS 12.5, - FreeBSD 14.0, - Solaris 11 OpenIndiana. Find attached the test-suite.log files. If these test failures are due to platform-specific *printf bugs

new snapshot available: coreutils-9.4.184-606f5.tar.xz

2024-03-26 Thread Pádraig Brady
We plan to release coreutils-9.5 in the next few days so any testing you can do on various different systems between now and then would be most welcome. This release comes about 30 weeks after the 9.4 release. Changes since the last pre-release (https://lists.gnu.org/archive/html/coreutils/2024-0

Re: new snapshot available: coreutils-9.4.184-606f5.tar.xz

2024-03-26 Thread Pádraig Brady
0 test failures on Fedora 39 amd64 (with ASAN enabled) 0 test failures on macOS 12.6 arm64 (m1) FAIL: tests/chown/preserve-root === Bruno already reported. Not a new issue. Due to "chgrp: invalid group: '4294967295'" 1 gnulib test failure on Centos 7.9.2009 ppc64 (cfa

new snapshot available: coreutils-9.4.185-541b02.tar.xz

2024-03-26 Thread Pádraig Brady
We plan to release coreutils-9.5 in the next few days so any testing you can do on various different systems between now and then would be most welcome. This release comes about 30 weeks after the 9.4 release. Changes since the last pre-release (https://lists.gnu.org/archive/html/coreutils/2024-0

Re: [platform-testers] new snapshot available: coreutils-9.4.184-606f5.tar.xz

2024-03-26 Thread Pádraig Brady
On 26/03/2024 21:19, Bruno Haible wrote: Pádraig Brady wrote: We plan to release coreutils-9.5 in the next few days I would suggest to update to the current gnulib, in order to get these two fixes: https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h

Re: coreutils-9.4.185-541b02 od/od-multiple-t test failure

2024-03-27 Thread Pádraig Brady
On 27/03/2024 12:03, Bruno Haible wrote: The tests/od/od-multiple-t.sh test fails on - Linux/ia64 (Gentoo, recent glibc, real hardware) - Linux/m68k (Debian 12, QEMU emulated) The first 'od' invocation that causes fail=1 to be set is: $ seq 19 > input $ ./od -An -taz -tfLz input 1 nl

Re: coreutils-9.4.185-541b02 od/od-multiple-t test failure

2024-03-27 Thread Pádraig Brady
On 27/03/2024 12:35, Bruno Haible wrote: Pádraig Brady wrote: The original bug report was not specific to floats, so I'll just remove them from the test. I think it is enough to remove the 'long double' part from the test (option letter 'L'). 'float' and &#

Re: new snapshot available: coreutils-9.4.185-541b02.tar.xz

2024-03-28 Thread Pádraig Brady
0 test failures on Fedora 39 amd64 (with ASAN enabled) 0 test failures on Centos 7.9 IBM POWER8 8247-22L 0 test failures on AlmaLinux 9.3 IBM POWER10 9043-MRX

coreutils-9.5 released [stable]

2024-03-28 Thread Pádraig Brady
) Petr Malat (1) Bruno Haible (3)Pádraig Brady (75) Christian Göttsche (1) Samuel Tardieu (1) Collin Funk (4) Stephane Chazelas (1) Daan De Meyer (1) Stephen Kitt (1) Greg Wooledge (1) Sylvestre Ledru (3) Grisha Levit

Re: Feature Request: env -f to read from file

2024-03-28 Thread Pádraig Brady
On 28/03/2024 15:52, Balakrishnan Balasubramanian wrote: When env command is used to pass extra environment variables to a program, it will be useful to read them from a file instead of command line. Instead of     env MYAPP_QA_KEY=X MYAPP_QA_URL=https://qa.myapp.example.com clicommand W

Re: Date setting examples in manual

2024-03-28 Thread Pádraig Brady
On 24/03/2024 18:32, wrotycz wrote: I noticed there are no examples of how to set date using date, in the manual. Therefore I propose to add these to examples section to make it clear and easy to do so. I used simple formats, more like 'machine formats' to make it even simpler, as no one wants

Re: [PATCH 4/4] cut: Optionally treat multiple consecutive delimiters as one

2024-03-28 Thread Pádraig Brady
On 28/03/2024 19:43, Dragan Simic wrote: Hello, Just checking, are there any further thoughts on this topic? It's on the list, but didn't have the priority for this release. I intend to have a look at the new cut proposals for next release. cheers, Pádraig

Re: Feature Request: env -f to read from file

2024-03-29 Thread Pádraig Brady
On 29/03/2024 05:05, Kaz Kylheku wrote: On 2024-03-28 15:29, Balakrishnan Balasubramanian wrote: On 2024-03-28 3:38 p.m., Pádraig Brady wrote: Yes the feature has merit, and was previously discussed at: https://lists.gnu.org/archive/html/coreutils/2021-10/msg1.html There are some

Re: wc -l AVX code 10%+10% speedup

2024-03-30 Thread Pádraig Brady
On 30/03/2024 14:52, Evgeny Nizhibitsky wrote: Dear GNU coreutils maintainers, It seems that I found a way to both speed-up (~10%) and simplify (13 insertions, 43 deletions) the wc -l avx code while playing with it, at least on several million to 1 billion row files I tested with my cpu. It mos

Re: [PATCH] wc: speed-up by simplifying avx code

2024-03-31 Thread Pádraig Brady
On 31/03/2024 00:18, Evgeny Nizhibitsky wrote: Here is the proposed patch for both simplifying and consistently speeding up the avx version of wc -l by 10% in up to 1 billion rows scenarios on 7800X3D (probably should be tested on different data samples and CPUs). The patch was mangled, but I

Re: [PATCH] wc: speed-up by simplifying avx code

2024-03-31 Thread Pádraig Brady
On 31/03/2024 13:12, Pádraig Brady wrote: On 31/03/2024 00:18, Evgeny Nizhibitsky wrote: Here is the proposed patch for both simplifying and consistently speeding up the avx version of wc -l by 10% in up to 1 billion rows scenarios on 7800X3D (probably should be tested on different data

  1   2   3   4   5   6   7   8   9   10   >