sort/uniq/join: key-comparison code consolidation
Hello all, continuing an old thread (join/uniq with advanced sorting options)... http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html Attached is an updated patch rebased against the latest 'master'. regards, - assaf P.S. Just keeping this patch up-to-date, as the previous one did not apply any more. no need for comments unless/until we're ready to include it. key-compare-2016-04-24.patch.xz Description: Binary data
Re: sort/uniq/join: key-comparison code consolidation
On 08/07/15 01:56, Assaf Gordon wrote: Hello, ... continuing an old thread (join/uniq with advanced sorting options): http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html If there's still interest, attached is updated/rebased patch. Thanks Assaf. Yes now that 8.24 is out, we can look at merging this.
Re: sort/uniq/join: key-comparison code consolidation
Hello, ... continuing an old thread (join/uniq with advanced sorting options): http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html attached is updated/rebased patch. Comments are welcomed, -gordon key-compare-2014-10-07.patch.xz Description: application/xz
Re: sort/uniq/join: key-comparison code consolidation
Hello, On 01/23/2014 07:50 PM, Assaf Gordon wrote: If there is still interest, here's an updated patch, against the latest version, of adding these features to join+uniq: http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html Attached another rebase + minor fix for recent 'devmsg' change. Comments are welcomed, -gordon key-compare-2014-05-02.patch.xz Description: application/xz
Re: sort/uniq/join: key-comparison code consolidation
Hello, If there is still interest, here's an updated patch, against the latest version, of adding these features to join+uniq: http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html The patch has been re-created (not just rebased), because the old one caused few conflicts. Functionally it is the same as before, and all tests pass. Comments are welcomed, -gordon key-compare-2014-01-23.patch.xz Description: application/xz
Re: sort/uniq/join: key-comparison code consolidation
On 01/24/2014 12:50 AM, Assaf Gordon wrote: Hello, If there is still interest, here's an updated patch, against the latest version, of adding these features to join+uniq: http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html The patch has been re-created (not just rebased), because the old one caused few conflicts. Functionally it is the same as before, and all tests pass. Comments are welcomed, -gordon Excellent, definitely still interest. Now that the previous release is done, I would consider this a candidate for the next release. thanks, Pádraig.
Re: sort/uniq/join: key-comparison code consolidation
Regarding previously discussed topic: http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html Attached is another update, rebased against the latest version. comments are welcomed, -gordon key-comapre.2013-07-02.patch.xz Description: application/xz
Re: sort/uniq/join: key-comparison code consolidation
On 07/04/2013 06:33 PM, Assaf Gordon wrote: Regarding previously discussed topic: http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html Attached is another update, rebased against the latest version. comments are welcomed, -gordon Thanks Assaf, This is bubbling up my review queue. cheers, Pádraig.
Re: sort/uniq/join: key-comparison code consolidation
Assaf Gordon wrote, On 04/10/2013 01:49 PM: ( new thread for previous topic http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html ) . Another update, rebased against the latest version. comments are welcomed, -gordon key-comapre.2013-04-17.patch.xz Description: application/xz
Re: sort/uniq/join: key-comparison code consolidation
Hello, Assaf Gordon wrote, On 02/14/2013 06:07 PM: ( new thread for previous topic http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html ) . Attached is the sort/uniq/join key-comparison patch, rebased against the latest revision. This patch should also be cleaner and the commit comments more helpful. comments are welcomed, -gordon key-compare4.patch.xz Description: application/xz
sort/uniq/join: key-comparison code consolidation
Hello,
( new thread for previous topic
http://lists.gnu.org/archive/html/coreutils/2013-02/msg00082.html ) .
The attached patch contains:
1. src/key-spec-parsing.{h,c} - key comparison code, previously in sort.c
2. uniq - now supports --key (multiple keys, too).
Same as before, but rebased against 8.21.
Supported orders:
-k1,1 = ascii
-k1b,1 = ignore-blanks
-k1d,1 = dictionary
-k1i,1 = non-printing
-k1f,1 = ignore-case
-k1n,1 = fast-numeric
-k1g,1 = general-numeric
-k1M,1 = month
also supports user-specified delimiter (default: white-space).
Related discussions:
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5832
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7068
http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00211.html
3. sort - same functionality as before, but key-comparison code extracted to a
different file.
4. join - internally uses the key-comparison code.
Does not support the --key parameter (uses the standard -j/-1/-2),
but accepts new arguments that affect joining order:
-r --reverse
-n --numeric-sort
-d --dictionary-order
-g --general-numeric
Related discussions:
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6903
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6366
As an option, perhaps we can support new -k that will be like -j but allow
specificity options
(e.g. -k1nr will be equivalent to -j 1 --numeric --reverse).
It'll be easy to add human-numeric-sort/version-sort to join/uniq, but I'm not
sure if they make sense.
Regards,
-gordon
key_compare7.patch.xz
Description: application/xz
