Hello,

The current Makefiles of courier add -lunicode to the LDFLAGS variable
at a few places.

This is wrong. Libs should never be added to LDFLAGS. This causes the
build process to proceed with the wrong linking order which will
sometimes fail.

Such bugs usually don't cause issues unless one uses the ld-parameter
--as-needed. Many linux distributions do this by default these days, so
it's better to have the linking order correct.

See attached patch. It's against the courier-libs git repo. Please
apply.

cu,
-- 
Hanno Böck
http://hboeck.de/

mail/jabber: ha...@hboeck.de
GPG: BBB51E42
diff -Naur courier-libs/gpglib/Makefile.am courier-libs1/gpglib/Makefile.am
--- courier-libs/gpglib/Makefile.am	2014-09-12 15:05:52.760628218 +0200
+++ courier-libs1/gpglib/Makefile.am	2014-09-12 15:07:53.739115778 +0200
@@ -17,9 +17,9 @@
 	sign.c tempname.c tempname.h
 
 testgpg_SOURCES=testgpg.c
-testgpg_LDADD=libgpg.la ../numlib/libnumlib.la
+testgpg_LDADD=libgpg.la ../numlib/libnumlib.la -lunicode
 testgpg_DEPENDENCIES=$(testgpg_LDADD)
-testgpg_LDFLAGS=-static -lunicode
+testgpg_LDFLAGS=-static
 
 mimegpg_SOURCES=mimegpg.c
 mimegpg_LDADD=libgpg.la ../rfc2045/librfc2045.la ../rfc822/librfc822.la \
diff -Naur courier-libs/rfc2045/Makefile.am courier-libs1/rfc2045/Makefile.am
--- courier-libs/rfc2045/Makefile.am	2014-09-12 15:05:52.814627543 +0200
+++ courier-libs1/rfc2045/Makefile.am	2014-09-12 15:07:14.767602989 +0200
@@ -31,24 +31,23 @@
 
 reformime_SOURCES=reformime.c
 reformime_LDADD = librfc2045.la ../rfc822/libencode.la ../rfc822/librfc822.la \
-		../numlib/libnumlib.la
+		../numlib/libnumlib.la -lunicode
 reformime_DEPENDENCIES = $(reformime_LDADD)
-reformime_LDFLAGS=-static -lunicode
+reformime_LDFLAGS=-static
 
 makemime_SOURCES=makemime.c
-makemime_LDADD = ../rfc822/libencode.la ../rfc822/librfc822.la librfc2045.la ../numlib/libnumlib.la
+makemime_LDADD = ../rfc822/libencode.la ../rfc822/librfc822.la librfc2045.la ../numlib/libnumlib.la -lunicode
 makemime_DEPENDENCIES=$(makemime_LDADD)
-makemime_LDFLAGS=-static -lunicode
+makemime_LDFLAGS=-static
 
 headercheck_SOURCES=headercheck.c
-headercheck_LDADD=librfc2045.la ../rfc822/librfc822.la ../numlib/libnumlib.la
+headercheck_LDADD=librfc2045.la ../rfc822/librfc822.la ../numlib/libnumlib.la -lunicode
 headercheck_DEPENDENCIES=$(headercheck_LDADD)
-headercheck_LDFLAGS=-static -lunicode
+headercheck_LDFLAGS=-static
 
 testrfc3676parser_SOURCES=testrfc3676parser.c
-testrfc3676parser_LDADD=librfc2045.la
+testrfc3676parser_LDADD=librfc2045.la -lunicode
 testrfc3676parser_DEPENDENCIES=$(testrfc3676parser_LDADD)
-testrfc3676parser_LDFLAGS=-lunicode
 
 if HAVE_SGML
 reformime.html: reformime.sgml ../docbook/sgml2html

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
courier-users mailing list
courier-users@lists.sourceforge.net
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users

Reply via email to