Re: [courier-users] [patch] fix duplicate definition of sqwebmail_content_charset in courier

2016-09-20 Thread Sam Varshavchik
Alessandro Vesely writes: On Mon 19/Sep/2016 13:58:28 +0200 Hanno Böck wrote: > > The variable sqwebmail_content_charset is defined twice, in sqwebmail.c > and gpg.c. One of them should be declared as extern. Isn't that the default? The C spec has sentences such as: If the declaration of

Re: [courier-users] [patch] fix duplicate definition of sqwebmail_content_charset in courier

2016-09-20 Thread Alessandro Vesely
On Mon 19/Sep/2016 13:58:28 +0200 Hanno Böck wrote: > > The variable sqwebmail_content_charset is defined twice, in sqwebmail.c > and gpg.c. One of them should be declared as extern. Isn't that the default? The C spec has sentences such as: If the declaration of an identifier for an object

[courier-users] [patch] fix duplicate definition of sqwebmail_content_charset in courier

2016-09-19 Thread Hanno Böck
Hi, The variable sqwebmail_content_charset is defined twice, in sqwebmail.c and gpg.c. One of them should be declared as extern. By default gcc is lax on these things and allows duplicate global definitions. However it is not correct and gcc can be switched to a more strict mode with the flag -fn