Possible bug in Test::Builder, fix is easy, but might break things

2015-12-21 Thread Chad Granum
Test::Builder appends all Ok's to a structure it can return via $tb->details. These Ok's have the fields 'ok' and 'actual_ok'. 'actual_ok' is the true/false value passed to $tb->ok, 'ok' is adjusted to be true if the test was run under TODO.

Re: Possible bug in Test::Builder, fix is easy, but might break things

2015-12-21 Thread Karen Etheridge
> The problem is that parent_todo is not considered when setting the OK's in the details in subtests. That means if a subtest ok fails, and the parent is in todo, the 'ok' and 'actual_ok' are both set to false. Why is this a bug? After all, it's only the top level of TAP that ever matters when it

Re: Possible bug in Test::Builder, fix is easy, but might break things

2015-12-21 Thread Chad Granum
Created https://github.com/Test-More/test-more/issues/616 to track this where more people can see it. On Mon, Dec 21, 2015 at 8:58 PM, Chad Granum wrote: > > > On Mon, Dec 21, 2015 at 5:10 PM, Karen Etheridge wrote: > >> > The problem is that parent_todo