Network connection

2017-11-12 Thread James E Keenan
Is there any code which is considered "best practice" for "skip_all unless I have an Internet connection"? For the first time I want to write a library whose tests will benefit from connection to an FTP server. If there is some code that I could just drop in for situations where the test suit

Re: Network connection

2017-11-12 Thread Chad Granum
I personally would make it an author test that requires the AUTHOR_TESTING env var. I have apent too much time debugging network tests that fail because a file moved, a domain was down/expired, or the connection was not sufficient, but present. There are also corperate/school blacklists/whitelists

Re: Network connection

2017-11-12 Thread Kent Fredric
On 13 November 2017 at 03:59, James E Keenan wrote: > Is there any code which is considered "best practice" for "skip_all unless I > have an Internet connection"? > > For the first time I want to write a library whose tests will benefit from > connection to an FTP server. If there is some code th

Re: Network connection

2017-11-12 Thread Chad Granum
Kent, (or anyone really) Can you point to any documentation that covers these env vars, and the best practices you layed out? I have never even heard of the NO_NETWORK_TESTING var, and considering what modules I maibtain that is worrysome. I am not asking out of doubt, I want to educate myself, a

Re: Network connection

2017-11-12 Thread David Golden
There's https://metacpan.org/pod/Test::Internet and https://metacpan.org/pod/Test::RequiresInternet . I do recommend restricting those AUTOMATED_TESTING or AUTHOR_TESTING. There's also the core-only approach like is used in HTTP::Tiny: https://metacpan.org/source/DAGOLDEN/HTTP-Tiny-0.070/t/200_li

Re: Network connection

2017-11-12 Thread Kent Fredric
On 13 November 2017 at 04:46, Chad Granum wrote: > Kent, (or anyone really) > > Can you point to any documentation that covers these env vars, and the best > practices you layed out? I have never even heard of the NO_NETWORK_TESTING > var, and considering what modules I maibtain that is worrysome.