Re: [C++-sig] Segfault with keyword arguments and overloads.

2013-08-08 Thread Alex Mohr
Oh! I did miss your patch, sorry. Thanks! It looks to me like your patch calls PyTuple_GET_ITEM() with None as the python object (when kv is None). The python docs for PyTuple_GET_ITEM say, "Like PyTuple_GetItem(), but does no checking of its arguments." To me that means that the object you

Re: [C++-sig] Segfault with keyword arguments and overloads.

2013-08-08 Thread Alex Leach
Hi Alex, On Wed, 07 Aug 2013 18:06:24 +0100, Alex Mohr wrote: Thanks for your response. I've responded to your comments in-line below. After further investigation, I believe this can be fixed by simply checking for None when we get 'kv' from f->m_arg_names while resolving keywords. If w

Re: [C++-sig] Segfault with keyword arguments and overloads.

2013-08-07 Thread Alex Mohr
Thanks for your response. I've responded to your comments in-line below. After further investigation, I believe this can be fixed by simply checking for None when we get 'kv' from f->m_arg_names while resolving keywords. If we encounter None, that means the overload doesn't accept a keyword

Re: [C++-sig] Segfault with keyword arguments and overloads.

2013-08-07 Thread Alex Leach
Hi, On Wed, 07 Aug 2013 01:35:54 +0100, Alex Mohr wrote: I'm hitting a repeatable segfault trying to upgrade our boost version. I believe there may be a bug with overload resolution in the presence of keyword arguments. Here's a minimal example that crashes for me. // C++ #include stat

[C++-sig] Segfault with keyword arguments and overloads.

2013-08-06 Thread Alex Mohr
I'm hitting a repeatable segfault trying to upgrade our boost version. I believe there may be a bug with overload resolution in the presence of keyword arguments. Here's a minimal example that crashes for me. // C++ #include static void f1(int a0, int a1) { } static void f2(int a0, int a1, i