Re: [Crash-utility] [PATCH v2] files: support dump file pages from its address space

2015-06-19 Thread Dave Anderson
And a couple other things I forgot to mention... The vast majority of the files -M output consists of either the file descriptors for CHR, FIFO, SOCK, etc., files, or REG file descriptors that don't have any pages mapped into the task's address space. (1) Wouldn't it make more sense to show

Re: [Crash-utility] [PATCH v2] files: support dump file pages from its address space

2015-06-19 Thread Dave Anderson
- Original Message - But more importantly with respect to the API is the change where you added the callback argument to the do_radix_tree() function. The do_radix_tree API cannot be changed without breaking any pre-existing extension modules that currently use it. I

Re: [Crash-utility] [PATCH v2] files: support dump file pages from its address space

2015-06-19 Thread Dave Anderson
Hi Oliver, A few more comments and suggestions regarding your patch. A couple things I noted when testing on a 32-bit x86. First, the columns don't line up correctly: crash files -M 3804 PID: 3804 TASK: f466a5e0 CPU: 0 COMMAND: crash ROOT: /CWD: /root/crash-5.1.8 FD

Re: [Crash-utility] [PATCH v2] files: support dump file pages from its address space

2015-06-18 Thread Dave Anderson
- Original Message - Dave, Sorry, I can't reply the mail to orignial thread, as my vpn got blocked and I can't access my gmail account. This is the v2 version of files -M and -m support. Following issues got fixed in this version, 1. Patch is based on current git HEAD 2.

Re: [Crash-utility] [PATCH] Fix memory leaks in dump_mem_map when SPARSEMEM is enabled

2015-06-17 Thread Dave Anderson
- Original Message - Date: Tue, 16 Jun 2015 12:32:29 -0400 From: ander...@redhat.com To: crash-utility@redhat.com Subject: Re: [Crash-utility] [PATCH] Fix memory leaks in dump_mem_map when SPARSEMEM is enabled - Original Message - Date: Tue, 16 Jun

Re: [Crash-utility] [PATCH] Fix memory leaks in dump_mem_map when SPARSEMEM is enabled

2015-06-16 Thread Dave Anderson
- Original Message - Date: Tue, 16 Jun 2015 11:14:51 -0400 From: ander...@redhat.com To: crash-utility@redhat.com Subject: Re: [Crash-utility] [PATCH] Fix memory leaks in dump_mem_map when SPARSEMEM is enabled Hi Oliver, Since it's a GETBUF() call, it's not really

Re: [Crash-utility] [PATCH] files: support dump file page cache

2015-06-15 Thread Dave Anderson
- Original Message - Sorry,Ijust realized that my email setting is not correct. Resend patch file here. Dave, This patch add -M and -m option for file commands, which allow to dump page cache for a file. Please review and let me know your comments. Thanks! Hello

Re: [Crash-utility] [PATCH] s390x: fix interrupt stack address calculation

2015-06-09 Thread Dave Anderson
- Original Message - On Mon, 8 Jun 2015 14:13:17 -0400 (EDT) Dave Anderson ander...@redhat.com wrote: - Original Message - The kernel commit 2f859d0dad8 (s390/smp: reduce size of struct pcpu) for linux-4.0 removed the async_stack and panic_stack members from

Re: [Crash-utility] [PATCH] s390x: fix interrupt stack address calculation

2015-06-08 Thread Dave Anderson
- Original Message - The kernel commit 2f859d0dad8 (s390/smp: reduce size of struct pcpu) for linux-4.0 removed the async_stack and panic_stack members from struct pcpu. So now the only option to find out the stack address is using struct lowcore (again). Unfortunately we don't

Re: [Crash-utility] RFE: add '-l' option to dmesg command

2015-05-30 Thread Dave Anderson
- Original Message - It would be useful to have the ability to dump out only certain log levels of the kernel log. I know dmesg has '-m' which prepends the log level and then you can always use some script logic but would it be easy to add another option in crash to do this

Re: [Crash-utility] Fix in bt for ARM64

2015-05-22 Thread Dave Anderson
: crash-utility-boun...@redhat.com [mailto:crash-utility-boun...@redhat.com] On Behalf Of Dave Anderson Sent: den 12 maj 2015 15:28 To: Discussion list for crash utility usage, maintenance and development Subject: Re: [Crash-utility] Fix in bt for ARM64 - Original Message - Thanks Dave

Re: [Crash-utility] right shift of the subtraction result

2015-05-21 Thread Dave Anderson
to the project above from the crash website for several years now, accessible from the Python scripts link at the bottom: http://people.redhat.com/anderson I'm aware of it, and know that it's useful to those that do use it. I don't speak python, and if I really need something that I can't get out

Re: [Crash-utility] [PATCH 1/1] Resend CLI list command, print deep structure members

2015-05-21 Thread Dave Anderson
- Original Message - Hi Dave, my bad. Since you've made some simplifications in my patch, I hope it's ok to make short patch. Hi Alex, This patch tests OK. I did make a few minor cosmetic changes, fixed the task command so that the -R flag remains optional, and added some

Re: [Crash-utility] right shift of the subtraction result

2015-05-20 Thread Dave Anderson
speak python, and if I really need something that I can't get out of the command set I find it easier to write something in C for the hidden test command, or by a quick-and-dirty extension module. Dave Thanks, On Wednesday, May 20, 2015 11:17 AM, Dave Anderson ander...@redhat.com

Re: [Crash-utility] [PATCH 1/1] Resend CLI list command, print deep structure members

2015-05-19 Thread Dave Anderson
:14:49PM -0400, Dave Anderson wrote: I've run into three problems dealing with embedded arrays. First, should array elements inside an embedded structure be selectable? For example, the task_struct has an embedded task_rss_stat structure: . crash task -R rss_stat.count[1] PID

Re: [Crash-utility] [PATCH 1/1] Resend CLI list command, print deep structure members

2015-05-19 Thread Dave Anderson
- Original Message - Hi Dave, my bad. Since you've made some simplifications in my patch, I hope it's ok to make short patch. Hi Alex, I've run into three problems dealing with embedded arrays. First, should array elements inside an embedded structure be selectable? For

Re: [Crash-utility] [PATCH 1/1] Resend CLI list command, print deep structure members

2015-05-14 Thread Dave Anderson
- Original Message - Hi Dave, thank you for the comments. Here is the fixed patch. Best, Alexandr Hi Alexandr, I actually haven't studied the meat of parse_for_member_new() yet, but in testing the patch, I've come up with a few issues that still need addressing. Unlike what

Re: [Crash-utility] [PATCH 1/1] Resend CLI list command, print deep structure members

2015-05-14 Thread Dave Anderson
- Original Message - Great -- and you don't have to bother updating the help task, help list and help tree descriptions. Let's just get the patch working first, and then I'll take care of the documentation. And of course the most important one, help struct. Thanks, Dave --

Re: [Crash-utility] [PATCH 1/1] Resend CLI list command, print deep structure members

2015-05-14 Thread Dave Anderson
- Original Message - Hi Dave, I'm sorry for my poor Inglish :) I actually haven't studied the meat of parse_for_member_new() yet, but in testing the patch, I've come up with a few issues that still need addressing. Could you please clarify your last point? If you mean the

Re: [Crash-utility] [PATCH] MIPS: support getting regs from kdump dumpfiles

2015-05-13 Thread Dave Anderson
- Original Message - Add support for using the notes in MIPS' kdump compressed format dumpfiles. Hi Rabin, I've downloaded the sample dumpfiles, tested the patch, and queued it for crash-7.1.1:

Re: [Crash-utility] [PATCH v2] kmem: Introduce -m option

2015-05-12 Thread Dave Anderson
Aaron Tomlin and I have been collaborating offline/in-house with respect to this patch, and we've finally come up with an implementation that is queued for crash-7.1.1: https://github.com/crash-utility/crash/commit/a8e7fc1e580122fac032c80f789026dfe3f1fc4d - Implemented a new kmem -m option

Re: [Crash-utility] [PATCH 1/1] Resend CLI list command, print deep structure members

2015-05-12 Thread Dave Anderson
Hi Alex, This patch certainly looks promising. I've have only just begun looking at the patch, and based upon a few initial tests, I like the functionality a lot. Nice job! However, for starters, there are a few crash utility conventions that should be followed. I'm sorry if they seem

Re: [Crash-utility] Fix in bt for ARM64

2015-05-12 Thread Dave Anderson
sonymobile.com -Original Message- From: crash-utility-boun...@redhat.com [mailto:crash-utility-boun...@redhat.com] On Behalf Of Dave Anderson Sent: den 11 maj 2015 17:49 To: Discussion list for crash utility usage, maintenance and development Subject: Re: [Crash-utility] Fix in bt

Re: [Crash-utility] Fix in bt for ARM64

2015-05-11 Thread Dave Anderson
- Original Message - Hi Dave I found an ARM64 problem for bt when a function belongs to a module. Printout before fix given below: #16 [ffc0be96f8d0] __this_module at ffbffc15a2f8 [wlan] #17 [ffc0be96f9b0] __this_module at ffbffc161b18 [wlan] #18

Re: [Crash-utility] Value of

2015-04-30 Thread Dave Anderson
- Original Message - Hi Dave I was looking in the file arm64.c at function arm64_translate_pte and saw the line: if (!page_present (pte PTE_FILE)) { I also saw that there are two versions of the value PTE_FILE (see also defs.h) and the following code is included in

Re: [Crash-utility] crash: vz extension for OpenVZ kernels

2015-04-30 Thread Dave Anderson
- Original Message - Dear Dave, I've prepared vz crash extension with commands useful for troubleshooting of OpenVZ kernel crashes. Could you please review the patch and advise how it's better to distribute this extension. vz extension uses openVZ-specific kernel structures

Re: [Crash-utility] [PATCH] cmd_ps message cleanup

2015-04-30 Thread Dave Anderson
- Original Message - ps -L no longer exists Signed-off-by: Vasily Averin v...@parallels.com --- task.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/task.c b/task.c index c875bb9..bc7911b 100644 --- a/task.c +++ b/task.c @@ -2843,7 +2843,7 @@

Re: [Crash-utility] crash: vz extension for OpenVZ kernels

2015-04-30 Thread Dave Anderson
- Original Message - On 30.04.2015 18:02, Dave Anderson wrote: I've prepared vz crash extension with commands useful for troubleshooting of OpenVZ kernel crashes. Could you please review the patch and advise how it's better to distribute this extension. I no longer accept

Re: [Crash-utility] [PATCH 1/1] CLI list command, print deep structure members

2015-04-29 Thread Dave Anderson
- Original Message - On Tue, Apr 28, 2015 at 09:44:43AM -0400, Dave Anderson wrote: - Original Message - - Original Message - Hi Dave, I found it useful to be able listing structure's fields which are resided deeper than the first level

Re: [Crash-utility] [PATCH 1/1] CLI list command, print deep structure members

2015-04-28 Thread Dave Anderson
- Original Message - - Original Message - Hi Dave, I found it useful to be able listing structure's fields which are resided deeper than the first level: crash list super_block.s_list -s

Re: [Crash-utility] [PATCH] xen: Handle rename of dom0 symbol in Xen 4.5.0

2015-04-28 Thread Dave Anderson
- Original Message - Has been replaced by hardware_domain. Xen tracking: commit c86ccbf0b7976ac0093bef4e4e43005771c0f829 Author: Daniel De Graaf dgde...@tycho.nsa.gov Date: Fri Apr 11 11:20:55 2014 +0200 rename dom0 to hardware_domain Signed-off-by: Don Slutz

Re: [Crash-utility] [PATCH 1/1] CLI list command, print deep structure members

2015-04-28 Thread Dave Anderson
- Original Message - Hi Dave, I found it useful to be able listing structure's fields which are resided deeper than the first level: crash list super_block.s_list -s super_block.s_id,s_dquot.info[1].dqi_dirty_list,s_dquot.dqonoff_mutex.count.counter -H 0xc0a9c800 de805c00

Re: [Crash-utility] [PATCH] GET_TIMESTAMP is pc-flags2 not kt-flags2

2015-04-28 Thread Dave Anderson
- Original Message - Without this change REMOTE_DAEMON and GET_TIMESTAMP shared one bit. --- defs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/defs.h b/defs.h index d2a8215..3f4b648 100644 --- a/defs.h +++ b/defs.h @@ -518,6 +518,7 @@ struct

Re: [Crash-utility] [PATCH] Speed up usage of a flat makedumpfile vmcore.

2015-04-28 Thread Dave Anderson
- Original Message - Using a bubble sort is slow, switch to an insertion sort. bubble sort: real3m45.168s insertion sort: real0m3.164s Signed-off-by: Don Slutz dsl...@verizon.com --- I do have a big (32G sized file, that gzipped is 357M). let me know if you want

Re: [Crash-utility] [PATCH] GET_TIMESTAMP is pc-flags2 not kt-flags2

2015-04-28 Thread Dave Anderson
- Original Message - On 04/28/15 11:27, Dave Anderson wrote: - Original Message - Without this change REMOTE_DAEMON and GET_TIMESTAMP shared one bit. --- defs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/defs.h b/defs.h index

Re: [Crash-utility] [PATCH] GET_TIMESTAMP is pc-flags2 not kt-flags2

2015-04-28 Thread Dave Anderson
- Original Message - On 04/28/15 14:09, Dave Anderson wrote: - Original Message - On 04/28/15 11:27, Dave Anderson wrote: - Original Message - Without this change REMOTE_DAEMON and GET_TIMESTAMP shared one bit. --- defs.h | 4 ++-- 1 file

Re: [Crash-utility] [PATCH 2/2] Fix for memory leaks

2015-04-27 Thread Dave Anderson
- Original Message - Without this patch, the storage reserved with the call to strdup won't be freed. Did you even test this patch? It causes this: $ patch -p1 /tmp/leaks.patch patching file configure.c Hunk #1 succeeded at 768 (offset 64 lines). Hunk #2 succeeded at 1723

Re: [Crash-utility] [PATCH 1/2] Fix typo and delete doubled words in manual

2015-04-27 Thread Dave Anderson
- Original Message - * s/repetetively/repetitively/g Signed-off-by: Wei,Jiangang weijg.f...@cn.fujitsu.com I broke this into a couple patches, both of which are queued for crash-7.1.1: https://github.com/crash-utility/crash/commit/117284469ad9c01ddeb7150b9d43c4af57dc7004

Re: [Crash-utility] [PATCH 1/6] - [PATCH 5/6] MIPS:

2015-04-24 Thread Dave Anderson
Hi Rabin, All 5 patches look good -- queued for crash-7.1.1: https://github.com/crash-utility/crash/commit/def93c22f96f4af1990db8114ae0c929b548cfbc Thanks, Dave -- Crash-utility mailing list Crash-utility@redhat.com https://www.redhat.com/mailman/listinfo/crash-utility

Re: [Crash-utility] [PATCH 6/6] Build extensions with -g

2015-04-24 Thread Dave Anderson
- Original Message - We already build crash with -g, let's build extensions with that too, so that we can debug them with gdb. --- extensions/Makefile |8 1 file changed, 4 insertions(+), 4 deletions(-) I also added -g to snap.mk to cover all of the built-in extension

Re: [Crash-utility] [PATCH] kmem: introduce -m option

2015-04-24 Thread Dave Anderson
- Original Message - The dump_mem_map() function displays basic data about each entry in the mem_map[] array, or if an address is specified, just the mem_map[] entry for that address. This patch introduces the -m option to be used with 'kmem -p' exclusively. When used with -p, a

Re: [Crash-utility] [PATCH] kmem: Show a page's _mapcount value in dump_mem_map()

2015-04-14 Thread Dave Anderson
- Original Message - - Original Message - On Fri 2015-04-10 14:47 -0400, Dave Anderson wrote: Maybe an option could be added for use with kmem -p only, that supplies a comma-separated list of desired fields, i.e., something like: crash kmem -p -m member1

Re: [Crash-utility] [PATCH] kmem: Show a page's _mapcount value in dump_mem_map()

2015-04-13 Thread Dave Anderson
- Original Message - On Fri 2015-04-10 14:47 -0400, Dave Anderson wrote: Maybe an option could be added for use with kmem -p only, that supplies a comma-separated list of desired fields, i.e., something like: crash kmem -p -m member1,member2,member3 At least then you

Re: [Crash-utility] patch to add vmss memory regions support

2015-03-31 Thread Dave Anderson
: https://github.com/crash-utility/crash/commit/1ed90b28af6dbb74fd785e36502f16a8f156e3b3 Thanks, Dave rgds, Dyno On 3/30/15 12:14 PM, Dave Anderson wrote: - Original Message - Dave, I've removed the assert now. please find the updated patch in attachment

Re: [Crash-utility] patch to add vmss memory regions support

2015-03-30 Thread Dave Anderson
up the error message handling, we can get this patch checked in. Thanks, Dave On 3/27/15 11:05 AM, Dave Anderson wrote: Dyno, I've got the sample multi-region dumpfile -- thanks for that. This latest patch tests OK on all three dumpfiles. But can you please remove the remaining

Re: [Crash-utility] patch to add vmss memory regions support

2015-03-27 Thread Dave Anderson
= 0x04 MainMemKnownZero = BLOCK, pos=0x11447, size=0x8000 rgds, Dyno On 3/26/15 1:12 PM, Dave Anderson wrote: - Original Message - Dave, updated the patch and please review. thanks. - the page_size/page_shift problem. - change

Re: [Crash-utility] patch to add vmss memory regions support

2015-03-26 Thread Dave Anderson
- Original Message - Dave, updated the patch and please review. thanks. - the page_size/page_shift problem. - change type cast to union. - the read_vmware_vmss() regression. rgds, Dyno Dyno, Since you cannot make any additional sample vmss2core-generated dumpfiles

Re: [Crash-utility] patch to add vmss memory regions support

2015-03-24 Thread Dave Anderson
Dyno, Can you re-post this path so that it applies cleanly to the current git repository? This is what happens: $ git clone https://github.com/crash-utility/crash.git Cloning into 'crash'... remote: Counting objects: 811, done. remote: Total 811 (delta 0), reused 0 (delta 0), pack-reused

Re: [Crash-utility] patch to add vmss memory regions support

2015-03-24 Thread Dave Anderson
) { - return 4096; + return PAGE_SIZE; } which is pretty much the wrong way to do it both before and after. I'm not sure how you want to handle it. Dave On 3/24/15 10:00 AM, Dyno Hongjun Fu wrote: -- Forwarded message -- From: Dave Anderson ander...@redhat.com

Re: [Crash-utility] patch to add vmss memory regions support

2015-03-24 Thread Dave Anderson
Hongjun Fu wrote: -- Forwarded message -- From: Dave Anderson ander...@redhat.com Date: Tue, Mar 24, 2015 at 7:17 AM Subject: Re: [Crash-utility] patch to add vmss memory regions support To: Discussion list for crash utility usage, maintenance and development crash

Re: [Crash-utility] [PATCH] xen: support changed item in struct domain

2015-03-11 Thread Dave Anderson
- Original Message - Hi, with xen version 4.2.5 in struct domain the item is_paused_by_controller got changed to controller_pause_count and hence crash doesn't work on newer xen environments. This patch allows to support older and newer xen versions. Dietmar. Queued for

Re: [Crash-utility] Crash problems with Xen

2015-03-10 Thread Dave Anderson
- Original Message - Hi, for me crash failed to debug xen environments with: crash: invalid structure member offset: domain_is_paused_by_controller FILE: xen_hyper.c LINE: 1255 FUNCTION: xen_hyper_store_domain_context() [/usr/bin/crash] error trace: 546170 =

Re: [Crash-utility] crash: pipe operation failed

2015-02-25 Thread Dave Anderson
- Original Message - - Original Message - Hi Anderson, I wonder if you are aware of this pipe failure and is it worth to be fixed? if `|` is in quote, crash should not try to interpret it, right? crash ps |awk 'NR = 10 || $5 ~ /U/'crash: pipe operation

Re: [Crash-utility] crash: pipe operation failed

2015-02-25 Thread Dave Anderson
- Original Message - On Wednesday, February 25, 2015 8:36 AM, Dave Anderson ander...@redhat.com wrote: Hi Derek, A fix is queued for crash-7.1.1: https://github.com/crash-utility/crash/commit/fe6679f131728bb368242a6eb0b433f5b69942f0 That's very nice! Do you also

Re: [Crash-utility] crash: pipe operation failed

2015-02-20 Thread Dave Anderson
- Original Message - Hi Anderson, I wonder if you are aware of this pipe failure and is it worth to be fixed? if `|` is in quote, crash should not try to interpret it, right? crash ps |awk 'NR = 10 || $5 ~ /U/'crash: pipe operation failed crash: pipe operation failed crash

Re: [Crash-utility] [PATCH] sadump: Support more than 16TB physical memory space

2015-02-20 Thread Dave Anderson
From d996cc4dd34ae62f1be790ad0e6921601ace17bc Mon Sep 17 00:00:00 2001 From: HATAYAMA Daisuke d.hatay...@jp.fujitsu.com Date: Mon, 2 Feb 2015 11:29:17 +0900 Subject: [PATCH] sadump: Support more than 16TB physical memory space This patch makes sadump format support more than 16TB physical memory

Re: [Crash-utility] [PATCH] Remove lkcd_speedo() output spinner

2015-02-13 Thread Dave Anderson
- Original Message - This patch removes the lkcd_speedo() function and its use. The lkcd_speedo() function produces a 'spinner' in output when crash is busy processing kernel crash dump files. The spinner makes the output of crash commands unpredictable and complicates the parsing

Re: [Crash-utility] [PATCH 0/5] new options for memory debug commands

2015-02-12 Thread Dave Anderson
- Original Message - search: -f struct-page.flags-mask When searching kernel memory, crash walks through all identity mapping space which includes all physical memory. Nowadays we have machines that equipped with more than 256G memory, it takes a long time

Re: [Crash-utility] [PATCH] RESEND: Suppress lkcd_speedo() spinner in redirected output

2015-02-12 Thread Dave Anderson
- Original Message - Resent using a benign email client When redirecting output to a file or script the 'spinner' written by the lkcd_speedo() function complicates parsing output. Currently the spinner is only suppressed if crash is run with the '-s' option or the command 'set

[Crash-utility] [ANNOUNCE] crash version 7.1.0 is available

2015-02-06 Thread Dave Anderson
Download from: http://people.redhat.com/anderson or https://github.com/crash-utility/crash/releases The master branch serves as a development branch that will contain all patches that are queued for the next release: $ git clone git://github.com/crash-utility

Re: [Crash-utility] [PATCH V2] take Hardware Error kernel pointer bug as separate panicmsg

2015-02-05 Thread Dave Anderson
- Original Message - There are just too many kinds of panic types are categorized under the same Oops: , makes this field really ambiguous and not so useful PANIC: Oops: [#1] SMP (check log for details) this patch separated 3 kinds of panicmsg out, as the most

Re: [Crash-utility] [PATCH] Fix trace extension for v3.15+

2015-02-05 Thread Dave Anderson
- Original Message - Hello Rabin, This patch looks good to me. Reviewed-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Rabin, thanks for the patch, and Qiao, thanks for the quick review. Queued for crash-7.1.0:

Re: [Crash-utility] [PATCH] Support extensions for MIPS

2015-02-05 Thread Dave Anderson
- Original Message - Add appropriate checks for MIPS to is_shared_object() so that extensions work. --- symbols.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/symbols.c b/symbols.c index 59312e6..c3883f0 100644 --- a/symbols.c +++ b/symbols.c @@

Re: [Crash-utility] [PATCH 0/5] new options for memory debug commands

2015-02-05 Thread Dave Anderson
Hello Yu, I am going to defer the review/testing of this patchset until after crash-7.1.0 has been released, which I hopefully will get done tomorrow. Thanks, Dave - Original Message - search: -f struct-page.flags-mask When searching kernel memory, crash walks through

Re: [Crash-utility] patch to read vmware vmss file

2015-02-05 Thread Dave Anderson
- Original Message - Dave, thanks for the review and here is the new patch. changes from the last version. * add GPL license header * remove stdbool.h * complete function declaration * add header file dependency in Makefile. * fit VMWARE_VMSS to flag. addition to the

Re: [Crash-utility] [PATCH V2] take Hardware Error kernel pointer bug as separate panicmsg

2015-02-04 Thread Dave Anderson
- Original Message - On Tuesday, February 3, 2015 12:53 PM, Dave Anderson ander...@redhat.com wrote: I'll move the hardware error check to the bottom, and only use it if there are no other relevant strings found, and then re-test that configuration. how about match

Re: [Crash-utility] patch to read vmware vmss file

2015-02-04 Thread Dave Anderson
- Original Message - Dave, thanks for the review and here is the new patch. changes from the last version. * add GPL license header * remove stdbool.h * complete function declaration * add header file dependency in Makefile. * fit VMWARE_VMSS to flag. OK thanks. So

Re: [Crash-utility] [PATCH] take Hardware Error kernel pointer bug as separate panicmsg

2015-02-03 Thread Dave Anderson
Derek, I don't understand what you're expecting me to do -- pick one of the 4 patches? Can you please repost just one patch? And this part clearly cannot be applied, because the SysRq : string would also be displayed by all of the possible sysrq letters: + while (!msg_found fgets(buf,

Re: [Crash-utility] patch to read vmware vmss file

2015-02-03 Thread Dave Anderson
- Original Message - hi, vmss file is VMware virtual machine snapshot file and contains all the necessary memory dump that crash requires. there is public available parse to read the format. https://code.google.com/p/vmsnparser/ there is vmss2core (

Re: [Crash-utility] patch to read vmware vmss file

2015-02-03 Thread Dave Anderson
Hello Dyno, A couple more items to address. In the Makefile, the vmware_vmss.c build does not have a dependency on vmware_vmss.h: VMWARE_HFILES=vmware_vmss.h vmware_vmss.o: ${GENERIC_HFILES} ${REDHAT_HFILES} vmware_vmss.c ${CC} -c ${CRASH_CFLAGS} vmware_vmss.c

Re: [Crash-utility] [PATCH V2] take Hardware Error kernel pointer bug as separate panicmsg

2015-02-03 Thread Dave Anderson
I ran a test on ~200 dumpfiles, and for the most part, the patch is quite useful in replacing the Oops message with something more helpful. However, the [Hardware Error] check should be the very last thing checked. Actually, I'm not even sure whether it should be checked at all, because there

Re: [Crash-utility] crash-7.0.9 vs. 7.0.8 on ARM - crashing

2015-01-30 Thread Dave Anderson
- Original Message - Hi, On 2015-01-30 08:26, Dave Anderson wrote: The pc-read_vmcoreinfo method is only initialized for ELF kdumps and compressed kdumps. So either a dummy function should be put in there that returns a NULL or arm_init() should check for its existence

Re: [Crash-utility] crash-7.0.9 vs. 7.0.8 on ARM - crashing

2015-01-30 Thread Dave Anderson
- Original Message - Hi, It looks like crash-7.0.9 is broken on ARM, while 7.0.8 works without any problems. I compiled both versions on my ARM target board exactly the same way, but 7.0.9 throws a core dump when invoked.[1] # CONFIG_ARM_LPAE is not set [1]

[Crash-utility] Fwd: crash-7.0.9 vs. 7.0.8 on ARM - crashing

2015-01-30 Thread Dave Anderson
- Forwarded Message - From: Robert Berger gm...@reliableembeddedsystems.com Cc: Robert Berger robert.ber...@reliableembeddedsystems.com, ander...@redhat.com Sent: Friday, January 30, 2015 4:02:01 AM Subject: crash-7.0.9 vs. 7.0.8 on ARM - crashing Hi, It looks like crash-7.0.9 is

Re: [Crash-utility] unwind not working on x86?

2015-01-28 Thread Dave Anderson
- Original Message - Hello I am trying to use both the unwind function on x86 in crash, and the fp extension. Both are not working for me. I did the following tests: (crash 7.0.9) crash/crash vmcore.201412161409 linux-3.2.64/vmlinux GNU gdb (GDB) 7.6 KERNEL:

Re: [Crash-utility] [PATCH] fix missing RT PRIO_ARRAY table with CONFIG_RT_GROUP_SCHED=n

2015-01-23 Thread Dave Anderson
- Original Message - On the kernel with CONFIG_RT_GROUP_SCHED=n, the RT PRIO_ARRAY table of runq command always empty, nevertheless exists rt_sched_class task. This cause to substract offset task_struct-rt - task_struct only if there is my_q member (ie. CONFIG_RT_GROUP_SCHED=y).

Re: [Crash-utility] [PATCH] fix missing RT PRIO_ARRAY table with CONFIG_RT_GROUP_SCHED=n

2015-01-23 Thread Dave Anderson
- Original Message - + if (VALID_MEMBER(task_struct_rt) + task_addr -= OFFSET(task_struct_rt); + else + task_addr -= (task_struct_run_list); I meant: + task_addr -=

Re: [Crash-utility] [PATCH] fix missing RT PRIO_ARRAY table with CONFIG_RT_GROUP_SCHED=n

2015-01-23 Thread Dave Anderson
- Original Message - On the kernel with CONFIG_RT_GROUP_SCHED=n, the RT PRIO_ARRAY table of runq command always empty, nevertheless exists rt_sched_class task. This cause to substract offset task_struct-rt - task_struct only if there is my_q member (ie. CONFIG_RT_GROUP_SCHED=y).

[Crash-utility] Fwd: [PATCH] crash: use %lu for counters

2015-01-22 Thread Dave Anderson
- Forwarded Message - From: Dave Anderson ander...@redhat.com To: Alexey Dobriyan adobri...@gmail.com Sent: Thursday, January 22, 2015 1:52:16 PM Subject: Re: [PATCH] crash: use %lu for counters - Original Message - These counters are unsigned long in kernel and positive

[Crash-utility] Fwd: [PATCH] crash: use %lu for counters

2015-01-22 Thread Dave Anderson
- Forwarded Message - From: Alexey Dobriyan adobri...@gmail.com To: Dave Anderson ander...@redhat.com Sent: Thursday, January 22, 2015 5:56:11 AM Subject: [PATCH] crash: use %lu for counters These counters are unsigned long in kernel and positive in principle. Seen during debugging OOM

Re: [Crash-utility] Small fix for pages_scanned value

2015-01-20 Thread Dave Anderson
- Original Message - Hi Dave, there seems to be typo while printing pages_scanned value - signed output for unsigned variable. Patch: --- crash-7.0.9.orig/memory.c 2014-11-13 15:33:40.0 -0500 +++ crash-7.0.9/memory.c 2015-01-20 05:19:07.0 -0500 @@ -15776,7

Re: [Crash-utility] Small fix for pages_scanned value

2015-01-20 Thread Dave Anderson
- Original Message - - Original Message - Hi Dave, there seems to be typo while printing pages_scanned value - signed output for unsigned variable. Patch: --- crash-7.0.9.orig/memory.c 2014-11-13 15:33:40.0 -0500 +++ crash-7.0.9/memory.c

Re: [Crash-utility] cannot find stack info on ppc64le (call out to all IBM'ers on this list)

2015-01-20 Thread Dave Anderson
- Original Message - Thanks so much for your reply, Dave. On Mon, Jan 19, 2015 at 03:33:41PM -0500, Dave Anderson wrote: Han, This is much worse than I thought. When you said sometimes, you must mean all of the time with respect to the active tasks? Because that's

Re: [Crash-utility] cannot find stack info on ppc64le

2015-01-19 Thread Dave Anderson
- Original Message - - Original Message - Hello, I just noticed that on ppc64le, sometimes bt cannot find the stack info of current process. For example, there is a vmcore captured by kdump on a ppc64le system, which running with a kernel version 3.10. The vmcore

Re: [Crash-utility] cannot find stack info on ppc64le (call out to all IBM'ers on this list)

2015-01-19 Thread Dave Anderson
Han, This is much worse than I thought. When you said sometimes, you must mean all of the time with respect to the active tasks? Because that's what I see here. I provisioned a ppc64le machine, set up kdump to create a compressed kdump, and crashed the machine with sysrq-c. This is what I

Re: [Crash-utility] [PATCH] MIPS: fix native build

2015-01-14 Thread Dave Anderson
That was easy... Queued for crash-7.1.0: https://github.com/crash-utility/crash/commit/46de58d06fcae6c68cc95b053b8b5e9a7da81f6b Thanks, Dave - Original Message - I've now managed to tested HOST==TARGET MIPS builds of crash (with Debian running on top of QEMU's full-system MIPS

Re: [Crash-utility] What is the unit for 'last_arrival' in 'task_struct.sched_info.last_arrival'.

2015-01-13 Thread Dave Anderson
- Original Message - Hi, What is the unit for 'last_arrival' in 'task_struct.sched_info.last_arrival' ? I see that this value is used by 'ps -l' crash-utility command. -l display the task last_run or timestamp value, whichever applies, of selected, or all, tasks; the list is

Re: [Crash-utility] [PATCH 0/4] MIPS support

2015-01-13 Thread Dave Anderson
- Original Message - And perhaps it would possible for you to rework configure.c and whatever else to get it to work for big-endian MIPS as well? (albeit with the make target=MIPS) (albeit *without* the make target=MIPS) -- Crash-utility mailing list Crash-utility@redhat.com

Re: [Crash-utility] [PATCH 0/4] MIPS support

2015-01-13 Thread Dave Anderson
, or mips, or what? Thanks again, Dave - Original Message - On Mon, Jan 12, 2015 at 11:00:08AM -0500, Dave Anderson wrote: I don't know what the real-world usage is with respect to little-endian vs. big-endian 32-bit MIPS, but you got here first. And in the future

Re: [Crash-utility] [PATCH 0/4] MIPS support

2015-01-12 Thread Dave Anderson
- Original Message - On Mon, Jan 12, 2015 at 11:00:08AM -0500, Dave Anderson wrote: I don't know what the real-world usage is with respect to little-endian vs. big-endian 32-bit MIPS, but you got here first. And in the future, it should be simple enough to support big-endian MIPS

Re: [Crash-utility] [PATCH 0/4] MIPS support

2015-01-12 Thread Dave Anderson
- Original Message - This adds support for analyzing dumps from 32-bit MIPS. I've uploaded some sample dumps generated from the QEMU MIPS Malta machine (little-endian) at the following location: https://drive.google.com/folderview?id=0B4tMLbMvJ-l6R3J4LWJFc1k0eFU Rabin Vincent

Re: [Crash-utility] help -D: Display qemu note of qemu mem dump compressed

2015-01-06 Thread Dave Anderson
- Original Message - - Original Message - Hello Dave, The patch is used to display qemu note of compressed qemu memory dump. It is against the newest git. Please check. This is good -- I'm adding a few small display changes and will test the patch overnight.

Re: [Crash-utility] crash: invalid kernel virtual address: 0 type: memory section

2015-01-05 Thread Dave Anderson
- Original Message - On Mon, Jan 5, 2015 at 6:49 PM, Dave Anderson ander...@redhat.com wrote: Just for sanity's sake, try this: $ ./crash --minimal ../ddeb/usr/lib/debug/boot/vmlinux-3.13.0-39-generic ../dump.201412280256 and see if you can read the linux_banner

Re: [Crash-utility] crash: invalid kernel virtual address: 0 type: memory section

2015-01-05 Thread Dave Anderson
Our last two messages crossed -- you have found the problem... Dave - Original Message - On Mon, Jan 5, 2015 at 7:02 PM, Ilya Dryomov idryo...@redhat.com wrote: On Mon, Jan 5, 2015 at 6:49 PM, Dave Anderson ander...@redhat.com wrote: Just for sanity's sake, try

Re: [Crash-utility] help -D: Display qemu note of qemu mem dump compressed

2015-01-05 Thread Dave Anderson
- Original Message - Hello Dave, The patch is used to display qemu note of compressed qemu memory dump. It is against the newest git. Please check. This is good -- I'm adding a few small display changes and will test the patch overnight. Thanks, Dave -- Crash-utility mailing

Re: [Crash-utility] Make note information human readable when help -D

2015-01-05 Thread Dave Anderson
- Original Message - Hello Dave, I found something is missing in the committed patch. In dump_Elf64_Nhdr, qemu note of X86 is not available to call display_ELF_note. The process is like below: if (BITS32() type == NT_PRSTATUS) display_ELF_note else if

Re: [Crash-utility] crash: invalid kernel virtual address: 0 type: memory section

2015-01-05 Thread Dave Anderson
- Original Message - Hello, I have a couple dumps generated on Ubuntu Trusty LTS (3.13.0-39-generic kernel) which crash fails on. $ ./crash ../ddeb/usr/lib/debug/boot/vmlinux-3.13.0-39-generic ../dump.201412280256 crash 7.0.9 Copyright (C) 2002-2014 Red Hat, Inc. Copyright

Re: [Crash-utility] crash: invalid kernel virtual address: 0 type: memory section

2015-01-05 Thread Dave Anderson
Just for sanity's sake, try this: $ ./crash --minimal ../ddeb/usr/lib/debug/boot/vmlinux-3.13.0-39-generic ../dump.201412280256 and see if you can read the linux_banner string successfully. For example, using my sample 3.13 kernel: $ crash --minimal

Re: [Crash-utility] Make note information human readable when help -D

2014-12-22 Thread Dave Anderson
On 12/18/2014 05:07 AM, Dave Anderson wrote: OK thanks -- although further testing showed that the patch needed a bit more work in netdump.c to prevent calling display_ELF_note() if: (1) the architecture is not x86 or x86-64 (2) the note type is not NT_PRSTATUS or QEMU, because it would

Re: [Crash-utility] [Crash-utility PATCH] crash: arm: LPAE: fix bugs when translating address

2014-12-18 Thread Dave Anderson
- Original Message - For virtual address with idmap, we just use VTOP to do the translate. So we should not use one way for arm and LPAE enabled arm. This bugs occurs when the phys_base exceeds 4G. So we could not meet this bugs at most case. But for keystone platfrom, whose

<    4   5   6   7   8   9   10   11   12   13   >