Re: [Crash-utility] Faster iteration on list of struct.field

2020-02-07 Thread Dominique Martinet
Dave Anderson wrote on Fri, Feb 07, 2020: > > Actually, for do_datatype_addr(), I'm pretty sure we never use the > > member_offset at all -- I just replaced member_to_datatype() by > > something that just assigned the member to dm->member and things just > > work for anything I could try (struct

Re: [Crash-utility] Faster iteration on list of struct.field

2020-02-07 Thread Dave Anderson
- Original Message - > Dave Anderson wrote on Fri, Feb 07, 2020: > > > Following up with patch, with a couple of remarks: > > > - I had to change member_to_datatype() to use datatype_info() directly > > > instead of MEMBER_OFFSET(), to fill dm->member_size. I'm not sure if > > > this

Re: [Crash-utility] Faster iteration on list of struct.field

2020-02-07 Thread Dominique Martinet
Dave Anderson wrote on Fri, Feb 07, 2020: > > Following up with patch, with a couple of remarks: > > - I had to change member_to_datatype() to use datatype_info() directly > > instead of MEMBER_OFFSET(), to fill dm->member_size. I'm not sure if > > this will have any side effects, but things like

Re: [Crash-utility] Faster iteration on list of struct.field

2020-02-07 Thread Dave Anderson
- Original Message - > Dave Anderson wrote on Thu, Feb 06, 2020: > > Right, the time-consumer is the call into gdb to get the structure member > > details. > > > > I'm not following what you mean by "making 'datatype_member' static ...", > > but > > off the top of my head, I was

Re: [Crash-utility] Faster iteration on list of struct.field

2020-02-06 Thread Dominique Martinet
Dave Anderson wrote on Thu, Feb 06, 2020: > Right, the time-consumer is the call into gdb to get the structure member > details. > > I'm not following what you mean by "making 'datatype_member' static ...", but > off the top of my head, I was thinking of adding a "tmp_offset" and "tmp_size" >

Re: [Crash-utility] Faster iteration on list of struct.field

2020-02-06 Thread Dave Anderson
- Original Message - > Dave Anderson wrote on Wed, Feb 05, 2020: > > > What might make sense is to use the "struct -r" option, which does a raw > > > memory dump of a data structure. But for a reason I do not recall, it > > > prevents that option from being used with a

Re: [Crash-utility] Faster iteration on list of struct.field

2020-02-05 Thread Dominique Martinet
Dave Anderson wrote on Wed, Feb 05, 2020: > > What might make sense is to use the "struct -r" option, which does a raw > > memory dump of a data structure. But for a reason I do not recall, it > > prevents that option from being used with a "struct_name.field" argument. > > (see line 6628 of

Re: [Crash-utility] Faster iteration on list of struct.field

2020-02-05 Thread Dave Anderson
- Original Message - > > > - Original Message - > > Hi, > > > > I often find myself dumping a bunch of addresses to files to iterate > > with 'struct_name.field < file_with_addresses', but that is horribly > > slow for large number of iterations. > > > > `help list` comment

Re: [Crash-utility] Faster iteration on list of struct.field

2020-02-05 Thread Dave Anderson
- Original Message - > Hi, > > I often find myself dumping a bunch of addresses to files to iterate > with 'struct_name.field < file_with_addresses', but that is horribly > slow for large number of iterations. > > `help list` comment for -S vs. -s made me try to use `rd` instead, >

[Crash-utility] Faster iteration on list of struct.field

2020-02-05 Thread Dominique Martinet
Hi, I often find myself dumping a bunch of addresses to files to iterate with 'struct_name.field < file_with_addresses', but that is horribly slow for large number of iterations. `help list` comment for -S vs. -s made me try to use `rd` instead, e.g. get offset manually from `struct -o` then use