kernels which have CONFIG_HAVE_ARCH_PREL32_RELOCATIONS will now store
module symbol values relative to themselves since linux kernel's commit
7290d580957 ("module: use relative references for __ksymtab entries")
Do the lookup one way or another depending on the kernel's kernel_symbol
struct, the
Cheers,
--
Dominique Martinet | Asmadeus
--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
Dave Anderson wrote on Mon, Nov 05, 2018:
> > 4.20-rc1 was not released yet so this isn't surprising :)
> > It came out just this weekend, should probably hit rawhide soon.
>
> Yeah, on Friday the guy in the cube next to me was working with a
> roll-your-own
> kernel from the latest upstream git
radix trees got replaced with xarrays in 4.20-rc1's f8d5d0cc145
("xarray: Add definition of struct xarray") and 01959dfe77 ("xarray:
Define struct xa_node")
Attempt to detect and support this.
---
Dave Anderson wrote on Tue, Oct 30, 2018:
> Thanks for the heads-up -- this is a critical change
Sean Fu wrote on Thu, Oct 11, 2018:
> Your code is different from mine. The following is from my task.c:
>
> 436 if (VALID_SIZE(task_union) && (SIZE(task_union) !=
> STACKSIZE())) {
> 437 error(WARNING, "\nnon-standard stack size: %ld\n",
> 438
haven't thought of, I only grepped
in a recent kernel)
--
Dominique Martinet
--
Crash-utility mailing list
Crash-utility@redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility
Dave Anderson wrote on Wed, Feb 05, 2020:
> > What might make sense is to use the "struct -r" option, which does a raw
> > memory dump of a data structure. But for a reason I do not recall, it
> > prevents that option from being used with a "struct_name.field" argument.
> > (see line 6628 of
---
symbols.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/symbols.c b/symbols.c
index f04e8b5..f030179 100644
--- a/symbols.c
+++ b/symbols.c
@@ -6617,17 +6617,17 @@ do_datatype_addr(struct datatype_member *dm, ulong
addr, int count,
i
Dave Anderson wrote on Thu, Feb 06, 2020:
> Right, the time-consumer is the call into gdb to get the structure member
> details.
>
> I'm not following what you mean by "making 'datatype_member' static ...", but
> off the top of my head, I was thinking of adding a "tmp_offset" and "tmp_size"
>
Dave Anderson wrote on Fri, Feb 07, 2020:
> > Following up with patch, with a couple of remarks:
> > - I had to change member_to_datatype() to use datatype_info() directly
> > instead of MEMBER_OFFSET(), to fill dm->member_size. I'm not sure if
> > this will have any side effects, but things like
Hi,
I often find myself dumping a bunch of addresses to files to iterate
with 'struct_name.field < file_with_addresses', but that is horribly
slow for large number of iterations.
`help list` comment for -S vs. -s made me try to use `rd` instead,
e.g. get offset manually from `struct -o` then use
Dave Anderson wrote on Fri, Feb 07, 2020:
> > Actually, for do_datatype_addr(), I'm pretty sure we never use the
> > member_offset at all -- I just replaced member_to_datatype() by
> > something that just assigned the member to dm->member and things just
> > work for anything I could try (struct
Using struct -r allows much faster execution when iterating through a file;
on 3909 elements struct struct.member takes 192s vs. 3s with -r
---
Sorry for the delay, here's another take at allowing struct -r with a
specific field specified.
I didn't post that v2 back in Feb because I wasn't
Hi Dave,
Dave Anderson wrote on Wed, Apr 01, 2020:
> > I didn't post that v2 back in Feb because I wasn't totally happy with
> > it; I can't say I now am but might as well get your take on it...
>
> What part of this patch aren't you happy about?
It's mostly style really - I don't like that
Previously, calling raw_data_dump() with e.g. len 4 on 64bit systems
would dump 8 bytes anyway, making it hard to tell what one wants to see.
For example, with task_struct.rt_priority a uint32.
before patch:
crash> struct -r task_struct.rt_priority 8d9b36186180
8d9b361861dc:
Dave Anderson wrote on Thu, Apr 02, 2020:
> Yes, let's do that -- queued for crash-7.2.9:
>
>
> https://github.com/crash-utility/crash/commit/8c28b5625505241d80ec5162f58ccc563e5e59f9
Thanks!
Checked both commits, small wording difference looks good to me.
--
Dominique
--
Crash-utility
赵乾利 wrote on Thu, May 07, 2020:
> This change does not take into account the system sleep,once system
> suspend this translation will make error,printk timestamp and jiffies
> won't be update during suspend,and system suspend is a common
> feature,so i think change is a bug.
This is how the
17 matches
Mail list logo
