Hi Kazuhito,
The first step in the optimization of is_page_ptr() is checked in:
https://github.com/crash-utility/crash/commit/d586679b861fafc99e96c863105826d30de630a7
Thanks,
Dave
- Original Message -
> Hi Dave,
>
> On 2/27/2018 4:45 PM, Kazuhito Hagio wrote:
> [...]
> >> First,
- Original Message -
> Hi Dave,
>
> On 2/27/2018 4:45 PM, Kazuhito Hagio wrote:
> [...]
> >> First, the mem_section numbers are ascending. They may not necessarily
> >> start
> >> with 0, and there may be holes, but they are ascending. That being the
> >> case,
> >> there is no need
Hi Dave,
On 2/27/2018 4:45 PM, Kazuhito Hagio wrote:
[...]
>> First, the mem_section numbers are ascending. They may not necessarily start
>> with 0, and there may be holes, but they are ascending. That being the case,
>> there is no need for is_page_ptr() to walk through NR_MEM_SECTIONS()
Hi Dave,
I'm sorry for my long delay.
On 2/23/2018 12:20 PM, Dave Anderson wrote:
[...]
> This "#ifdef IS_VMEMMAP_PAGE_ADDR" patch is getting really ugly. I've been
> playing around with this, and this is my latest counter-proposal.
Yes, I couldn't think of a way to refine it greatly..
>
- Original Message -
> Hi Dave,
>
> On 2/21/2018 4:14 PM, Dave Anderson wrote:
> >
> >
> > - Original Message -
> >> Hi Dave,
> >>
> >> Thank you so much for your review!
> >>
> >> On 2/21/2018 11:41 AM, Dave Anderson wrote:
> >>>
> >>> Hi Kasuhito,
> >>>
> >>> Just as a
Hi Dave,
On 2/21/2018 4:14 PM, Dave Anderson wrote:
>
>
> - Original Message -
>> Hi Dave,
>>
>> Thank you so much for your review!
>>
>> On 2/21/2018 11:41 AM, Dave Anderson wrote:
>>>
>>> Hi Kasuhito,
>>>
>>> Just as a follow-up review of this part of your original patch:
>>>
>>>
- Original Message -
> Hi Dave,
>
> Thank you so much for your review!
>
> On 2/21/2018 11:41 AM, Dave Anderson wrote:
> >
> > Hi Kasuhito,
> >
> > Just as a follow-up review of this part of your original patch:
> >
> > +#ifdef VMEMMAP_VADDR
> > + nr =
Hi Dave,
Thank you so much for your review!
On 2/21/2018 11:41 AM, Dave Anderson wrote:
>
> Hi Kasuhito,
>
> Just as a follow-up review of this part of your original patch:
>
> +#ifdef VMEMMAP_VADDR
> + nr = nr_mem_sections;
> + if (machdep->flags & VMEMMAP)
Hi Kasuhito,
Just as a follow-up review of this part of your original patch:
+#ifdef VMEMMAP_VADDR
+ nr = nr_mem_sections;
+ if (machdep->flags & VMEMMAP)
+ nr = pfn_to_section_nr((addr - VMEMMAP_VADDR) /
SIZE(page));
+
- Original Message -
> Hi Dave,
>
> On 2/20/2018 11:32 AM, Dave Anderson wrote:
> ...
> > Another suggestion/question -- if is_page_ptr() is called with a NULL
> > phys
> > argument (as is done most of the time), could it skip the "if
> > IS_SPARSEMEM()"
> > section
Hi Dave,
On 2/20/2018 11:32 AM, Dave Anderson wrote:
...
> Another suggestion/question -- if is_page_ptr() is called with a NULL
> phys
> argument (as is done most of the time), could it skip the "if
> IS_SPARSEMEM()"
> section at the top, and still utilize the part at the
- Original Message -
> Hi Dave,
>
> On 2/16/2018 4:18 PM, Dave Anderson wrote:
> ...
> OK, I understand your point. But what concerns me is that the
> function's
> purpose is to absolutely identify whether the incoming page structure
> address
> is a correct
Hi Dave,
On 2/16/2018 4:18 PM, Dave Anderson wrote:
...
OK, I understand your point. But what concerns me is that the function's
purpose is to absolutely identify whether the incoming page structure
address
is a correct page structure address. But if an invalid address gets
- Original Message -
> Hi Dave,
>
> On 2/15/2018 12:38 PM, Dave Anderson wrote:
> ...
> Because of your questions about ppc64, possible backwards-compatibility
> issues,
> or potential future changes to page.flags usage, this permanent change
> to the
>
Hi Dave,
On 2/15/2018 12:38 PM, Dave Anderson wrote:
...
Because of your questions about ppc64, possible backwards-compatibility
issues,
or potential future changes to page.flags usage, this permanent change to
the
is_page_ptr() function solely for the purposes of
- Original Message -
>
>
> - Original Message -
> > Hi Dave,
> >
> > Thank you for your comment!
> >
> > On 2/13/2018 2:33 PM, Dave Anderson wrote:
> > >
> > > Hi Kasuhito,
> > >
> > > I am planning on releasing crash-7.2.1 today, so this will have to be
> > > deferred
> >
- Original Message -
> Hi Dave,
>
> Thank you for your comment!
>
> On 2/13/2018 2:33 PM, Dave Anderson wrote:
> >
> > Hi Kasuhito,
> >
> > I am planning on releasing crash-7.2.1 today, so this will have to be
> > deferred
> > to 7.2.2.
> >
> > Because of your questions about
Hi Dave,
Thank you for your comment!
On 2/13/2018 2:33 PM, Dave Anderson wrote:
>
> Hi Kasuhito,
>
> I am planning on releasing crash-7.2.1 today, so this will have to be
> deferred
> to 7.2.2.
>
> Because of your questions about ppc64, possible backwards-compatibility
> issues,
> or
Hi Kasuhito,
I am planning on releasing crash-7.2.1 today, so this will have to be deferred
to 7.2.2.
Because of your questions about ppc64, possible backwards-compatibility issues,
or potential future changes to page.flags usage, this permanent change to the
is_page_ptr() function solely for
19 matches
Mail list logo
