Re: [cross-project-issues-dev] updating httpcomponents to 5.0.2 for JGit/EGit
On Wed, Oct 7, 2020 at 10:18 PM Matthias Sohn wrote: > On Wed, Oct 7, 2020 at 1:21 PM Aleksandar Kurtakov > wrote: > >> >> >> On Wed, Oct 7, 2020 at 2:15 PM Matthias Sohn >> wrote: >> >>> This is a heads up regarding usage of Apache httpcomponents. >>> We are considering to update httpcomponents (httpcore and httpclient) to >>> 5.0.2 for JGit/EGit. >>> See [1] and the changes adding these new versions to Orbit [2]. >>> I still need to add conscrypt to Orbit which is an optional dependency >>> for the >>> http 2.0 implementation in httpcore5-h2. >>> >>> Let us know if there are any concerns regarding this plan. >>> >> >> Have you considered (or even evaluated) usage of Java 11 HttpClient >> instead? >> > > JGit today's default uses HttpURLConnection in the core org.eclipse.jgit > bundle. Optionally > apache httpclient 4.5.10 can be used instead via the > org.eclipse.jgit.http.apache bundle. > > I am looking at updating the latter to apache httpclient 5.0.2. > According to the migration guide API changes > compared to 4.5.10 aren't huge. > > We may consider to replace the default implementation using > HttpURLConnection in org.eclipse.jgit > with the new Java 11 http client. This would require to update the > execution environment for JGit from Java 8 to 11. > In EGit the user can also choose between the Java built-in http client (currently HttpURLConnection) and Apache httpclient. > > >> >>> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=567654 >>> [2] https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170406/1 >>> https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170407/1 >>> https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170408/1 >>> >>> -Matthias >>> ___ >>> cross-project-issues-dev mailing list >>> cross-project-issues-dev@eclipse.org >>> To unsubscribe from this list, visit >>> https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev >>> >> >> >> -- >> Alexander Kurtakov >> Red Hat Eclipse Team >> ___ >> cross-project-issues-dev mailing list >> cross-project-issues-dev@eclipse.org >> To unsubscribe from this list, visit >> https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev >> > ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
Re: [cross-project-issues-dev] updating httpcomponents to 5.0.2 for JGit/EGit
On Wed, Oct 7, 2020 at 1:21 PM Aleksandar Kurtakov wrote: > > > On Wed, Oct 7, 2020 at 2:15 PM Matthias Sohn > wrote: > >> This is a heads up regarding usage of Apache httpcomponents. >> We are considering to update httpcomponents (httpcore and httpclient) to >> 5.0.2 for JGit/EGit. >> See [1] and the changes adding these new versions to Orbit [2]. >> I still need to add conscrypt to Orbit which is an optional dependency >> for the >> http 2.0 implementation in httpcore5-h2. >> >> Let us know if there are any concerns regarding this plan. >> > > Have you considered (or even evaluated) usage of Java 11 HttpClient > instead? > JGit today's default uses HttpURLConnection in the core org.eclipse.jgit bundle. Optionally apache httpclient 4.5.10 can be used instead via the org.eclipse.jgit.http.apache bundle. I am looking at updating the latter to apache httpclient 5.0.2. According to the migration guide API changes compared to 4.5.10 aren't huge. We may consider to replace the default implementation using HttpURLConnection in org.eclipse.jgit with the new Java 11 http client. This would require to update the execution environment for JGit from Java 8 to 11. > >> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=567654 >> [2] https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170406/1 >> https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170407/1 >> https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170408/1 >> >> -Matthias >> ___ >> cross-project-issues-dev mailing list >> cross-project-issues-dev@eclipse.org >> To unsubscribe from this list, visit >> https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev >> > > > -- > Alexander Kurtakov > Red Hat Eclipse Team > ___ > cross-project-issues-dev mailing list > cross-project-issues-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev > ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
Re: [cross-project-issues-dev] updating httpcomponents to 5.0.2 for JGit/EGit
I haven't worked with httpcomponents 5 yet, but the major segment change from 4-5 could of course signal some non-backward-compatible changes. It's going to take some resources allocation to check for and fix any such required changes...and test of course...in ECF filetransfer/p2. It may make the most sense to create another provider (alongside 4, 45 providers) which would allow using the milestones (e.g.) for testing 'in the wild'. Scott On 10/7/2020 4:14 AM, Matthias Sohn wrote: This is a heads up regarding usage of Apache httpcomponents. We are considering to update httpcomponents (httpcore and httpclient) to 5.0.2 for JGit/EGit. See [1] and the changes adding these new versions to Orbit [2]. I still need to add conscrypt to Orbit which is an optional dependency for the http 2.0 implementation in httpcore5-h2. Let us know if there are any concerns regarding this plan. [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=567654 [2] https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170406/1 https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170407/1 https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170408/1 -Matthias ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
Re: [cross-project-issues-dev] updating httpcomponents to 5.0.2 for JGit/EGit
On Wed, Oct 7, 2020 at 2:15 PM Matthias Sohn wrote: > This is a heads up regarding usage of Apache httpcomponents. > We are considering to update httpcomponents (httpcore and httpclient) to > 5.0.2 for JGit/EGit. > See [1] and the changes adding these new versions to Orbit [2]. > I still need to add conscrypt to Orbit which is an optional dependency for > the > http 2.0 implementation in httpcore5-h2. > > Let us know if there are any concerns regarding this plan. > Have you considered (or even evaluated) usage of Java 11 HttpClient instead? > > [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=567654 > [2] https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170406/1 > https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170407/1 > https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170408/1 > > -Matthias > ___ > cross-project-issues-dev mailing list > cross-project-issues-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev > -- Alexander Kurtakov Red Hat Eclipse Team ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
[cross-project-issues-dev] updating httpcomponents to 5.0.2 for JGit/EGit
This is a heads up regarding usage of Apache httpcomponents. We are considering to update httpcomponents (httpcore and httpclient) to 5.0.2 for JGit/EGit. See [1] and the changes adding these new versions to Orbit [2]. I still need to add conscrypt to Orbit which is an optional dependency for the http 2.0 implementation in httpcore5-h2. Let us know if there are any concerns regarding this plan. [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=567654 [2] https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170406/1 https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170407/1 https://git.eclipse.org/r/c/orbit/orbit-recipes/+/170408/1 -Matthias ___ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
