Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-14 Thread Arvid Brodin
On 2013-11-07 01:11, Kevin Zheng wrote: On 11/03/2013 11:15, Arvid Brodin wrote: Anyway, this needs to be expressed with two keybindings in my code: one with no modifiers (called None in the keybindings dialog), and one with the Run modifier. My code ignores the 'N' here since it means no

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-14 Thread Rick Tanner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/14/13 6:03 PM, Arvid Brodin wrote: Of course, we would have to agree about the default set of direction keys... ;) It's been my observation that the first thing a new player does when they want to move their character - is to use the arrow

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-06 Thread Kevin Zheng
On 11/03/2013 13:56, Mark Wedel wrote: The KP_name seem to depend on if numlock is on or off, so in theory can go, but at same time, I suspect would apply to non sun keyboards if numlock is off. That said, hitting numlock is not hard, although perhaps a warning in the client could be added

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-06 Thread Kevin Zheng
On 11/03/2013 11:15, Arvid Brodin wrote: I think this is a problem with my code. The default Nethack-style bindings look like this (from common/def-keys): Logically that means they should work if no modifier keys are pressed, or with Run pressed. (Are you saying they work with Fire pressed

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Kevin Zheng
On 11/03/2013 08:50, Arvid Brodin wrote: I see what you mean - suddenly there's a lot of noise in the keybindings dialog. What I did was to remove all bindings that I don't use, and it feels OK now. Perhaps that'll work for you as well? If you try it and still hate it, tell me and I'll see

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Arvid Brodin
On 2013-11-03 16:50, Kevin Zheng wrote: On 11/03/2013 08:50, Arvid Brodin wrote: [] - 3 bindings of 'a' to apply (to handle different shift state and modifier states). Replace with a single binding of 'a' with Any flag. In hindsight, there are some issues with setting the directional

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Arvid Brodin
On 2013-11-03 18:15, Arvid Brodin wrote: On 2013-11-03 16:50, Kevin Zheng wrote: On 11/03/2013 08:50, Arvid Brodin wrote: [] - 3 bindings of 'a' to apply (to handle different shift state and modifier states). Replace with a single binding of 'a' with Any flag. In hindsight, there

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-03 Thread Mark Wedel
On 11/ 3/13 06:50 AM, Arvid Brodin wrote: snip - How often do we get new players who use Sun Type 4 Keyboards? Perhaps these could go? (17 bindings.) Some of those still can apply for later sun keyboards (using a type 7 here). Since later keyboards are USB, they work fine on PCs also.

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-02 Thread Kevin Zheng
Committed in r19090. To the best of my knowledge, Crossfire doesn't have a formal patch review process. By the time everyone reviews it, bit rot will have already set in. Best to commit it now and fix issues later if needed. On 11/02/2013 18:24, Arvid Brodin wrote: * Show all keybindings (incl