Re: [crossfire] [RFC 2/3] Misc keybinding fixes and changes

2013-11-02 Thread Arvid Brodin
On 2013-11-01 04:54, David Hurst wrote: I'd be of the view, if it isn't reducing a functionality but re-implementing it in a more useful way (be it more flexible, faster, or any other good reason) then it has my support. This could better be described as removing an arcane feature to simplify

[crossfire] [PATCH 0/2] Work on keys.c and the keybinding system

2013-11-02 Thread Arvid Brodin
I have generated a new set of patches without the removal of the functionality to re-bind key modifiers, and with some minor improvements. Otherwise, they are the same as before. These apply on top of current svn repository (rev 19089). I think we should still remove the functionality that

[crossfire] [PATCH 2/2] Character-specific keybinding files

2013-11-02 Thread Arvid Brodin
Today, keybindings are saved as ~/.crossfire/keys. That means you cannot have different key bindings for each character. This patch changes that so that keybindings are saved as ~/.crossfire/character-name.keys. So if your character is named Leopold, the keybindings are saved to

Re: [crossfire] [RFC 2/3] Misc keybinding fixes and changes

2013-11-02 Thread Kevin Zheng
On 11/02/2013 11:04, Arvid Brodin wrote: That's something of a tall order. :) It's a lot of work learning how _one_ client works; learning two clients and then trying do do only changes that benefit both (and doesn't break any) of them could be very limiting. (Is the Windows compatibility

Re: [crossfire] [PATCH 1/2] Keybindings: multiple changes

2013-11-02 Thread Kevin Zheng
Committed in r19090. To the best of my knowledge, Crossfire doesn't have a formal patch review process. By the time everyone reviews it, bit rot will have already set in. Best to commit it now and fix issues later if needed. On 11/02/2013 18:24, Arvid Brodin wrote: * Show all keybindings (incl