Re: [crossfire] SVN revions in version

2006-10-16 Thread Mark Wedel
Alex Schultz wrote: Agreed with the reason below, but the problem with that, is that version.h shouldn't append -r unless it has a SVN_REV, and easier to check in defines if SVN_REV is defined at all, instead of checking if it's or not. Because of that, it seems like a better idea to me to

Re: [crossfire] SVN revions in version

2006-10-15 Thread Mark Wedel
Alex Schultz wrote: A few times, tracking the svn revision instead of the $Id strings has been brought up. IMHO this should be done, both in the client and server. I propose we implement it as follows in both: Create a version.h file containing something like: #include svnversion.h

Re: [crossfire] SVN revions in version

2006-10-15 Thread Mark Wedel
Brendan Lally wrote: I'm not sure it is such a great idea to send the revision number to the metaserver, certainly not if the metaserver is going to push that information out to clients, in that case, someone who wished to be annoying could look for servers with revisions predating certain

Re: [crossfire] SVN revions in version

2006-10-15 Thread Mark Wedel
Alex Schultz wrote: Brendan Lally wrote: I'm not sure it is such a great idea to send the revision number to the metaserver, certainly not if the metaserver is going to push that information out to clients, in that case, someone who wished to be annoying could look for servers with revisions

Re: [crossfire] SVN revions in version

2006-10-15 Thread Mark Wedel
Christian Hujer wrote: On Friday 13 October 2006 19:15 Brendan Lally wrote: Likewise, although the clients need only open a connection to the metaserver to recieve the server list, having the official clients send their revision numbers by default would give some indication as to which

Re: [crossfire] SVN revions in version

2006-10-15 Thread Alex Schultz
Mark Wedel wrote: It should actually get that version number from autoconf, like it does now. Then as part of that, for official releases, the -dev tag can be removed from configure.ac I didn't know that autoconf currently stored that. That makes sense to me. In addition, if the

[crossfire] SVN revions in version

2006-10-13 Thread Alex Schultz
A few times, tracking the svn revision instead of the $Id strings has been brought up. IMHO this should be done, both in the client and server. I propose we implement it as follows in both: Create a version.h file containing something like: #include svnversion.h #define BASE_VERSION 2.0.0-dev

Re: [crossfire] SVN revions in version

2006-10-13 Thread Brendan Lally
On 10/13/06, Alex Schultz [EMAIL PROTECTED] wrote: A few times, tracking the svn revision instead of the $Id strings has been brought up. IMHO this should be done, both in the client and server. I propose we implement it as follows in both: This version would both be used in the

Re: [crossfire] SVN revions in version

2006-10-13 Thread Alex Schultz
Brendan Lally wrote: I'm not sure it is such a great idea to send the revision number to the metaserver, certainly not if the metaserver is going to push that information out to clients, in that case, someone who wished to be annoying could look for servers with revisions predating certain bug

Re: [crossfire] SVN revions in version

2006-10-13 Thread Brendan Lally
On 10/13/06, Christian Hujer [EMAIL PROTECTED] wrote: Likewise, although the clients need only open a connection to the metaserver to recieve the server list, having the official clients send their revision numbers by default would give some indication as to which versions of the clients