[crossfire] [PATCH] Fix keybinding bug when connected to server-1.12

2013-11-04 Thread Arvid Brodin
As the subject says. The patch should apply to client trunk rev 19091. The fix is in three parts: * If no character name is given (is NULL), don't load or save character-specific keys file. * Load key bindings directly on startup, when name is NULL. * If playing on a server with a login

Re: [crossfire] [PATCH] Fix keybinding bug when connected to server-1.12

2013-11-04 Thread Kevin Zheng
On 11/04/2013 17:41, Arvid Brodin wrote: As the subject says. The patch should apply to client trunk rev 19091. Committed in r19094, thanks! Also, please do not modify the patches when applying them since it messes up any patches that I have queued. If something should be changed, tell

Re: [crossfire] [PATCH 2/2] Character-specific keybinding files

2013-11-04 Thread Mark Wedel
On 11/ 4/13 05:34 AM, Arvid Brodin wrote: On 2013-11-04 07:38, Mark Wedel wrote: On 11/ 3/13 03:03 PM, Kevin Zheng wrote: On 11/03/2013 13:36, Mark Wedel wrote: Just a question - is there any way to set up 'global' keybindings (eg, those that apply to all characters)? This does seem

Re: [crossfire] Use of svn:externals in client code on SVN

2013-11-04 Thread Mark Wedel
On 11/ 4/13 04:41 PM, Kevin Zheng wrote: Hi there, Crossfire currently uses svn:externals to sync protocol definition headers between the server and GTKv2 client. While this has its merits, overall I believe it is confusing, cumbersome, and harmful. From the SVN Book [1]: An externals