Re: [Cryptodev-linux-devel] [RFC 1/9] fix private data memleak

2014-01-27 Thread Phil Sutter
Hey Christian, On Mon, Jan 27, 2014 at 07:53:56AM +, cristian.sto...@freescale.com wrote: > > Why should that be necessary? > The patch is concerned with 'close' being called with garbage input. > I'm not sure about the call chain here: is 'close' never called when 'open' > fails? What is the

Re: [Cryptodev-linux-devel] [RFC 1/9] fix private data memleak

2014-01-26 Thread cristian.sto...@freescale.com
Hi Phil, > Why should that be necessary? The patch is concerned with 'close' being called with garbage input. I'm not sure about the call chain here: is 'close' never called when 'open' fails? What is the assumption of the caller? > I just did a quick test, simply assigning > NULL to pcr instead

Re: [Cryptodev-linux-devel] [RFC 1/9] fix private data memleak

2014-01-24 Thread Phil Sutter
Hi Christian, On Thu, Jan 23, 2014 at 07:29:06AM +, cristian.sto...@freescale.com wrote: > You may want to have a look at this patch since it addresses an incomplete > fix of mine. [snip] > > diff --git a/ioctl.c b/ioctl.c > > index 999fb31..7a69e5a 100644 > > --- a/ioctl.c > > +++ b/ioctl.

Re: [Cryptodev-linux-devel] [RFC 1/9] fix private data memleak

2014-01-22 Thread cristian.sto...@freescale.com
Hi Phil, You may want to have a look at this patch since it addresses an incomplete fix of mine. Thanks, Cristian S. > -Original Message- > From: Horia Geanta [mailto:horia.gea...@freescale.com] > Sent: Thursday, December 12, 2013 6:10 PM > To: Nikos Mavrogiannopoulos > Cc: cryptodev-li

[Cryptodev-linux-devel] [RFC 1/9] fix private data memleak

2013-12-12 Thread Horia Geanta
From: Cristian Stoica This is the correct memleak fix as intended by 50e714aeff2d6fb4c9d5793a706abb330aa073fc. The original fix does not address deallocation problems when kzalloc(pcr) fails. Signed-off-by: Cristian Stoica Signed-off-by: Horia Geanta --- ioctl.c |2 +- 1 files changed, 1