Re: [Cryptodev-linux-devel] [PATCH] fix tag and dst_len calculation for aead ciphers
Hi Phil, On 05.08.2014 01:36, Phil Sutter wrote: On Thu, Jul 10, 2014 at 01:32:59PM +0300, Cristian Stoica wrote: Calculate tag and destination buffer length in a single place to avoid code duplication. The TLS case is fixed by rounding the destination length to cipher block size. Applied, thanks. Again, sorry for the delay. The patch doesn't show up on the git repository. Let me know if you've just missed the push or are still reviewing so I can help you with it. Thanks, Cristian S. ___ Cryptodev-linux-devel mailing list Cryptodev-linux-devel@gna.org https://mail.gna.org/listinfo/cryptodev-linux-devel
Re: [Cryptodev-linux-devel] [PATCH] fix tag and dst_len calculation for aead ciphers
Hi Christian, On Mon, Aug 18, 2014 at 04:17:42PM +0300, Cristian Stoica wrote: Hi Phil, On 05.08.2014 01:36, Phil Sutter wrote: On Thu, Jul 10, 2014 at 01:32:59PM +0300, Cristian Stoica wrote: Calculate tag and destination buffer length in a single place to avoid code duplication. The TLS case is fixed by rounding the destination length to cipher block size. Applied, thanks. Again, sorry for the delay. The patch doesn't show up on the git repository. Let me know if you've just missed the push or are still reviewing so I can help you with it. But it is there. Maybe you pull from Nikos' repository? The 'official' upstream has moved to: https://github.com/cryptodev-linux/cryptodev-linux I just noticed, cryptodev-linux.org points to Nikos' clone, as well which should be fixed. Cheers, Phil ___ Cryptodev-linux-devel mailing list Cryptodev-linux-devel@gna.org https://mail.gna.org/listinfo/cryptodev-linux-devel
Re: [Cryptodev-linux-devel] [PATCH] fix tag and dst_len calculation for aead ciphers
On Thu, Jul 10, 2014 at 01:32:59PM +0300, Cristian Stoica wrote: Calculate tag and destination buffer length in a single place to avoid code duplication. The TLS case is fixed by rounding the destination length to cipher block size. Applied, thanks. Again, sorry for the delay. Cheers, Phil ___ Cryptodev-linux-devel mailing list Cryptodev-linux-devel@gna.org https://mail.gna.org/listinfo/cryptodev-linux-devel
Re: [Cryptodev-linux-devel] [PATCH] fix tag and dst_len calculation for aead ciphers
On Tue, Jul 22, 2014 at 11:16 AM, cristian.sto...@freescale.com cristian.sto...@freescale.com wrote: Hi guys, Let me know what you think about this patch. Short of the TLS dst_len rounding fix, it should be just a refactoring. Replacing CIOCAUTHCRYPT with another ioctl that takes dst_len is not such a good idea in practice. The transition needs a lot of code duplication that has to be tested for regressions and compatibility with the old code. I've tried it and the patches are not pretty. Please don't rely on an answer from me... If you think it is ok just push it in. I'm too busy with other things :( regards, Nikos ___ Cryptodev-linux-devel mailing list Cryptodev-linux-devel@gna.org https://mail.gna.org/listinfo/cryptodev-linux-devel
