Re: Select returns -1 on all the multi examples in win32

2014-11-19 Thread Ray Satiro
On 11/19/2014 7:45 AM, Daniel Stenberg wrote: On Mon, 17 Nov 2014, Ray Satiro wrote: The multi examples other than multi-single don't follow the documented cleanup order [1]. It would of course be nice to get them to use the proper order as well. The order is more a SHOULD than MUST though a

RE: [PATCH v2] cmake: fix NTLM detection and add Kerberos feature

2014-11-19 Thread Steve Holme
On Wed, 19 Nov 2014, Peter Wu wrote: > As I was involved in the original changes on which this is based I have > pushed - however I have split the NTLM and Kerberos change as one > is a fix and the other an addition. > > By the way, I noticed that the author URL contains the four characters > "_at

Re: [PATCH v2] cmake: fix NTLM detection and add Kerberos feature

2014-11-19 Thread Peter Wu
On Wednesday 19 November 2014 19:59:09 Steve Holme wrote: > On Wed, 19 Nov 2014, Peter Wu wrote: > > > Based on recent configure patches: > > > >eda919f configure: Added krb5 to the supported features > >f0d860d configure: Fixed NTLM missing from features when > > CURL_DISABLE_HTTP define

RE: [PATCH 1/7] Comment and debug output fixes.

2014-11-19 Thread Steve Holme
On Tue, 18 Nov 2014, Daniel Stenberg wrote: > Thanks! I pushed this now with a slightly modified commit message. I've pushed a follow up commit (34cb17b930) to fix up the infof() type specifiers as we were discussing ;-) Kind Regards Steve -

RE: [PATCH v2] cmake: fix NTLM detection and add Kerberos feature

2014-11-19 Thread Steve Holme
On Wed, 19 Nov 2014, Peter Wu wrote: > Based on recent configure patches: > >eda919f configure: Added krb5 to the supported features >f0d860d configure: Fixed NTLM missing from features when CURL_DISABLE_HTTP > defined >fe0f896 configure: assume krb5 when gss-api works >676d62f co

Re: [PATCH] PEM support for Public Key Pinning

2014-11-19 Thread moparisthebest
Hello all, Thanks again Patrick for the ideas and pointers, I have attached the latest patch taking all of those into account. It can also be viewed on github here: https://github.com/moparisthebest/curl/commit/f3d46818d7af759d90e8147554aaaf05cb0d75f6 Thanks much, moparisthebest From f3d46818d7

Re: documentation update

2014-11-19 Thread bch
Does this look more sane?: Index: src/vendor/curl/docs/libcurl/opts/CURLOPT_POSTFIELDS.3 == --- src/vendor/curl/docs/libcurl/opts/CURLOPT_POSTFIELDS.3 +++ src/vendor/curl/docs/libcurl/opts/CURLOPT_POSTFIELDS.3 @@ -33,10 +33,12 @@ se

Re: [PATCH 3/7] pipelining: Keep bundle when closing broken pipe.

2014-11-19 Thread Carlo Wood
Please ignore the rest of this thread. I will re-submit the remaining patches in a new thread. --- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html

[PATCH v2] cmake: fix NTLM detection and add Kerberos feature

2014-11-19 Thread Peter Wu
Based on recent configure patches: eda919f configure: Added krb5 to the supported features f0d860d configure: Fixed NTLM missing from features when CURL_DISABLE_HTTP defined fe0f896 configure: assume krb5 when gss-api works 676d62f configure: Fixed inclusion of krb5 when CURL_DISA

Re: [PATCH] CMake: Simplify if() conditions on check result variables

2014-11-19 Thread Brad King
On 11/19/2014 5:35 AM, Daniel Stenberg wrote: > Thanks, pushed! Looks good, thanks! -Brad --- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html

RE: Inclusion of Connection-Specific Headers in h2c

2014-11-19 Thread Lucas Pardue
I've attached a HTTP/2 multi example that I believe exhibits the same issue reported. This is a best effort and I've taken some artistic license in modifying the code to emulate the behaviour of our real code. There may be errors, introduced by me or in the real code; either way it will be help

Re: Select returns -1 on all the multi examples in win32

2014-11-19 Thread Daniel Stenberg
On Mon, 17 Nov 2014, Ray Satiro wrote: Ok I did that and submitted it via pull request last night. The changes were pretty straightforward. Thanks a lot, I just merged that one. The multi examples other than multi-single don't follow the documented cleanup order [1]. It would of course be

Re: [PATCH v2] cmake: fix NTLM detection and add krb5 feature

2014-11-19 Thread Daniel Stenberg
On Mon, 17 Nov 2014, Peter Wu wrote: Daniel, could you add this to the commit message when applying, and rename the symbol or do you want me to spin a new patch? It'd be awesome if you could respin thanks, and please add an "Acked-by: Brad King" line in the message if it is already acked like

Re: [PATCH] CMake: Simplify if() conditions on check result variables

2014-11-19 Thread Daniel Stenberg
On Fri, 14 Nov 2014, Brad King wrote: Remove use of an old hack that takes advantage of the auto-dereference behavior of the if() command to detect if a variable is defined. The hack has the form: Thanks, pushed! -- / daniel.haxx.se

Re: documentation update

2014-11-19 Thread Daniel Stenberg
On Tue, 18 Nov 2014, Dan Fandrich wrote: or adding a sentence at the end of this paragraph suggesting that CURLOPT_COPYPOSTFIELDS is a way around this limitation. Yeah, that'd be my preference. Making sure that the alternative that actually DOES copy is conveyed properly. -- / daniel.haxx

Re: Please remove TODO-RELEASE

2014-11-19 Thread Daniel Stenberg
On Tue, 18 Nov 2014, Michael Osipov wrote: can someone kindly remove [1] and [2]?! I guess I am not the only one who is irritated by the missing/empty content. Yeah, we/I haven't used that in a good while. Removing... Thanks for pointing this out! -- / daniel.haxx.se -