Re: Does the source tree need to be clean for an out-of-source cmake build?

2017-09-09 Thread Daniel Stenberg
On Sat, 9 Sep 2017, Peter Wu wrote: Last time I looked, only the include paths and a header needed fixing: https://github.com/curl/curl/pull/1291 In meantime curlbuild.h is gone, but there might be other issues now. (Note that the PR was rejected.) The lib/curl_config.h is probably still

Re: Does the source tree need to be clean for an out-of-source cmake build?

2017-09-08 Thread Peter Wu
Hi, Last time I looked, only the include paths and a header needed fixing: https://github.com/curl/curl/pull/1291 In meantime curlbuild.h is gone, but there might be other issues now. (Note that the PR was rejected.) Rejecting in-tree sounds interesting, would this also be possible for

Re: Re: Does the source tree need to be clean for an out-of-source cmake build?

2017-09-07 Thread Zakrzewski, Jakub
> BTW, we can enforce out-of-source build rule for cmakeable builds, as > LLVM does... That is a good idea. It's actually like 3 lines of CMake script. --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette:

Re: Does the source tree need to be clean for an out-of-source cmake build?

2017-09-07 Thread Sergei Nikulov via curl-library
2017-09-07 10:45 GMT+03:00 Daniel Stenberg : > On Thu, 7 Sep 2017, Ray Satiro via curl-library wrote: > >> My question is, is this expected? I thought if I did an out-of-source >> build tree that it would not use build files from the source tree. > > > I think as a general rule,

Re: Does the source tree need to be clean for an out-of-source cmake build?

2017-09-07 Thread Daniel Stenberg
On Thu, 7 Sep 2017, Ray Satiro via curl-library wrote: My question is, is this expected? I thought if I did an out-of-source build tree that it would not use build files from the source tree. I think as a general rule, mixing in-tree and out-of-tree builds will cause problems and I don't

Does the source tree need to be clean for an out-of-source cmake build?

2017-09-06 Thread Ray Satiro via curl-library
In Windows I have a source tree that I used to build curl using mingw with the build tree the same as the source tree, X:\j\curl\curl_mingw. curl_config.h was output to X:\j\curl\curl_mingw\lib\curl_config.h. I thought I could use that same source tree to build curl by using cmake with an