Re: How to set service name for SPNEGO?

2015-04-17 Thread Linus Nielsen
On 04/06/2015 05:26 PM, Linus Nielsen wrote: On 04/04/2015 12:51 AM, Daniel Stenberg wrote: Thanks! I'm fine with the change and as there's at least one user saying it looks fine I'm happy. I have no way of testing this myself. The changes seems totally benign to me. One thing worries me a

Re: How to set service name for SPNEGO?

2015-04-17 Thread Wenlong Dong
Linus, thanks a lot! The change to STRING_SERVICE_NAME part looks great. I am looking forward to seeing this in. Best regards, Wenlong On Fri, Apr 17, 2015 at 5:46 AM, Linus Nielsen li...@haxx.se wrote: On 04/06/2015 05:26 PM, Linus Nielsen wrote: On 04/04/2015 12:51 AM, Daniel Stenberg

Re: How to set service name for SPNEGO?

2015-04-06 Thread Linus Nielsen
On 04/04/2015 12:51 AM, Daniel Stenberg wrote: Thanks! I'm fine with the change and as there's at least one user saying it looks fine I'm happy. I have no way of testing this myself. The changes seems totally benign to me. One thing worries me a little, the CURLOPT_PROXY_SERVICE_NAME option.

Re: How to set service name for SPNEGO?

2015-04-03 Thread Daniel Stenberg
On Wed, 1 Apr 2015, Linus Nielsen wrote: Good catch. It is. Use the attached patch instead. It should be applied to the latest git master. Thanks! I'm fine with the change and as there's at least one user saying it looks fine I'm happy. I have no way of testing this myself. The changes seems

Re: How to set service name for SPNEGO?

2015-04-01 Thread Linus Nielsen
On 04/01/2015 05:51 AM, Wenlong Dong wrote: Linus, thanks a lot for making the change! The change overall looks great to me. I was not able to patch it locally somehow (not sure whether I have to find the exact commit to sync to) and here are some minor comments: *) lib/http_negotiate.c: /+

Re: How to set service name for SPNEGO?

2015-03-31 Thread Wenlong Dong
Linus, thanks a lot for making the change! The change overall looks great to me. I was not able to patch it locally somehow (not sure whether I have to find the exact commit to sync to) and here are some minor comments: *) lib/http_negotiate.c: *+char *spn = Curl_sasl_build_gssapi_spn(* *+

Re: How to set service name for SPNEGO?

2015-03-30 Thread Linus Nielsen
On 02/19/2015 12:11 AM, Steve Holme wrote: Some more random thoughts from me this evening... I wouldn't recommend replacing CURLOPT_SOCKS5_GSSAPI_SERVICE with CURLOPT_SERVICE_NAME as Socks 5 is used as a proxy and a curl user / libcurl programmer might want to set both the proxy and the

Re: How to set service name for SPNEGO?

2015-02-19 Thread Wenlong Dong
Steve, many thanks! Your thinking makes total sense to me after looking at the code. Socks5/proxy are indeed separate. I just checked our legal counsel. Unfortunately our policy does not allow me to contribute code into libcurl. I am sorry about that. It would be great if someone else can help to

RE: How to set service name for SPNEGO?

2015-02-18 Thread Steve Holme
On Tue, 17 Feb 2015, Wenlong Dong wrote: * I'd rather support this across all of our mechanisms that use a SPN (such as Socks 5, SPNEGO, Kerberos, Digest) in each of the GSS-API, SSPI and Native implementations * Possibly deprecate CURLOPT_SOCKS5_GSSAPI_SERVICE (I would suggest a new

Re: How to set service name for SPNEGO?

2015-02-17 Thread Wenlong Dong
Steve, thanks a lot for the quick response! Those are great comments. Let me try to put together a change with what you mentioned. In that case CURLOPT_SERVICE_NAME makes more sense. For negotiate/Kerberos, we let the libcurl to append the host name to generate the SPN as servicename/host. On

RE: How to set service name for SPNEGO?

2015-02-17 Thread Steve Holme
On Tue, 17 Feb 2015, Steve Holme wrote: As you have found out it isn't too hard to do this. However, * I'd rather support this across all of the server name authentication mechanisms * Possibly deprecate CURLOPT_SOCKS5_GSSAPI_SERVICE * The code hasn't also changed quite a bit since v7.36

RE: How to set service name for SPNEGO?

2015-02-17 Thread Steve Holme
On Tue, 17 Feb 2015, Wenlong Dong wrote: I investigated this further and could not find out a good way to set the service identiy/name. Unfortunately there isn't at the moment - not at least for the HTTP or SASL based protocols. The closest we have to it at the moment is

Re: How to set service name for SPNEGO?

2015-02-16 Thread Wenlong Dong
I investigated this further and could not find out a good way to set the service identiy/name. So I went ahead and created this simple diff http://www.pastebin.ca/2929587 on top of libcurl version 7.36.0. Basically I added a new curl option CURLOPT_NEGOTIATE_SERVICE_IDENTITY for people to specify