Re: Nmake install prefix

2019-06-16 Thread Thomas Gamper via curl-library
Hi, I handle it identically to WITH_DEVEL, so I think it may be fine. Created a pull request: https://github.com/curl/curl/pull/4031 Thanks, Thomas Am 16.06.2019 um 12:18 schrieb Rod Widdowson via curl-library: Any Windows developer who would object? Not from here. Looks pretty benign.

RE: Nmake install prefix

2019-06-16 Thread Rod Widdowson via curl-library
> Any Windows developer who would object? Not from here. Looks pretty benign. Some side notes: I can never remember under what circumstances NMAKE inherits environmental variable (with and withour /e) so I cannot work out whether this wouldn't either need some work in Makefile.vc and/or

Re: Nmake install prefix

2019-06-15 Thread Daniel Stenberg via curl-library
On Sat, 15 Jun 2019, Thomas Gamper via curl-library wrote: As I was working on a script to automate the nmake based build of libcurl, I noticed that the installation directory for the built files is hardwired. Would the attached patch, that allows one to supply a install prefix, be considered