Re: Test 1061 flaky when run without valgrind

2021-01-11 Thread Ray Satiro via curl-library
On 1/11/2021 3:01 AM, Fabian Keil via curl-library wrote: Ray Satiro via curl-library wrote on 2021-01-10: On 1/10/2021 5:33 PM, Daniel Stenberg via curl-library wrote: On Sun, 10 Jan 2021, Fabian Keil via curl-library wrote: The attached patch seems to work around the problem.

Re: Test 1061 flaky when run without valgrind

2021-01-11 Thread Fabian Keil via curl-library
Ray Satiro via curl-library wrote on 2021-01-10: > On 1/10/2021 5:33 PM, Daniel Stenberg via curl-library wrote: > > On Sun, 10 Jan 2021, Fabian Keil via curl-library wrote: > > > >> The attached patch seems to work around the problem. > >> Busy-looping probably isn't the right solution, though.

Re: Test 1061 flaky when run without valgrind

2021-01-10 Thread Ray Satiro via curl-library
On 1/10/2021 5:33 PM, Daniel Stenberg via curl-library wrote: On Sun, 10 Jan 2021, Fabian Keil via curl-library wrote: The attached patch seems to work around the problem. Busy-looping probably isn't the right solution, though. Yeah, that's just not the right fix. When the code returns

Re: Test 1061 flaky when run without valgrind

2021-01-10 Thread Daniel Stenberg via curl-library
On Sun, 10 Jan 2021, Fabian Keil via curl-library wrote: The attached patch seems to work around the problem. Busy-looping probably isn't the right solution, though. Yeah, that's just not the right fix. When the code returns there (http_proxy.c line 346) due to CURLE_AGAIN having been

Re: Test 1061 flaky when run without valgrind

2021-01-10 Thread Fabian Keil via curl-library
Fabian Keil via curl-library wrote on 2021-01-09: > Fabian Keil via curl-library wrote on 2021-01-08: > > > using a curl binary built from git master 060658f634, test 1061 > > works reliably for me when valgrind is being used but is flaky > > without it: [...] > The problem seems to be that

Re: Test 1061 flaky when run without valgrind

2021-01-09 Thread Daniel Stenberg via curl-library
On Sat, 9 Jan 2021, Fabian Keil via curl-library wrote: The problem seems to be that curl is ignoring the authentication request. Looks like it might be varying depending on platform too as I can run it a 100 times in a row on Linux without any issue. Which I suppose also explains why we

Re: Test 1061 flaky when run without valgrind

2021-01-09 Thread Fabian Keil via curl-library
Fabian Keil via curl-library wrote on 2021-01-08: > using a curl binary built from git master 060658f634, test 1061 > works reliably for me when valgrind is being used but is flaky > without it: > > fk@t520 ~/git/curl/tests $./runtests.pl -n 1061 1061 1061 1061 1061 1061 > 1061 1061 1061

Test 1061 flaky when run without valgrind

2021-01-08 Thread Fabian Keil via curl-library
Hi, using a curl binary built from git master 060658f634, test 1061 works reliably for me when valgrind is being used but is flaky without it: fk@t520 ~/git/curl/tests $./runtests.pl -n 1061 1061 1061 1061 1061 1061 1061 1061 1061 1061 * System characteristics *