Re: libcurl truncating long cookies?

2017-09-09 Thread Kevin Smith via curl-library
Yeah, I see in the code where a check could be added for making sure the cookie value is not too long. I have never submitted a fix to curl before, do I just provide a diff here or open a pull request in Github? Would you want any unit test to show it is working? On Sat, Sep 9, 2017 at 2:08 AM,

Re: Compile warning on Fedora-26

2017-09-09 Thread Michael Kaufmann
Daniel Stenberg wrote: On Wed, 6 Sep 2017, Ben Greear wrote: Is there a good fix for this warning, or do I just need to turn off strict warnings? ... vtls/openssl.c: In function ‘ossl_connect_step1’: vtls/openssl.c:2091:5: warning: ‘SSLv3_client_method’ is deprecated

Re: libcurl truncating long cookies?

2017-09-09 Thread Daniel Stenberg
On Fri, 8 Sep 2017, Kevin Smith via curl-library wrote: "If for some reason there is inadequate space to store the cookie, it must be discarded, not truncated." I am using libcurl 7.49.1 and I am seeing that cookies seem to get truncated when they are too long instead of discarded, is this

Re: Does the source tree need to be clean for an out-of-source cmake build?

2017-09-09 Thread Daniel Stenberg
On Sat, 9 Sep 2017, Peter Wu wrote: Last time I looked, only the include paths and a header needed fixing: https://github.com/curl/curl/pull/1291 In meantime curlbuild.h is gone, but there might be other issues now. (Note that the PR was rejected.) The lib/curl_config.h is probably still

libcurl truncating long cookies?

2017-09-09 Thread Kevin Smith via curl-library
Hey, I am looking at an issue with libcurl where it seems that very long cookies are getting truncated. I see that in lib/cookie.h there are these two values: #define MAX_COOKIE_LINE 5000 and #define MAX_COOKIE_LINE_TXT "4999" I am seeing if I get back a cookie of length more than 5000 that