Hi,
I handle it identically to WITH_DEVEL, so I think it may be fine.
Created a pull request: https://github.com/curl/curl/pull/4031
Thanks,
Thomas
Am 16.06.2019 um 12:18 schrieb Rod Widdowson via curl-library:
Any Windows developer who would object?
Not from here. Looks pretty benign.
Some side notes:
I can never remember under what circumstances NMAKE inherits environmental
variable (with and withour /e) so I cannot work out whether this wouldn't
either need some work in Makefile.vc and/or whether you can just doing by
condionalizing the setting of DESTDIR on DESTDIR. Also whether it works from
the command line as well as in the environment...
If this is a supported variable you need to make a suitable change to
MakeFile.vc (alongside WITH_DEVEL and so on).
Finally as a general code thing I think I'd prefer
!IFDEF WITH_PREFIX
DIRDIST = $(WITH_PREFIX)
!ELSE
DIRDIST = ..\builds\$(CONFIG_NAME_LIB)\
!ENDIF
Finally, if you take this to Github can someone mark me a reviewer and I'll try
to do a test build? I recently stopped getting all github mails for curl since
I was getting swamped...
R
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette: https://curl.haxx.se/mail/etiquette.html
