RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-16 Thread Steve Holme
Hi Daniel, For your convenience I have renamed and reattached those two patches to this email. Thanks a lot, pushed! Cheers. I've enclosed a slightly reworked version of the patch to add the --mail-auth command line argument to curl itself. I've also enclosed a small SMTP code policing /

RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-16 Thread Daniel Stenberg
On Thu, 16 Feb 2012, Steve Holme wrote: I've enclosed a slightly reworked version of the patch to add the Thanks, I pushed both patches now and I contributed with a short --mail-auth description to the docs/curl.1 man page. -- / daniel.haxx.se

RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-15 Thread Steve Holme
Hi Daniel, Looking at the git log I think that was my original patch from October as opposed to the slightly updated version from January. Oh, argh. Sorry. Please check and send us an updated patch for the diff! No problem. I've checked the changes this morning and yes patches 2, 3 and 4

RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-15 Thread Daniel Stenberg
On Wed, 15 Feb 2012, Steve Holme wrote: For your convenience I have renamed and reattached those two patches to this email. Thanks a lot, pushed! -- / daniel.haxx.se --- List admin:

[PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-14 Thread Steve Holme
Dear all, Firstly I must apologise for being quiet over the last couple of weeks. but unfortunately I joined the Four Zero club so have been away from my PC drowning my sorrows ;-) I'm now back and if anyone needs my input into anything POP3 / SMTP related please feel free to give me a nudge.

Re: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-14 Thread Rich Gray
Steve Holme wrote: Dear all, Firstly I must apologise for being quiet over the last couple of weeks. but unfortunately I joined the Four Zero club so have been away from my PC drowning my sorrows ;-) Hi Steve, Welcome back from your... uh... mid-life crisis? :-O I'm now back and if anyone

Re: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-14 Thread Daniel Stenberg
On Tue, 14 Feb 2012, Steve Holme wrote: Firstly I must apologise for being quiet over the last couple of weeks. but unfortunately I joined the Four Zero club so have been away from my PC drowning my sorrows ;-) Haha, you youngster you! (unless you count in hex) =) I hear the upside with old

RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-14 Thread Steve Holme
Hi Rich, Welcome back from your... uh... mid-life crisis? :-O Thank you... but unfortunately, it didn't involve naked ladies or Lamborghinis much to my disappointment :( I would appreciate your comments on these: Jan 31: State of POP3 in curl? Feb 8: POP3 returns line data and CRLF

RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-14 Thread Steve Holme
Hi Daniel, Haha, you youngster you! (unless you count in hex) =) I hear the upside with Hehehe - whilst I feel that old at the moment I was speaking in base 10 ;-) old age is that you need less sleep, which would mean more time for curl hacking! True... I best get cracking then! As such

RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-14 Thread Daniel Stenberg
On Tue, 14 Feb 2012, Steve Holme wrote: Whilst I'm here, did you have any thoughts about my patches from 07th Jan regarding the optional AUTH parameter in SMTP's MAIL FROM? Oh, look at that. Now I remember what that git branch I had lying around was made for! =) I rebased it, edited the

RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-14 Thread Steve Holme
Hi Daniel, Whilst I'm here, did you have any thoughts about my patches from 07th Jan regarding the optional AUTH parameter in SMTP's MAIL FROM? Oh, look at that. Now I remember what that git branch I had lying around was made for! =) I rebased it, edited the conflict and now I've

RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-14 Thread Daniel Stenberg
On Tue, 14 Feb 2012, Steve Holme wrote: And if you manage to come up with a test case for it... Am I correct in thinking that the test cases don't run under Windows? I guess I can still write test cases even though I can't run them though! I think they will run if you use something like

RE: [PATCH] SMTP: Fixed error when using CURLOPT_CONNECT_ONLY

2012-02-14 Thread Daniel Stenberg
On Tue, 14 Feb 2012, Steve Holme wrote: Looking at the git log I think that was my original patch from October as opposed to the slightly updated version from January. Oh, argh. Sorry. Please check and send us an updated patch for the diff! -- / daniel.haxx.se